search for: pylint

...t;rjones@redhat.com wrote: > On Fri, Dec 07, 2018 at 02:44:21AM +0200, Nir Soffer wrote: > > Fix rhv-cafile option access, broken by commit 6694028f9827 (v2v: -o > > rhv-upload: Only set SSL context for https connections). > > Ugh yes indeed. Strong typing FTW _again_ "pylint -E" may detect such issues. ... > > Will apply shortly, thanks. > > Rich. > > > .gnulib | 2 +- > > v2v/rhv-upload-plugin.py | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/.gnulib b/.gnulib >...

Replace python 2 only "buffer" with "memoryview". Falling back to emulated zero would fail with: NameError: name 'buffer' is not defined I did not test the changed code but it was not tested before so it is unlikely to be worse. Detected by pylint. --- v2v/rhv-upload-plugin.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/v2v/rhv-upload-plugin.py b/v2v/rhv-upload-plugin.py index 3272c3ce3..12d4e68f7 100644 --- a/v2v/rhv-upload-plugin.py +++ b/v2v/rhv-upload-plugin.py @@ -416,41 +416,41 @@ def emulate_zero(h, count, off...

...quot;. > > > > Falling back to emulated zero would fail with: > > > > NameError: name 'buffer' is not defined > > > > I did not test the changed code but it was not tested before so it is > > unlikely to be worse. > > > > Detected by pylint. > > Thanks - I pushed both. > > I wonder how the pread method worked before? That's on the main path > I think. > I never seen a READ request on imageio log, so it seems that qemu-img convert never read from the destination. Nir

...File "/usr/lib/python2.7/site-packages/certbot/_internal/main.py", line 20, in <module> from certbot._internal import account File "/usr/lib/python2.7/site-packages/certbot/_internal/account.py", line 18, in <module> from acme.client import ClientBase # pylint: disable=unused-import File "/usr/lib/python2.7/site-packages/acme/client.py", line 39, in <module> requests.packages.urllib3.contrib.pyopenssl.inject_into_urllib3() # type: ignore File "/usr/lib/python2.7/site-packages/urllib3/contrib/pyopenssl.py", line 118, in...

...;, "value"} instead of dict literal {"key": "value"}. Calling pread() will fail with: AttributeError: 'set' object has no attribute 'items' I did not test the changed code, but it was not tested before, so it is unlikely to be worse. Detected by pylint. --- v2v/rhv-upload-plugin.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/v2v/rhv-upload-plugin.py b/v2v/rhv-upload-plugin.py index 3272c3ce3..e651bc686 100644 --- a/v2v/rhv-upload-plugin.py +++ b/v2v/rhv-upload-plugin.py @@ -321,41 +321,41 @@ def request_failed(h, r, msg):...

..."buffer" with "memoryview". > > Falling back to emulated zero would fail with: > > NameError: name 'buffer' is not defined > > I did not test the changed code but it was not tested before so it is > unlikely to be worse. > > Detected by pylint. Thanks - I pushed both. I wonder how the pread method worked before? That's on the main path I think. Rich. > v2v/rhv-upload-plugin.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/v2v/rhv-upload-plugin.py b/v2v/rhv-upload-plugin.py > index 3272...

.../python2.7/site-packages/certbot/_internal/main.py", line > 20, in <module> > from certbot._internal import account > File "/usr/lib/python2.7/site-packages/certbot/_internal/account.py", > line 18, in <module> > from acme.client import ClientBase # pylint: disable=unused-import > File "/usr/lib/python2.7/site-packages/acme/client.py", line 39, in > <module> > requests.packages.urllib3.contrib.pyopenssl.inject_into_urllib3() # > type: ignore > File "/usr/lib/python2.7/site-packages/urllib3/contrib/pyopenssl.p...

Fix rhv-cafile option access, broken by commit 6694028f9827 (v2v: -o rhv-upload: Only set SSL context for https connections). --- .gnulib | 2 +- v2v/rhv-upload-plugin.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.gnulib b/.gnulib index 6ccfbb4ce..646a44e1b 160000 --- a/.gnulib +++ b/.gnulib @@ -1 +1 @@ -Subproject commit

.../build/buildd-linux_3.2.35-2-amd64 Changed Bug submitter to 'Camale?n <noelamac at gmail.com>' from 'Camale??n <noelamac at gmail.com>' > submitter 667065 Picca Fr?d?ric-Emmanuel <picca at debian.org> Bug #667065 {Done: Sandro Tosi <morph at debian.org>} [pylint] pylint-gui failed Changed Bug submitter to 'Picca Fr?d?ric-Emmanuel <picca at debian.org>' from 'Picca Fr??d??ric-Emmanuel <picca at debian.org>' > submitter 667498 G?rkan Seng?n <sengun at phys.ethz.ch> Bug #667498 {Done: J?r?my Lal <kapouer at melix.org&gt...

I am starting a large project and still selecting what framework to use. Rather than ask brand x what is wrong with brand y, I am more interested in self confession. Why would I *not* want to use Rails (compared to Iowa and Nitro). I posted a synopsis of the project to ruby-talk but will repost it here if anyone wants it. xev