search for: pycapsul

...machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v -------------- next part -------------- >From 834077946a4a7a44bf7f0e5d19aa1d54d39022a4 Mon Sep 17 00:00:00 2001 From: Richard Jones <rjones at redhat.com> Date: Tue, 17 Aug 2010 10:31:39 +0100 Subject: [PATCH] Python: Use new PyCapsule API where supported. See: http://lists.fedoraproject.org/pipermail/devel/2010-August/141064.html --- configure.ac | 5 +++++ src/generator.ml | 13 +++++++++++++ 2 files changed, 18 insertions(+), 0 deletions(-) diff --git a/configure.ac b/configure.ac index a14dfd9..1922773 100644 ---...

G'Day, I've been looking at our minimum python version for the AD DC. We have some patches currently being proposed to help us become compatible with the modern Python3, and one aspect (PyCapsule) would be easier to do if we restricted Samba to requiring Python 2.7 as a minimum. The wrinkle comes from our good friends at Red Hat, which found itself caught with Python 2.6 on RHEL6. Naturally additional python versions can be installed from third parties, just as folks have done for RHEL5...

On Thu, Jun 16, 2011 at 01:02:21PM +0300, C?neyt Sina Koca wrote: > Since the code im trying to gave this error : > > ImportError: /usr/lib/pymodules/python2.6/libguestfsmod.so: undefined > symbol: PyCapsule_New > > I copied this libguestfsmod.so.0.0.0 > from python-libguestfs-1.9.10-1.1.x86_64.rpm package and the code works fine > now. > > When I compared the sizes of these files, libguestfsmod.so.0.0.0 file > in python-libguestfs-1.9.10-1.1.x86_64.rpm package and libguestfs.so...

...connect and -d/--domain options. 8289aa1 New APIs for guest inspection. 65e9ac4 New APIs: findfs-label and findfs-uuid ad4cff2 New API: file-architecture 3cd272f generator: No need to redefine safe_* macros. 3905cc7 Add safe_strndup call. 64d7022 Send trace output to stderr. 8340779 Python: Use new PyCapsule API where supported. 2992524 generator: Fix typo in error message for RConstOptString. 6280ac9 New API: is-lv: check if a block device is a logical volume (RHBZ#619793) 737181b Rename internal functions. 41f25ab Rearrange library code into separate files. a617f52 Rename guestfs-{actions,bindtests}...

...- ) args; - pr " return ret;\n"; - pr "}\n"; - pr "\n" + List.iter (fun cb -> print_callback cb) cbs | _ -> () ) args; @@ -3901,10 +3907,6 @@ let print_python_binding name { args; ret } = pr " PyObject *%s; /* PyCapsule pointing to struct py_aio_buffer */\n" n; pr " struct py_aio_buffer *%s_buf;\n" n - | Callback (n, _) -> - pr " struct %s_%s_data _%s_data, *%s_data = &_%s_data;\n" name n n n n - | CallbackPersist (n, _) -> - pr " str...

...pr " Py_DECREF ((PyObject *)user_data);\n"; + pr "\n"; + pr " return 0;\n"; pr "}\n"; pr "\n" | _ -> () @@ -3966,7 +3952,7 @@ let print_python_binding name { args; ret } = pr " PyObject *%s; /* PyCapsule pointing to struct py_aio_buffer */\n" n; pr " struct py_aio_buffer *%s_buf;\n" n - | Closure (_, { cbname }) -> + | Closure { cbname } -> pr " PyObject *%s_user_data;\n" cbname | Flags n -> pr " uint32_t %s_u3...

Posting now that I got something to compile (at the expense of breaking OCaml bindings), but I'm open to ideas on how to improve it. Eric Blake (2): generator: Tweak print_c_arg_list to take alternate first arg RFC: generator: Handle shared callbacks in Python generator/generator | 556 ++++++++++++++++++++++---------------------- 1 file changed, 280 insertions(+), 276 deletions(-) --

...\n"; + pr " Py_DECREF ((PyObject *)user_data);\n"; + pr "\n"; pr " return ret;\n"; pr "}\n"; pr "\n" @@ -3966,7 +3951,7 @@ let print_python_binding name { args; ret } = pr " PyObject *%s; /* PyCapsule pointing to struct py_aio_buffer */\n" n; pr " struct py_aio_buffer *%s_buf;\n" n - | Closure (_, { cbname }) -> + | Closure { cbname } -> pr " PyObject *%s_user_data;\n" cbname | Flags n -> pr " uint32_t %s_u3...

...| UInt _ | UInt32 _ -> assert false + ) cbargs; + pr " return ret;\n"; + pr "}\n"; + pr "\n" | _ -> () ) args; @@ -3996,11 +3966,8 @@ let print_python_binding name { args; ret } = pr " PyObject *%s; /* PyCapsule pointing to struct py_aio_buffer */\n" n; pr " struct py_aio_buffer *%s_buf;\n" n - | Closure (false, cls) -> - pr " struct %s_user_data _user_data;\n" name; - pr " struct %s_user_data *user_data = &_user_data;\n" name...

...\n"; + pr " Py_DECREF ((PyObject *)user_data);\n"; + pr "\n"; pr " return ret;\n"; pr "}\n"; pr "\n" @@ -3887,7 +3872,7 @@ let print_python_binding name { args; ret } = pr " PyObject *%s; /* PyCapsule pointing to struct py_aio_buffer */\n" n; pr " struct py_aio_buffer *%s_buf;\n" n - | Closure (_, { cbname }) -> + | Closure { cbname } -> pr " PyObject *%s_user_data;\n" cbname | Flags n -> pr " uint32_t %s_u3...

v1 was here: https://www.redhat.com/archives/libguestfs/2019-July/thread.html#00231 The changes address everything that Eric picked up in his review of the first two patches. I have also added two more patches (4 and 5) which respectively fix docs and change int status -> unsigned status, as discussed. Passes make, check, check-valgrind. Rich.

This implements most of what I wrote here: https://www.redhat.com/archives/libguestfs/2019-July/msg00213.html

..._ -> assert false + ) cbargs; + pr " return ret;\n"; + pr "}\n"; + pr "\n" + ) cls | _ -> () ) args; @@ -3899,10 +3917,11 @@ let print_python_binding name { args; ret } = pr " PyObject *%s; /* PyCapsule pointing to struct py_aio_buffer */\n" n; pr " struct py_aio_buffer *%s_buf;\n" n - | Callback (n, _) -> - pr " struct %s_%s_data _%s_data, *%s_data = &_%s_data;\n" name n n n n - | CallbackPersist (n, _) -> - pr " str...

I think I've addressed everything that was raised in review. Some of the highlights: - Callbacks should be freed reliably along all exit paths. - There's a simple test of closure lifetimes. - I've tried to use VALID|FREE in all the places where I'm confident that it's safe and correct to do. There may be more places. Note this is an optimization and shouldn't

As before, but this one has working Python bindings. OCaml still TBD. Rich.