search for: pxe_dn

...t; (which is the source of the issue). > > > > > > Which means the correct syntax for the pxechn.c32 command line > > > should be like what? > > > > > > The example in doc/pxechn.txt is probably incorrect then? > > > > It's a bug. Either pxe_dns() should have returned the IP or I should > > be checking that it's an IP first. > > Do you mean to say, it should work if I replace the TFTP server's IP > address with its DNS name? At this time, yes. However, I'd need to test to confirm. We had a quick discussion ye...

...won't return the IP of a string like >> "192.0.2.1" (which is the source of the issue). > > Which means the correct syntax for the pxechn.c32 command line > should be like what? > > The example in doc/pxechn.txt is probably incorrect then? It's a bug. Either pxe_dns() should have returned the IP or I should be checking that it's an IP first. -- -Gene

Digging more, loadfile("192.0.2.1::pxe.0", &file.data, &file.size), queries DNS, which sounds like it doesn't follow the same call path as a COM32 calling pxe_dns(). If the DNS won't resolve the IP, things won't load properly. pxechn.c32 sets sname in the intended packet to "192.0.2.1" which may be confusing something. More debugging needed. -- -Gene

...he issue). >> > > >> > > Which means the correct syntax for the pxechn.c32 command line >> > > should be like what? >> > > >> > > The example in doc/pxechn.txt is probably incorrect then? >> > >> > It's a bug. Either pxe_dns() should have returned the IP or I should >> > be checking that it's an IP first. >> >> Do you mean to say, it should work if I replace the TFTP server's IP >> address with its DNS name? > > At this time, yes. However, I'd need to test to confirm. >...

...m/users/mfleming/syslinux.git elflink Andre Ericson (1): ldlinux: fixes bug that happens when using fullpath for a COM32 module Matt Fleming (10): module: Actually use last component of DT_NEEDED pathname Delete all references to __com32.cs_bounce pxechn: Fix merge botch s/pxe_dns/pxe_dns_resolv/ com32: Add missing DHCP pack/unpack files elflink: Fix compiler warning fs: Add .copy_super to struct fs_ops com32: Per-object file LDFLAGS Revert "pxe: resolve names via DNS from protected-mode code" ldlinux: Don't lfree() 'ker...

...;< 8) | part; + part = 0; + p++; + } + p--; + + *res = htonl(ip); + return *p == '\0'; +} + + +/* + * Similar implementation as core/fs/pxe/dnsresolv.c + * + * Allow ipv4 host names to be used. Do not support + * DNS names or ipv6. + * + */ + __export uint32_t pxe_dns(const char *name) { + + uint32_t ip; + /* * Return failure on an empty input... this can happen during * some types of URL parsing, and this is the easiest place to @@ -45,6 +89,11 @@ __export uint32_t pxe_dns(const char *name) if (!name || !*name) return 0; +...

...; wrote: > On Sat, Jul 13, 2013 at 10:34 AM, Gene Cumm <gene.cumm at gmail.com> wrote: >> Digging more, loadfile("192.0.2.1::pxe.0", &file.data, &file.size), >> queries DNS, which sounds like it doesn't follow the same call path as >> a COM32 calling pxe_dns(). If the DNS won't resolve the IP, things >> won't load properly. pxechn.c32 sets sname in the intended packet to >> "192.0.2.1" which may be confusing something. >> >> More debugging needed. >> >> -- >> -Gene > > core/legacynet/...

...| 15 ++--- com32/lib/sys/xserial_write.c | 8 +-- com32/lib/syslinux/cleanup.c | 12 ++-- com32/lib/syslinux/features.c | 51 -------------- com32/lib/syslinux/ipappend.c | 20 ++---- com32/lib/syslinux/keyboard.c | 14 +--- com32/lib/syslinux/pxe_dns.c | 14 +--- com32/lib/syslinux/pxe_get_cached.c | 11 +--- com32/lib/syslinux/pxe_get_nic.c | 12 +--- com32/lib/syslinux/run_command.c | 9 +-- com32/lib/syslinux/run_default.c | 10 +-- com32/lib/syslinux/runimage.c | 19 ++--- com32/lib/syslinux/s...

pxelinux.0 since Syslinux-5.10 won't return the IP of a string like "192.0.2.1" (which is the source of the issue). -- -Gene

...> >> "192.0.2.1" (which is the source of the issue). > > > > Which means the correct syntax for the pxechn.c32 command line > > should be like what? > > > > The example in doc/pxechn.txt is probably incorrect then? > > It's a bug. Either pxe_dns() should have returned the IP or I should > be checking that it's an IP first. Do you mean to say, it should work if I replace the TFTP server's IP address with its DNS name? -- Victor Sudakov, VAS4-RIPE, VAS47-RIPN sip:sudakov at sibptus.tomsk.ru

On Sat, Jul 13, 2013 at 10:34 AM, Gene Cumm <gene.cumm at gmail.com> wrote: > Digging more, loadfile("192.0.2.1::pxe.0", &file.data, &file.size), > queries DNS, which sounds like it doesn't follow the same call path as > a COM32 calling pxe_dns(). If the DNS won't resolve the IP, things > won't load properly. pxechn.c32 sets sname in the intended packet to > "192.0.2.1" which may be confusing something. > > More debugging needed. > > -- > -Gene core/legacynet/dns_resolv.c is quite different and d...

...| 15 ++--- com32/lib/sys/xserial_write.c | 8 +-- com32/lib/syslinux/cleanup.c | 12 ++-- com32/lib/syslinux/features.c | 51 -------------- com32/lib/syslinux/ipappend.c | 20 ++---- com32/lib/syslinux/keyboard.c | 14 +--- com32/lib/syslinux/pxe_dns.c | 14 +--- com32/lib/syslinux/pxe_get_cached.c | 11 +--- com32/lib/syslinux/pxe_get_nic.c | 12 +--- com32/lib/syslinux/run_command.c | 9 +-- com32/lib/syslinux/run_default.c | 10 +-- com32/lib/syslinux/runimage.c | 19 ++--- com32/lib/syslinux/s...

...itew.o pci/writel.o sys/vesacon_write.o sys/vesaserial_write.o sys/vesa/initvesa.o sys/vesa/drawtxt.o sys/vesa/background.o sys/vesa/alphatbl.o sys/vesa/screencpy.o sys/vesa/fmtpixel.o syslinux/reboot.o syslinux/keyboard.o syslinux/version.o syslinux/pxe_get_cached.o syslinux/pxe_get_nic.o syslinux/pxe_dns.o syslinux/video/fontquery.o syslinux/video/reportmode.o syslinux/addlist.o syslinux/freelist.o syslinux/memmap.o syslinux/movebits.o syslinux/shuffle.o syslinux/shuffle_pm.o syslinux/shuffle_rm.o syslinux/zonelist.o syslinux/dump_mmap.o syslinux/dump_movelist.o syslinux/run_default.o syslinux/run...

On Tue, 25 Jun, at 01:52:00PM, Helmut Hullen wrote: > Thanks - now it crashes later ... What crash are you seeing? > I don't have the ia64 files which are needed for a complete binary. But > maybe that's only my special problem. You shouldn't need ia64 files to build ia32 and x86-64 versions of gnu-efi or Syslinux. -- Matt Fleming, Intel Open Source Technology Center

...dex 64, which is out of bounds. Otherwise condition 'j>=64' is redundant. Probably a false positive. (What is the reason of macro "__unlikely()" which is defined as "(!!(x))" ?) ----------------------------------------------------------------- [com32/lib/syslinux/pxe_dns.c:56]: (error) Uninitialized variable: q False positive. cppcheck seems to not understand the use of the return value of sscanf(). ----------------------------------------------------------------- [com32/libupload/upload_tftp.c:138]: (error) Uninitialized struct member: tftp.srv_ip Looks lik...

> On Jul 10, 2015 5:29 PM, "poma via Syslinux" <syslinux at zytor.com> wrote: > > > The same as with the ISOLINUX, stable and git. > > Only this time has nothing to do with the menu. > > 1) EXTLINUX is no longer a discrete variant. The installer extlinux now > installs SYSLINUX. > 2) William Kensington already saw a similar behavior wherein an

...2 diff --git a/com32/lib/Makefile b/com32/lib/Makefile index 5d41d7d..10fb4de 100644 --- a/com32/lib/Makefile +++ b/com32/lib/Makefile @@ -50,8 +50,6 @@ LIBSYSLINUX_OBJS = \ syslinux/ipappend.o syslinux/dsinfo.o syslinux/version.o \ syslinux/pxe_get_cached.o syslinux/pxe_get_nic.o \ syslinux/pxe_dns.o \ - syslinux/adv.o syslinux/advwrite.o syslinux/getadv.o \ - syslinux/setadv.o \ syslinux/video/fontquery.o syslinux/video/forcetext.o \ syslinux/video/reportmode.o diff --git a/com32/lib/syslinux/adv.c b/com32/lib/syslinux/adv.c deleted file mode 100644 index be38e89..0000000...

From: Matt Fleming <matt.fleming at intel.com> The following patch series is available at, git://git.zytor.com/users/mfleming/syslinux.git elflink All patches are against the 'elflink' branch. This series fixes a few serious bugs and some behavioural incompatibilities with the 4.x series. Matt Fleming (19): ldlinux: Initialise 'p' before using it. ldlinux: Parse

From: Matt Fleming <matt.fleming at linux.intel.com> This series fixes some bugs and switches the elflink branch to be entirely ELF modules. It applies on top of, http://syslinux.zytor.com/archives/2011-April/016369.html The deletions in the diff stat below are mainly from deleting com32/elflink/modules (finally!). Now there should be no duplicate code because we don't need COM32 and