search for: pxe_devicehandl

On Thu, Jun 25, 2015 at 7:28 PM, Gene Cumm <gene.cumm at gmail.com> wrote: > On Thu, Jun 25, 2015 at 11:54 AM, Patrick Masotta <masottaus at yahoo.com> wrote: > >> Yes I know what you mean; >> "I think" the handle of the running image (our code) has a "path" telling us where >> was laded from. That would solve this thing. > > I just

...a) a missing return; on an error condition at efi/pxe.c\net_parse_dhcp() > b) you close a protocol before creating its child at efi/main.c\efi_create_binding() Rewrote the commit messages and it's in at commit ID 5186539 > 2.2) I think "image_DeviceHandle" instead of "pxe_DeviceHandle" produces a code easier to follow; > specially when we end up using that handle to create a TCP4 or UDP4 child... Not all handles are devices but all usable devices have handles. The image_handle is a type EFI_LOADED_IMAGE_PROTOCOL, not a device. pxe_handle could perhaps be renamed as ni...

...ple of issues check them corrected at https://github.com/ppatpat/syslinux/ a) a missing return; on an error condition at efi/pxe.c\net_parse_dhcp() b) you close a protocol before creating its child at efi/main.c\efi_create_binding() 2.2) I think "image_DeviceHandle" instead of "pxe_DeviceHandle" produces a code easier to follow; specially when we end up using that handle to create a TCP4 or UDP4 child... Best, Patrick

...s the handle of the device (NIC) that loaded syslinux plus IP stack (as you said) but also all the attached Service Binding Protocols, PXE Protocol, and some more. All of them sharing the same device handle. >>> > 2.2) > I think "image_DeviceHandle" instead of > "pxe_DeviceHandle" produces a code easier to follow; > specially when we end up using > that handle to create a TCP4 or UDP4 child... Not all handles are devices but all usable devices have handles.? The image_handle is a type EFI_LOADED_IMAGE_PROTOCOL, not a device. pxe_handle could perhaps be rena...