search for: pwm1_max

https://bugs.freedesktop.org/show_bug.cgi?id=66022 Priority: medium Bug ID: 66022 Assignee: nouveau at lists.freedesktop.org Summary: pwm1[_enable] faults after hibernate/restore related to automatic (or otherwise) fan management QA Contact: xorg-team at lists.x.org Severity: normal Classification: Unclassified

https://bugs.freedesktop.org/show_bug.cgi?id=80507 Priority: medium Bug ID: 80507 Assignee: nouveau at lists.freedesktop.org Summary: Cannot set pwm1 above 80 on GeForce 9600 GT, 10de:0622 QA Contact: xorg-team at lists.x.org Severity: normal Classification: Unclassified OS: All Reporter: awilliam at

...tribute groups in this > driver meet your needs ? I could imagine that pwm1_target_temp > for the upper temperature limit and pwm1_temp_tolerance for the difference > between upper and lower limit might do. Then there are other attributes > such as pxm1_start, pwm1_floor, pwm1_step, and pwm1_max which you > could use to control pwm values further is that is possible with the > driver. Using pwm1_target_temp and pwm1_temp_tolerance seems a like nice idea, yes. Some of the other attributes are already used and I'm not certain how much I should change at this point. > An altern...

...t device_attribute *a, > return count; > } > > -static SENSOR_DEVICE_ATTR(pwm1_min, S_IRUGO | S_IWUSR, > +static SENSOR_DEVICE_ATTR(pwm1_min, 0644, > nouveau_hwmon_get_pwm1_min, > nouveau_hwmon_set_pwm1_min, 0); > > @@ -295,7 +295,7 @@ nouveau_hwmon_set_pwm1_max(struct device *d, struct device_attribute *a, > return count; > } > > -static SENSOR_DEVICE_ATTR(pwm1_max, S_IRUGO | S_IWUSR, > +static SENSOR_DEVICE_ATTR(pwm1_max, 0644, > nouveau_hwmon_get_pwm1_max, > nouveau_hwmon_set_pwm1_max, 0); > >

Hello guys, For a patch to this nouveau bug [1] I'm trying to implement the sysfs interface for two properties (linear_min and linear_max) nouveau uses internally to decide when to raise the fan speed. The initial idea was to have them as custom sysfs attributes, but I was advised to try to fit them into the hwmon sysfs interface. And this is when I hit a little roadblock. If my

...0); @@ -313,7 +313,7 @@ nouveau_hwmon_set_pwm1_min(struct device return count; } -static SENSOR_DEVICE_ATTR(pwm1_min, S_IRUGO | S_IWUSR, +static SENSOR_DEVICE_ATTR(pwm1_min, 0644, nouveau_hwmon_get_pwm1_min, nouveau_hwmon_set_pwm1_min, 0); @@ -353,7 +353,7 @@ nouveau_hwmon_set_pwm1_max(struct device return count; } -static SENSOR_DEVICE_ATTR(pwm1_max, S_IRUGO | S_IWUSR, +static SENSOR_DEVICE_ATTR(pwm1_max, 0644, nouveau_hwmon_get_pwm1_max, nouveau_hwmon_set_pwm1_max, 0);

...au_hwmon_set_pwm1_min(struct device *d, struct device_attribute *a, return count; } -static SENSOR_DEVICE_ATTR(pwm1_min, S_IRUGO | S_IWUSR, +static SENSOR_DEVICE_ATTR(pwm1_min, 0644, nouveau_hwmon_get_pwm1_min, nouveau_hwmon_set_pwm1_min, 0); @@ -295,7 +295,7 @@ nouveau_hwmon_set_pwm1_max(struct device *d, struct device_attribute *a, return count; } -static SENSOR_DEVICE_ATTR(pwm1_max, S_IRUGO | S_IWUSR, +static SENSOR_DEVICE_ATTR(pwm1_max, 0644, nouveau_hwmon_get_pwm1_max, nouveau_hwmon_set_pwm1_max, 0); -- 2.1.4

...n this >> driver meet your needs ? I could imagine that pwm1_target_temp >> for the upper temperature limit and pwm1_temp_tolerance for the difference >> between upper and lower limit might do. Then there are other attributes >> such as pxm1_start, pwm1_floor, pwm1_step, and pwm1_max which you >> could use to control pwm values further is that is possible with the >> driver. > > Using pwm1_target_temp and pwm1_temp_tolerance seems a like nice idea, > yes. Some of the other attributes are already used and I'm not certain > how much I should change at...

...ment.cgi?id=102242&action=edit Dmesg Since updating to kernel 3.15, the pwm fan speed of my 550 Ti card is too high (above 35% in all situations) when compared with the proprietary NVIDIA driver (that hovers around 30%). The only way to reduce it to silence once again is to manually change the pwm1_max value under sysfs to 30 (by default it's 100). -- You are receiving this mail because: You are the assignee for the bug. -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/nouveau/attachments/20140704/133a4091/attachment-0...

...the attributes or atribute groups in this driver meet your needs ? I could imagine that pwm1_target_temp for the upper temperature limit and pwm1_temp_tolerance for the difference between upper and lower limit might do. Then there are other attributes such as pxm1_start, pwm1_floor, pwm1_step, and pwm1_max which you could use to control pwm values further is that is possible with the driver. An alternative would be to use two sets of pwm_auto_point attributes, where the first set specifies the start pwm limit and the second specifies the upper temperature and limit. So you would have something like...

...au_hwmon_set_pwm1_min(struct device *d, struct device_attribute *a, return count; } -static SENSOR_DEVICE_ATTR(pwm1_min, S_IRUGO | S_IWUSR, +static SENSOR_DEVICE_ATTR(pwm1_min, 0644, nouveau_hwmon_get_pwm1_min, nouveau_hwmon_set_pwm1_min, 0); @@ -511,7 +511,7 @@ nouveau_hwmon_set_pwm1_max(struct device *d, struct device_attribute *a, return count; } -static SENSOR_DEVICE_ATTR(pwm1_max, S_IRUGO | S_IWUSR, +static SENSOR_DEVICE_ATTR(pwm1_max, 0644, nouveau_hwmon_get_pwm1_max, nouveau_hwmon_set_pwm1_max, 0); @@ -531,7 +531,7 @@ nouveau_hwmon_get_in0_input(struct devi...

...IRUGO | S_IWUSR, amdgpu_hwmon_get_pwm1, amdgpu_hwmon_set_pwm1, 0); -static SENSOR_DEVICE_ATTR(pwm1_enable, S_IRUGO | S_IWUSR, amdgpu_hwmon_get_pwm1_enable, amdgpu_hwmon_set_pwm1_enable, 0); -static SENSOR_DEVICE_ATTR(pwm1_min, S_IRUGO, amdgpu_hwmon_get_pwm1_min, NULL, 0); -static SENSOR_DEVICE_ATTR(pwm1_max, S_IRUGO, amdgpu_hwmon_get_pwm1_max, NULL, 0); -static SENSOR_DEVICE_ATTR(fan1_input, S_IRUGO, amdgpu_hwmon_get_fan1_input, NULL, 0); -static SENSOR_DEVICE_ATTR(in0_input, S_IRUGO, amdgpu_hwmon_show_vddgfx, NULL, 0); -static SENSOR_DEVICE_ATTR(in0_label, S_IRUGO, amdgpu_hwmon_show_vddgfx_label, NUL...

..., amdgpu_hwmon_get_pwm1, amdgpu_hwmon_set_pwm1, 0); > -static SENSOR_DEVICE_ATTR(pwm1_enable, S_IRUGO | S_IWUSR, amdgpu_hwmon_get_pwm1_enable, amdgpu_hwmon_set_pwm1_enable, 0); > -static SENSOR_DEVICE_ATTR(pwm1_min, S_IRUGO, amdgpu_hwmon_get_pwm1_min, NULL, 0); > -static SENSOR_DEVICE_ATTR(pwm1_max, S_IRUGO, amdgpu_hwmon_get_pwm1_max, NULL, 0); > -static SENSOR_DEVICE_ATTR(fan1_input, S_IRUGO, amdgpu_hwmon_get_fan1_input, NULL, 0); > -static SENSOR_DEVICE_ATTR(in0_input, S_IRUGO, amdgpu_hwmon_show_vddgfx, NULL, 0); > -static SENSOR_DEVICE_ATTR(in0_label, S_IRUGO, amdgpu_hwmon_show_vd...

This v8 fixes removes dummy functions which only had a return and moves the code into the switch statements. Versions: v1 -> v2: * Keep temp attrs as read only v2 -> v3: * Code fix-ups: struct and string as const and add return within switch due to fallthrough * Add Signed-off-by to all commits v3 -> v4: * Rever const to struct attribute. Kbuild

This v7 fixes removes dummy functions which only had a return and moves the code into the switch statements. Versions: v1 -> v2: * Keep temp attrs as read only v2 -> v3: * Code fix-ups: struct and string as const and add return within switch due to fallthrough * Add Signed-off-by to all commits v3 -> v4: * Rever const to struct attribute. Kbuild

This v5 drops a check for attr_set. Versions: v1 -> v2: * Keep temp attrs as read only v2 -> v3: * Code fix-ups: struct and string as const and add return within switch due to fallthrough * Add Signed-off-by to all commits v3 -> v4: * Rever const to struct attribute. Kbuild complains. v4 -> v5: * Drops a check for attr_set in

...mail.com Hardware: Other Status: NEW Version: unspecified Component: Driver/nouveau Product: xorg When I have done the following: echo 1 > /sys/class/hwmon/hwmon0/pwm1_enable echo 30 > /sys/class/hwmon/hwmon0/pwm1 pwm1=30 pwm1_enable=1 pwm1_max=100 pwm1_min=0 temp1_auto_point1_pwm=100 temp1_auto_point1_temp=90000 temp1_auto_point1_temp_hyst=3000 temp1_crit=115000 temp1_crit_hyst=2000 temp1_emergency=135000 temp1_emergency_hyst=5000 temp1_input=41000 temp1_max=95000 temp1_max_hyst=3000 update_rate=1000 and then do hibernate/restore, I get...

This v6 fixes some comments pointed out by Martin Peres. Versions: v1 -> v2: * Keep temp attrs as read only v2 -> v3: * Code fix-ups: struct and string as const and add return within switch due to fallthrough * Add Signed-off-by to all commits v3 -> v4: * Rever const to struct attribute. Kbuild complains. v4 -> v5: * Drops a check for

Kbuild sent me an e-mail due to a fixup I introduced in v3. It complains due to an incompatible pointer type and it doesn't build. This version reverts it. Versions: v1 -> v2: * Keep temp attrs as read only v2 -> v3: * Code fix-ups: struct and string as const and add return within switch due to fallthrough * Add Signed-off-by to all commits v3 -> v4:

Hi, this is version v3 with some fix-ups: Versions: v1 -> v2: * Keep temp attrs as read only v2 -> v3: * Code fix-ups: struct and string as const and add return within switch due to fallthrough * Add Signed-off-by to all commits This patchseries replaces the deprecated hwmon_device_register function with the new one hwmon_device_register_with_info. It also does some cleanup. Here