Displaying 2 results from an estimated 2 matches for "put_module".
Did you mean:
cur_module
2012 Mar 13
1
[Bug 777] New: Suspect bug in __do_replace()
..._table() may return NULL when allocation of memory was not
successful by xt_replace_table->xt_jumpstack_alloc() (in my case I suspect
there were no free memory when it's happened):
...
oldinfo = xt_replace_table(t, num_counters, newinfo, &ret);
if (!oldinfo)
goto put_module;
The full bactrace is
WARNING: at /kernel/mm/vmalloc.c:107 vmap_page_range_noflush+0x120/0x1b4()
<4>[18835.587677] [<c00409dc>] (unwind_backtrace+0x0/0x164) from [<c0082a34>]
(warn_slowpath_common+0x4c/0x64)
<4>[18835.587707] [<c0082a34>] (warn_slowpath_common+0x4c/0...
2013 Jun 06
0
[Bug 777] Suspect bug in __do_replace()
...ce.com
Resolution| |INVALID
--- Comment #2 from Phil Oester <netfilter at linuxace.com> 2013-06-06 17:11:05 CEST ---
Unclear why you believe this is a bug. If the memory allocation in
xt_replace_table fails, it returns NULL. At this point, the "goto put_module"
is correct - we need to cleanup after ourselves. Your suggestion to "goto out"
is not beneficial.
Further, the backtrace you provided is because the memory system could not
allocate memory. This has nothing whatsoever to do with netfilter, and making
changes in netfilter will not...