search for: put_char

Hey Rusty, This is the way I did the split; patches 1..7 are preparation for multiple ports. Patch 8 adds multiport support. It's the big one since we have to put the header in and retain support for multiple consoles and console resizing. Patch 9 adds port hotplug Patch 10 adds sysfs entries and 12 adds debugfs. Patches 13, 14 and 15 add throttling, caching and unplug features.

Hey Rusty, This is the way I did the split; patches 1..7 are preparation for multiple ports. Patch 8 adds multiport support. It's the big one since we have to put the header in and retain support for multiple consoles and console resizing. Patch 9 adds port hotplug Patch 10 adds sysfs entries and 12 adds debugfs. Patches 13, 14 and 15 add throttling, caching and unplug features.

Hey Rusty, In this version: - Assume only one inbuf; no input buffering for ports - Remove the START/END delimiters for outgoing buffers - Remove the header that was sent along with each buffer - Remove unused buffers in the vqs at port remove time - Send a guest port open message to the host when a console port is attached - Remove cached buffers when ports are closed / disconnected - Send

Hey Rusty, In this version: - Assume only one inbuf; no input buffering for ports - Remove the START/END delimiters for outgoing buffers - Remove the header that was sent along with each buffer - Remove unused buffers in the vqs at port remove time - Send a guest port open message to the host when a console port is attached - Remove cached buffers when ports are closed / disconnected - Send

Christian tested the patch on s390 and found that the output was very slow. He tracked it down to put_chars never getting init'ed to the final value. Signed-off-by: Amit Shah <amit.shah at redhat.com> --- drivers/char/virtio_console.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index 37513e8..59...

Christian tested the patch on s390 and found that the output was very slow. He tracked it down to put_chars never getting init'ed to the final value. Signed-off-by: Amit Shah <amit.shah at redhat.com> --- drivers/char/virtio_console.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index 37513e8..59...

Hey Rusty, This is a respin of my patches on top of the series you posted. I've taken the liberty to modify your patches for style consistency and comments where needed, keeping the authorship info intact. I've had to update a few of your patches for functional changes, I've changed the authorship info on those patches. The (only) major functional change is to have a list for ports

Hey Rusty, This is a respin of my patches on top of the series you posted. I've taken the liberty to modify your patches for style consistency and comments where needed, keeping the authorship info intact. I've had to update a few of your patches for functional changes, I've changed the authorship info on those patches. The (only) major functional change is to have a list for ports

From: Omar Sandoval <osandov at fb.com> put_chars() stuffs the buffer it gets into an sg, but that buffer may be on the stack. This breaks with CONFIG_VMAP_STACK=y (for me, it manifested as printks getting turned into NUL bytes). Signed-off-by: Omar Sandoval <osandov at fb.com> --- Patch based on v4.10-rc6. drivers/char/virtio_console.c...

From: Omar Sandoval <osandov at fb.com> put_chars() stuffs the buffer it gets into an sg, but that buffer may be on the stack. This breaks with CONFIG_VMAP_STACK=y (for me, it manifested as printks getting turned into NUL bytes). Signed-off-by: Omar Sandoval <osandov at fb.com> --- Patch based on v4.10-rc6. drivers/char/virtio_console.c...

Hey Rusty, This series adds support for generic ports with each port getting two vqs: one for input and one for output. The host notifies us via the config space of the max. number of ports that can be added for a particular device. As a result of that change, the buffer management for find_readbufs and send_bufs is moved to the vqs. Only one outbuf per port is used so we bide away some time in

Hey Rusty, This series adds support for generic ports with each port getting two vqs: one for input and one for output. The host notifies us via the config space of the max. number of ports that can be added for a particular device. As a result of that change, the buffer management for find_readbufs and send_bufs is moved to the vqs. Only one outbuf per port is used so we bide away some time in

...p->ops->get_chars(hp->vtermno, &ch, 1); + n = cons_ops[last_hvc]->get_chars(vtermnos[last_hvc], &ch, 1); if (n == 0) return NO_POLL_CHAR; @@ -781,12 +779,10 @@ static int hvc_poll_get_char(struct tty_driver *driver, int line) static void hvc_poll_put_char(struct tty_driver *driver, int line, char ch) { - struct tty_struct *tty = driver->ttys[0]; - struct hvc_struct *hp = tty->driver_data; int n; do { - n = hp->ops->put_chars(hp->vtermno, &ch, 1); + n = cons_ops[last_hvc]-&g...

This patch set if my first attempt to make virtio_console usable on s390. To do so, I had to change hvc_console, because s390 has no request_irq and no free_irq. I want to get feedback from the main users of hvc_console before I proceed. The basic idea of this patch set is to remove the calls to request_irq and free_irq and replace them with backend specific callbacks. Please see the

This patch set if my first attempt to make virtio_console usable on s390. To do so, I had to change hvc_console, because s390 has no request_irq and no free_irq. I want to get feedback from the main users of hvc_console before I proceed. The basic idea of this patch set is to remove the calls to request_irq and free_irq and replace them with backend specific callbacks. Please see the

Hello all, Here is a new iteration of the patch series that implements a transport for guest and host communications. I've tested for compatibility (old qemu & new kernel, new qemu & old kernel, new qemu & new kernel) and it all works fine*. There are a few items on my todo list but this works well. New since last send: - live migration support** - write path in the guest

Hello all, Here is a new iteration of the patch series that implements a transport for guest and host communications. I've tested for compatibility (old qemu & new kernel, new qemu & old kernel, new qemu & new kernel) and it all works fine*. There are a few items on my todo list but this works well. New since last send: - live migration support** - write path in the guest

Hello all, Here is a new iteration of the patch series that implements a transport for guest and host communications. I've tested for compatibility (old qemu & new kernel, new qemu & old kernel, new qemu & new kernel) and it all works fine. To maintain backward compatibility, the first port to be spawned (port at id 0) is to be a console port, to be bound to hvc. This keeps new

Hello all, Here is a new iteration of the patch series that implements a transport for guest and host communications. I've tested for compatibility (old qemu & new kernel, new qemu & old kernel, new qemu & new kernel) and it all works fine. To maintain backward compatibility, the first port to be spawned (port at id 0) is to be a console port, to be bound to hvc. This keeps new

Hello, This is the patch that I have for adding support for multiple ports to virtio_console. It's pretty stable in my testing so far and the memory corruption that I had earlier has been resolved in linux-next so I'm proposing this for inclusion. This currently uses device major number 60 from the experimental range; Alan could you please reserve a new major number for virtio_console?