search for: pubkey_prepare

...e incoming message and will store it into a variable called 'partial'. Then, in 6.4p1 and later, 'input_userauth_failure' will do the following: if (partial != 0) { logit("Authenticated with partial success."); /* reset state */ pubkey_cleanup(authctxt); pubkey_prepare(authctxt); } debug("Authentications that can continue: %s", authlist); Before 6.4p1 the 'pubkey_cleanup' and 'pubkey_prepare' invocation were missing. The undesirable behavior is introduced by 'pubkey_prepare'. When invoked here, it will modify the OpenSSH aut...

https://bugzilla.mindrot.org/show_bug.cgi?id=2642 Bug ID: 2642 Summary: [sshconnect2] publickey authentication only properly works if used first: pubkey_prepare doesn't work after pubkey_cleanup Product: Portable OpenSSH Version: 7.3p1 Hardware: amd64 OS: Linux Status: NEW Severity: normal Priority: P5 Component: ssh Assignee: unassign...

...was authenticated through its ssh agent keys even though it was requested not to use them (IdentitiesOnly option). Unsetting SSH_AUTH prior to calling ssh would make it to prove it. Since i had downloaded and recompiled the 6.2p1 code, i looked at the source code and found the issue was likely in pubkey_prepare inside sshconnect2.c in which identities_only option is tested a bit too late. I provided a unified diff as a suggested patch to this issue. Detail about the problem/patch for pubkey_prepare function: - at one point, pubkey_prepare checks if an agent is available and loops through agent provide...

A co-worker argues we can login using only password to a "ssh-key restricted host (PasswordAuthentication no)", without being asked by any passphase; just by putting a key (no need to be the private key) on another password-based host. It that true? I do not think so. I would name that as an "important OpenSSH daemon security bug". That is because I think it is not true.

...no such identity: /home/des/.ssh/id_dsa: No such file or directory no such identity: /home/des/.ssh/id_ecdsa: No such file or directory load_identity_file() in sshconnect2.c prints this message if its userprovided argument is non-zero. The value comes from a struct identity which is populated in pubkey_prepare() in the same file; userprovided is set to 1 if the keyfile name comes from the client option structure. However, in this case, options.identity_keys is the hardcoded default; I wouldn't say that really qualifies as "user provided". The attached patch adds a flag to the option struc...

...rot.org Reporter: cjwatson at debian.org Created attachment 2256 --> https://bugzilla.mindrot.org/attachment.cgi?id=2256&action=edit Fix size passed to bzero GCC 4.8 warns (for Debian package, so line numbers may be off from mainline, sorry): ../sshconnect2.c: In function 'pubkey_prepare': ../sshconnect2.c:1527:20: warning: argument to 'sizeof' in 'bzero' call is the same expression as the destination; did you mean to dereference it? [-Wsizeof-pointer-memaccess] bzero(id, sizeof(id)); It's correct; this code only zeroes the first sizeof(pointer) bytes o...

Hi, I believe it would make more sense if, when specifying a key with -i, that key (or keys) should be tried prior to the keys in the agent. Otherwise, if I have many keys in my agent, the server will kick me out. I can see no situation where one would like to use agent keys instead of the ones explicitly stated. Do you agree? The workaround is of course to set the IdentitiesOnly option. Best

...ame host (hostA) to the same remote host (hostB) For both versions you can see the "SSH2_MSG_SERVICE_ACCEPT received" debug message from ssh_userauth2(), but only the 3.8p1 version will show the debug message "debug2("key: %s (%p)", id->filename, id->key)" from pubkey_prepare(). I've tried this both with an identyFile directive (as shown in example) as well as just having the id_dsa file being discovered from $HOME/.ssh/id_dsa and there's no difference, it still only works with the 3.8p1 client but not the 4.5p1 client. I've tried it against both a 4.5p1 s...

...2. other agent keys - * 3. keys that are only listed in the config file + * 1. certificates listed in the config file + * 2. other input certificates + * 3. agent keys that are found in the config file + * 4. other agent keys + * 5. keys that are only listed in the config file */ static void pubkey_prepare(Authctxt *authctxt) @@ -1245,6 +1275,17 @@ pubkey_prepare(Authctxt *authctxt) free(id); } } + /* list of certificates specified by user */ + for (i = 0; i < options.num_certificate_files; i++) { + key = options.certificates[i]; + if (!key_is_cert(key)) + continue; + id = xcalloc(1,...

...2.c:key_sig_algorithm will return a copy of the name of an SSH key's type. For everything except RSA keys, it will filter the key's type against options.pubkey_key_types, but that doesn't make much sense, because the key has already been verified to be a permitted type by sshconnect2.c:pubkey_prepare. (I haven't gone into the history, but I'm guessing that this code used to filter against ssh->kex->server_sig_algs instead.) In other words, the private key type has already been checked against the local security policy before key_sig_algorithm is called, so key_sig_algorithm shou...

...bin/ssh/sshconnect2.c,v retrieving revision 1.178 diff -u -N -p sshconnect2.c --- sshconnect2.c 11 Jan 2010 04:46:45 -0000 1.178 +++ sshconnect2.c 11 Jan 2010 23:12:38 -0000 @@ -244,7 +244,7 @@ void userauth(Authctxt *, char *); static int sign_and_send_pubkey(Authctxt *, Identity *); static void pubkey_prepare(Authctxt *); static void pubkey_cleanup(Authctxt *); -static Key *load_identity_file(char *); +static Key *load_identity_file(char *, AuthenticationConnection *); static Authmethod *authmethod_get(char *authlist); static Authmethod *authmethod_lookup(const char *name); @@ -1102,7 +1102,7 @@ in...

http://bugzilla.mindrot.org/show_bug.cgi?id=684 Summary: ssh cannot access keys stored in agent Product: Portable OpenSSH Version: 3.7.1p1 Platform: UltraSparc OS/Version: Solaris Status: NEW Severity: major Priority: P2 Component: ssh AssignedTo: openssh-bugs at mindrot.org ReportedBy:

https://bugzilla.mindrot.org/show_bug.cgi?id=2594 Bug ID: 2594 Summary: Tracking bug for OpenSSH 7.4 release Product: Portable OpenSSH Version: -current Hardware: Other OS: All Status: NEW Keywords: meta Severity: normal Priority: P1 Component: Miscellaneous

...11][12], but it seems no one has yet discussed the approach we had in mind. If a usual user calls ssh like ssh -i <mykey> ... And gets: "Too many authentication failures" He'd not even think about <mykey> not even being tried. The problem is that the current order in pubkey_prepare will order those directly specified keys too late. * try keys in the following order: * 1. certificates listed in the config file * 2. other input certificates * 3. agent keys that are found in the config file * 4. other agent keys * 5. keys that are only listed in the co...

...RSA-CERT > SHA256:AeEypypDIQ7DXiFtXfpEGmNZHHSpDoD9Hppg+YzU+O0 agent > debug1: Will attempt key: /home/me/.ssh/id_dsa > debug1: Will attempt key: /home/me/.ssh/id_ecdsa > debug1: Will attempt key: /home/me/.ssh/id_ed25519 > debug1: Will attempt key: /home/me/.ssh/id_xmss > debug2: pubkey_prepare: done > debug3: send packet: type 5 > debug3: receive packet: type 7 > debug1: SSH2_MSG_EXT_INFO received > debug1: kex_input_ext_info: server-sig-algs=<rsa-sha2-256,rsa-sha2-512> > debug3: receive packet: type 6 > debug2: service_accept: ssh-userauth > debug1: SSH2_MSG_S...

...1 debug3: send packet: type 21 debug2: set_newkeys: mode 1 debug1: rekey after 134217728 blocks debug1: SSH2_MSG_NEWKEYS sent debug1: expecting SSH2_MSG_NEWKEYS debug3: receive packet: type 21 debug2: set_newkeys: mode 0 debug1: rekey after 134217728 blocks debug1: SSH2_MSG_NEWKEYS received debug1: pubkey_prepare: ssh_get_authentication_socket: No such file or directory debug2: key: /home/mrkiko/.ssh/id_rsa ((nil)) debug2: key: /home/mrkiko/.ssh/id_dsa ((nil)) debug2: key: /home/mrkiko/.ssh/id_ecdsa ((nil)) debug2: key: /home/mrkiko/.ssh/id_ed25519 ((nil)) debug3: send packet: type 5 debug3: receive packet:...

In sshconnect.c there are two global variables for server_version_string client_version_string. These are used just in a few functions and can easily be passed as parameters. Also, there is a strange construct, where their memory is allocated to the global pointers, then copies of these pointers are assigned to the kex structure. The kex_free finally frees them via cleanup of the kex

Hi, OpenSSH 8.0p1 is almost ready for release, so we would appreciate testing on as many platforms and systems as possible. Snapshot releases for portable OpenSSH are available from http://www.mindrot.org/openssh_snap/ The OpenBSD version is available in CVS HEAD: http://www.openbsd.org/anoncvs.html Portable OpenSSH is also available via git using the instructions at

...hctxt *); int userauth_pubkey(Authctxt *); int userauth_passwd(Authctxt *); int userauth_kbdint(Authctxt *); @@ -224,6 +227,7 @@ void userauth(Authctxt *, char *); static int sign_and_send_pubkey(Authctxt *, Identity *); +static int sign_and_send_certkey(Authctxt *, Identity *); static void pubkey_prepare(Authctxt *); static void pubkey_cleanup(Authctxt *); static Key *load_identity_file(char *); @@ -243,6 +247,10 @@ userauth_hostbased, &options.hostbased_authentication, NULL}, + {"certkey", + userauth_certkey, + &options.certkey_authentication, + NULL}, {"publ...