search for: ptrtraits

around line 45 a bitmask is computed as: PointerBitMask = ~(uintptr_t)(((intptr_t)1 << PtrTraits::NumLowBitsAvailable)-1), my question is why is the shift performed on intptr_t? Wouldn't the following be ok? PointerBitMask = ~(((uintptr_t)1 << PtrTraits::NumLowBitsAvailable)-1), Thanks in advance, Maurizio

On Oct 8, 2009, at 10:50 AM, Maurizio Vitale wrote: > around line 45 a bitmask is computed as: > > PointerBitMask = > ~(uintptr_t)(((intptr_t)1 << PtrTraits::NumLowBitsAvailable)-1), > > my question is why is the shift performed on intptr_t? Wouldn't the > following be ok? > > PointerBitMask = > ~(((uintptr_t)1 << PtrTraits::NumLowBitsAvailable)-1), Hi Maurizio, why do you ask? Is the existing code causing a proble...

>>>>> "Chris" == Chris Lattner <clattner at apple.com> writes: Chris> On Oct 8, 2009, at 10:50 AM, Maurizio Vitale wrote: > around line 45 a bitmask is computed as: >> >> PointerBitMask = ~(uintptr_t)(((intptr_t)1 << >> PtrTraits::NumLowBitsAvailable)-1), >> >> my question is why is the shift performed on intptr_t? Wouldn't >> the following be ok? >> >> PointerBitMask = ~(((uintptr_t)1 << >> PtrTraits::NumLowBitsAvailable)-1), Chris> Hi Maurizio...

...gcc 4.1.2 on linux/ppc64, I now see a warning that I don't remember seeing previously: llvm[2]: Compiling InlineSpiller.cpp for Release+Asserts build /src/llvm-trunk-dev/include/llvm/ADT/PointerIntPair.h: In member function ‘const PointerTy* llvm::PointerIntPair<PointerTy, IntBits, IntType, PtrTraits>::getAddrOfPointer() const [with PointerTy = void*, unsigned int IntBits = 1u, IntType = bool, PtrTraits = llvm::PointerUnionUIntTraits<llvm::VNInfo*, llvm::SmallVector<llvm::VNInfo*, 4u>*>]’: /src/llvm-trunk-dev/include/llvm/ADT/PointerUnion.h:153: instantiated from ‘const PT1* ll...

...return value is changed from r222334. But the comment of the function is same with before as follows: /// insert - This returns true if the pointer was new to the set, false if it /// was already in the set. std::pair<iterator, bool> insert(PtrType Ptr) { auto p = insert_imp(PtrTraits::getAsVoidPointer(Ptr)); return std::make_pair(iterator(p.first, CurArray + CurArraySize), p.second); } If the comment is changed, please change it. Thanks, JinGu Kang

...uot;insert" function... After a detailed look at the header of SmallPtrSet, I found that the SmallPtrSetImpl has an "insert_imp" function which accepts void pointer as argument, and the "insert" function in SmallPtrSet simply cast the incoming pointer to void* by the "PtrTraits::getAsVoidPointer" function and pass the void pointer to insert_imp. So I wonder can we make SmallPtrSetImpl become a template just like SmallVectorImpl? After that we can move insert/erase/count from SmallPtrSet to SmallPtrSetImpl, and users can pass a SmallPtrSetImpl<T> as argument in...

...int, std::allocator<unsigned int> >*, std::__debug::vector<long unsigned int, std::allocator<long unsigned int> >*> >’ /home/jayfoad2/git/llvm-project/llvm/include/llvm/ADT/PointerIntPair.h:71:32: required from ‘void llvm::PointerIntPair<PointerTy, IntBits, IntType, PtrTraits, Info>::initWithPointer(PointerTy) [with PointerTy = void*; unsigned int IntBits = 2; IntType = int; PtrTraits = llvm::pointer_union_detail::PointerUnionUIntTraits<std::__debug::vector<unsigned char, std::allocator<unsigned char> >*, std::__debug::vector<short unsigned int, std...

...*, >> std::__debug::vector<long unsigned int, std::allocator<long unsigned >> int> >*> >’ >> /home/jayfoad2/git/llvm-project/llvm/include/llvm/ADT/PointerIntPair.h:71:32: >> required from ‘void llvm::PointerIntPair<PointerTy, IntBits, >> IntType, PtrTraits, Info>::initWithPointer(PointerTy) [with PointerTy >> = void*; unsigned int IntBits = 2; IntType = int; PtrTraits = >> llvm::pointer_union_detail::PointerUnionUIntTraits<std::__debug::vector<unsigned >> char, std::allocator<unsigned char> >*, std::__debug::vector...

...long unsigned int, std::allocator<long unsigned >> >> int> >*> >’ >> >> /home/jayfoad2/git/llvm-project/llvm/include/llvm/ADT/PointerIntPair.h:71:32: >> >> required from ‘void llvm::PointerIntPair<PointerTy, IntBits, >> >> IntType, PtrTraits, Info>::initWithPointer(PointerTy) [with PointerTy >> >> = void*; unsigned int IntBits = 2; IntType = int; PtrTraits = >> >> llvm::pointer_union_detail::PointerUnionUIntTraits<std::__debug::vector<unsigned >> >> char, std::allocator<unsigned char>...