Displaying 5 results from an estimated 5 matches for "pthread_un".
Did you mean:
pthread_t
2012 Jan 14
2
[LLVMdev] Unreachable code in Mutex.cpp
...n used to do:
static const bool pthread_enabled = static_cast<bool>(pthread_mutex_init);
But that's not what the code does now - the change you made 5 years
ago changed it to a constant:
static const bool pthread_enabled = true;
(I found this because the return outside the 'if (pthread_unabled) {
... return }' was marked as unreachable by -Wunreachable-code). Since
it hasn't actually been doing anything for 5 years - should we just
remove the variable & all the conditions (unconditionally using
pthreads), or reinstate the smarts it used to have (testing the weak
symbol)?
2012 Jan 14
0
[LLVMdev] Unreachable code in Mutex.cpp
...pthread_enabled = static_cast<bool>(pthread_mutex_init);
>
> But that's not what the code does now - the change you made 5 years
> ago changed it to a constant:
>
> static const bool pthread_enabled = true;
>
> (I found this because the return outside the 'if (pthread_unabled) {
> ... return }' was marked as unreachable by -Wunreachable-code). Since
> it hasn't actually been doing anything for 5 years - should we just
> remove the variable & all the conditions (unconditionally using
> pthreads), or reinstate the smarts it used to have (testi...
2012 Jan 14
0
[LLVMdev] Unreachable code in Mutex.cpp
On Jan 13, 2012, at 4:43 PM, David Blaikie wrote:
> It looks like for a while now (5 years) some code that was meant to do
> smart things in Mutex.cpp hasn't been doing such smart things:
>
> https://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/Mutex.cpp?r1=29287&r2=29932&diff_format=h
>
> I don't know if this change was even deliberate since it came in
2012 Jan 14
2
[LLVMdev] Unreachable code in Mutex.cpp
It looks like for a while now (5 years) some code that was meant to do
smart things in Mutex.cpp hasn't been doing such smart things:
https://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/Mutex.cpp?r1=29287&r2=29932&diff_format=h
I don't know if this change was even deliberate since it came in with
another change & the description doesn't mention it. Should we do
2012 Jan 15
1
[LLVMdev] Unreachable code in Mutex.cpp
..._cast<bool>(pthread_mutex_init);
>>
>> But that's not what the code does now - the change you made 5 years
>> ago changed it to a constant:
>>
>> static const bool pthread_enabled = true;
>>
>> (I found this because the return outside the 'if (pthread_unabled) {
>> ... return }' was marked as unreachable by -Wunreachable-code). Since
>> it hasn't actually been doing anything for 5 years - should we just
>> remove the variable & all the conditions (unconditionally using
>> pthreads), or reinstate the smarts it use...