search for: proxyoff

from: Jeff Sloan <jeff_sloan at selinc.com> Update UEFI PXE proxyDHCP handling. This patch is based on commit ID 8a00e49 Modify two files to specify valid ip addresses. These files are efi/pxe.c and efi/udp.c. In efi/pxe.c: In net_parse_dhcp function. If ProxyOffer has been received, start with DhcpAck packet since it is the most complete. This requires a minimum of changes to the packet except that it contains NULL server ip so populate server from ProxyOffer packet. The information is loaded into pkt_v4 and then parsed. In efi/udp.c: Both updates are...

...wise. This may require more code to distinguish subnet-local versus remote. Looks like the thread starting at http://www.syslinux.org/archives/2013-November/021039.html 2) Why not touch efi/tcp.c also which also uses UseDefaultAddress? > In efi/pxe.c: In net_parse_dhcp function. > > If ProxyOffer has been received, start with DhcpAck packet since it is the > most complete. This requires a minimum of changes to the packet except that > it contains NULL server ip so populate server from ProxyOffer packet. The > information is loaded into pkt_v4 and then parsed. > > In efi/udp...

> EFI has proven to be more robust.? The catch > here is order.? The > ProxyOffer data must > take precedence over the PxeReply data but both > of them probably need to be parsed. Not really; If you parse both "next server" from the last parsed packet (PxeReply) will overwrite the value gathered from the ProxyOffer and that leads to "Nest-server"= DH...

...i is taking the next-server IP from an answer from a DHCP server that did not identified itself as a PXE server (no option 60). It looks like a bug to me. I think I "kind" of fixed the bug; at syslinux-6.03/efi/pxe.c void net_parse_dhcp(void) { ... //patmod start if(&mode->ProxyOfferReceived) parse_dhcp(&mode->ProxyOffer.Dhcpv4, pkt_len); else //patmod end parse_dhcp(&mode->PxeReply.Dhcpv4, pkt_len); Print(L"\n"); ... } just add the code surrounded by comments the idea is to ask if there was a proxyOffer first then parse the co...

...ave the MAC resolves the deafness I observed. Commit 8a00e49 is the change. -- -Gene <<< OK; I was about to ask you a few wiershark captures... I looked at the last commit and I think if (mode->PxeReplyReceived) pkt_v4 = &mode->PxeReply.Dhcpv4; else if (mode->ProxyOfferReceived) pkt_v4 = &mode->ProxyOffer.Dhcpv4; should be replaced by if (mode->PxeReplyReceived) pkt_v4 = &mode->PxeReply.Dhcpv4; else if (mode->ProxyOfferReceived) pkt_v4 = &mode->ProxyOffer.Dhcpv4; else pkt_v4 = &mode->DhcpAck.Dhcpv4; thi...

On Mon, Jan 19, 2015 at 3:09 PM, Patrick Masotta <masottaus at yahoo.com> wrote: > >> EFI has proven to be more robust. The catch >> here is order. The >> ProxyOffer data must >> take precedence over the PxeReply data but both >> of them probably need to be parsed. > > Not really; If you parse both "next server" from the > last parsed packet (PxeReply) will overwrite > the value gathered from the ProxyOffer and that leads &gt...

...a DHCP server that > did not identified itself as a PXE server (no option 60). It looks like a bug to me. > > I think I "kind" of fixed the bug; > at syslinux-6.03/efi/pxe.c > > void net_parse_dhcp(void) > { > ... > > //patmod start > if(&mode->ProxyOfferReceived) > parse_dhcp(&mode->ProxyOffer.Dhcpv4, pkt_len); > else > //patmod end > > parse_dhcp(&mode->PxeReply.Dhcpv4, pkt_len); > Print(L"\n"); > > ... > > } > > just add the code surrounded by comments > the idea...

On Sun, Jan 11, 2015 at 10:32 AM, Patrick Masotta <masottaus at yahoo.com> wrote: > >>First, I was looking for the actual values. >>For a VM with (among other values): > >> config.version = "8" >> virtualHW.version = "10" >> ethernet0.virtualDev = "e1000" >> guestOS = "rhel6-64" >> firmware =

...is the change. > -- > -Gene > <<< > > OK; I was about to ask you a few wiershark captures... > > > I looked at the last commit and I think > > if (mode->PxeReplyReceived) > pkt_v4 = &mode->PxeReply.Dhcpv4; > else if (mode->ProxyOfferReceived) > pkt_v4 = &mode->ProxyOffer.Dhcpv4; > > should be replaced by > > if (mode->PxeReplyReceived) > pkt_v4 = &mode->PxeReply.Dhcpv4; > else if (mode->ProxyOfferReceived) > pkt_v4 = &mode->ProxyOffer.Dhcpv4; &...

>First, I was looking for the actual values.? >For a VM with (among other values): > config.version = "8" > virtualHW.version = "10" > ethernet0.virtualDev = "e1000" > guestOS = "rhel6-64" > firmware = "efi" > I see: > option-93 = 0x07 > option-60 ="PXEClient:Arch:00007:UNDI:003016" OK I take

from: Jeff Sloan <jeff_sloan at selinc.com> Update UEFI PXE proxyDHCP handling updated. This patch is based on commit ID 8a00e49 Updated pxe.c and udp.c to incorporate feedback.In addition to the previous modifications: pxe.c: Changed to use ProxyOffer Packet and added client ip from PxeReply into temp packet for parsing. Left all existing cached packets untouched. udp.c: UseDefaultAddress is enabled/disabled based on whether it is a remote or local subnet in core_udp_connect and core_udp_sendto functions. Signed-off-by: Jeff Sloan <je...

...ven there the server ip is incorrect. So we need to either build and populate a complete struct for proxy or pull from several different packets when needed. <<< The DHCP transaction has several stages; in EFI firmware every stage populates a different packet. the packets are: DhcpAck,ProxyOffer,PxeReply. DhcpAck: usually includes only the DHCP parameters ProxyOffer: includes redirection parameters (PXE stuff) PxeReply: is populated after receiving an answer when using PXE menu capabilities. Tianocore copies PxeReply to ProxyOffer because many NBPs do not parse PxeReply This is not rea...

On Sun, Jun 7, 2015 at 5:09 PM, Patrick Masotta <masottaus at yahoo.com> wrote: >>>> > Patrick, I think I've been able to figure out some missing details > about your VMware Workstation tests. For a proxyDHCP, > I'm using dnsmasq. Could you try to confirm your test was the > same basic setup? > > On VMware Workstation 10 with a VMHWv10 VM set to

>> +? ? if(&mode->ProxyOfferReceived) >> +? ? ? ? parse_dhcp(&mode->ProxyOffer.Dhcpv4,pkt_len); >> +? ? else > > I think that change should go into another commit. > Geert Stappers You may be right; but as I've said, all the testing was conducted on PXE (proxyDHCP) environments where those...

...19:39:43.118182728 -0700 > @@ -154,7 +154,12 @@ void net_parse_dhcp(void) > * Get the boot file and other info. This lives in the CACHED_REPLY > * packet (query info 3) > */ > - parse_dhcp(&mode->PxeReply.Dhcpv4, pkt_len); > + > + if(&mode->ProxyOfferReceived) > + parse_dhcp(&mode->ProxyOffer.Dhcpv4, pkt_len); > + else > + parse_dhcp(&mode->PxeReply.Dhcpv4, pkt_len); > + > Print(L"\n"); > > /* I think that change should go into another commit. Groeten Geert Stappers -- Leve...

...r vendor encapsulated options. */ *(char *)&DHCPMagic = 1; /* * Get the boot file and other info. This lives in the CACHED_REPLY * packet (query info 3) */ if(mode->PxeReplyReceived) pkt_v4 = &mode->PxeReply.Dhcpv4; else if(mode->ProxyOfferReceived) { //I decided to populate DhcpAck with all proxy ip addresses but //any of the saved packets can be used. ++ ip = IPInfo.myip; ++ mode->PxeReply.Dhcpv4.BootpYiAddr[0] = ip & 0xff; ++ mode->PxeReply.Dhcpv4.BootpYiAddr[1] = ip >&g...

...0 -0600 +++ b/efi/pxe.c 2015-02-18 19:39:43.118182728 -0700 @@ -154,7 +154,12 @@ void net_parse_dhcp(void) * Get the boot file and other info. This lives in the CACHED_REPLY * packet (query info 3) */ - parse_dhcp(&mode->PxeReply.Dhcpv4, pkt_len); + + if(&mode->ProxyOfferReceived) + parse_dhcp(&mode->ProxyOffer.Dhcpv4, pkt_len); + else + parse_dhcp(&mode->PxeReply.Dhcpv4, pkt_len); + Print(L"\n"); /* diff -uprN a/mk/lib.mk b/mk/lib.mk --- a/mk/lib.mk 2014-10-06 10:27:44.000000000 -0600 +++ b/mk/lib.mk 2015-02-18 20:15:...

...PXE proxyDHCP handling updated. > > This patch is based on commit ID 8a00e49 This commit is outdated. Could you try commit ID 23b2707b as-is first? Thanks. > Updated pxe.c and udp.c to incorporate feedback.In addition to the previous > modifications: > > pxe.c: Changed to use ProxyOffer Packet and added client ip from PxeReply > into temp packet for parsing. Left all existing cached packets untouched. > > udp.c: UseDefaultAddress is enabled/disabled based on whether it is a remote > or local subnet in core_udp_connect and core_udp_sendto functions. > > > Sig...

...This patch is based on commit ID 8a00e49 > > This commit is outdated. Could you try commit ID 23b2707b as-is first? > Thanks. > >> Updated pxe.c and udp.c to incorporate feedback.In addition to the >> previous >> modifications: >> >> pxe.c: Changed to use ProxyOffer Packet and added client ip from PxeReply >> into temp packet for parsing. Left all existing cached packets untouched. >> >> udp.c: UseDefaultAddress is enabled/disabled based on whether it is a >> remote >> or local subnet in core_udp_connect and core_udp_sendto func...

This patch adds to Com32 modules the capabilities of accessing the EFI environment The idea is simple, the EFI parameters "image" and "table" received by syslinux.efi's efi_main() are stored in the "firmware" structure, next they are retrieved from the Com32 module which is linked against the gnu-efi static library. The Com32 module can use the EFI