search for: protocol_handshake

...> + return -1; > + } ... when I run this patch series under valgrind I get mainly errors originating at this malloc: ==1251605== 58 bytes in 4 blocks are definitely lost in loss record 4 of 10 ==1251605== at 0x896180B: malloc (vg_replace_malloc.c:309) ==1251605== by 0x11909F: protocol_handshake_newstyle (protocol-handshake-news tyle.c:288) ==1251605== by 0x118804: protocol_handshake (protocol-handshake.c:55) ==1251605== by 0x112080: handle_single_connection (connections.c:165) ==1251605== by 0x11B84D: start_thread (sockets.c:276) ==1251605== by 0x8BB74E1: start_thread (pthread...

...until today but it >>> seems as if they are a full-duplex protocol layered on top of HTTP [a]. >>> Is there a WebSocket proxy that turns WS into plain TCP (a bit like >>> stunnel)? Google suggests [b]. >>> >>> [a] https://en.wikipedia.org/wiki/WebSocket#Protocol_handshake >>> [b] https://github.com/novnc/websockify >> >> qemu already knows how to connect as a client to websockets; Dan Berrange >> knows more about that setup. I suspect it would not be too difficult to >> teach the qemu NBD client code to use a WebSocket instead of a...

...really know anything about WebSockets until today but it > seems as if they are a full-duplex protocol layered on top of HTTP [a]. > Is there a WebSocket proxy that turns WS into plain TCP (a bit like > stunnel)? Google suggests [b]. > > [a] https://en.wikipedia.org/wiki/WebSocket#Protocol_handshake > [b] https://github.com/novnc/websockify qemu already knows how to connect as a client to websockets; Dan Berrange knows more about that setup. I suspect it would not be too difficult to teach the qemu NBD client code to use a WebSocket instead of a Unix or TCP socket as its data source....

...as if they are a full-duplex protocol layered on top of HTTP [a]. > > >>>Is there a WebSocket proxy that turns WS into plain TCP (a bit like > > >>>stunnel)? Google suggests [b]. > > >>> > > >>>[a] https://en.wikipedia.org/wiki/WebSocket#Protocol_handshake > > >>>[b] https://github.com/novnc/websockify > > >> > > >>qemu already knows how to connect as a client to websockets; Dan Berrange > > >>knows more about that setup. I suspect it would not be too difficult to > > >>teach the qemu NB...

On Thu, 28 May 2020, Richard W.M. Jones wrote: > On Thu, May 28, 2020 at 12:24:22AM +0000, Eric Wheeler wrote: > > On Mon, 15 Oct 2018, Nir Soffer wrote: > > > On Sat, Oct 13, 2018 at 9:45 PM Eric Wheeler <nbd@lists.ewheeler.net> wrote: > > > Hello all, > > > > > > It might be neat to attach ISOs to KVM guests via websockets. 

...> > ... when I run this patch series under valgrind I get mainly errors > originating at this malloc: > > ==1251605== 58 bytes in 4 blocks are definitely lost in loss record 4 of 10 > ==1251605== at 0x896180B: malloc (vg_replace_malloc.c:309) > ==1251605== by 0x11909F: protocol_handshake_newstyle (protocol-handshake-news > tyle.c:288) > ==1251605== by 0x118804: protocol_handshake (protocol-handshake.c:55) > ==1251605== by 0x112080: handle_single_connection (connections.c:165) > ==1251605== by 0x11B84D: start_thread (sockets.c:276) > ==1251605== by 0x8BB74...

...t; >>>seems as if they are a full-duplex protocol layered on top of HTTP [a]. > >>>Is there a WebSocket proxy that turns WS into plain TCP (a bit like > >>>stunnel)? Google suggests [b]. > >>> > >>>[a] https://en.wikipedia.org/wiki/WebSocket#Protocol_handshake > >>>[b] https://github.com/novnc/websockify > >> > >>qemu already knows how to connect as a client to websockets; Dan Berrange > >>knows more about that setup. I suspect it would not be too difficult to > >>teach the qemu NBD client code to use a We...

...a WebSocket. I didn't really know anything about WebSockets until today but it seems as if they are a full-duplex protocol layered on top of HTTP [a]. Is there a WebSocket proxy that turns WS into plain TCP (a bit like stunnel)? Google suggests [b]. [a] https://en.wikipedia.org/wiki/WebSocket#Protocol_handshake [b] https://github.com/novnc/websockify ... > When qemu is running headless using a VNC or Spice display we can access > the display of https+websockets using things like noVNC---which is out of > scope to this converstation---but I'm just saying that such an existing > web fro...

...ut WebSockets until today but it > > seems as if they are a full-duplex protocol layered on top of HTTP [a]. > > Is there a WebSocket proxy that turns WS into plain TCP (a bit like > > stunnel)? Google suggests [b]. > > > > [a] https://en.wikipedia.org/wiki/WebSocket#Protocol_handshake > > [b] https://github.com/novnc/websockify > > qemu already knows how to connect as a client to websockets; Dan Berrange > knows more about that setup. I suspect it would not be too difficult to > teach the qemu NBD client code to use a WebSocket instead of a Unix or TCP > s...

...ll-duplex protocol layered on top of HTTP [a]. > > > >>>Is there a WebSocket proxy that turns WS into plain TCP (a bit like > > > >>>stunnel)? Google suggests [b]. > > > >>> > > > >>>[a] https://en.wikipedia.org/wiki/WebSocket#Protocol_handshake > > > >>>[b] https://github.com/novnc/websockify > > > >> > > > >>qemu already knows how to connect as a client to websockets; Dan Berrange > > > >>knows more about that setup. I suspect it would not be too difficult to > > >...

...ake-oldstyle.c index f5425d3..87cb265 100644 --- a/server/protocol-handshake-oldstyle.c +++ b/server/protocol-handshake-oldstyle.c @@ -41,7 +41,7 @@ #include "internal.h" #include "byte-swapping.h" -#include "protocol.h" +#include "nbd-protocol.h" int protocol_handshake_oldstyle (struct connection *conn) diff --git a/server/protocol-handshake.c b/server/protocol-handshake.c index a0d7dc2..2c2f35e 100644 --- a/server/protocol-handshake.c +++ b/server/protocol-handshake.c @@ -41,7 +41,7 @@ #include "internal.h" #include "byte-swapping.h" -#in...

...truct connection *conn) - __attribute__((__nonnull__ (1))); -extern int connection_set_status (struct connection *conn, int value) - __attribute__((__nonnull__ (1))); +extern int connection_get_status (void); +extern int connection_set_status (int value); /* protocol-handshake.c */ -extern int protocol_handshake (struct connection *conn) - __attribute__((__nonnull__ (1))); -extern int protocol_common_open (struct connection *conn, - uint64_t *exportsize, uint16_t *flags) - __attribute__((__nonnull__ (1, 2, 3))); +extern int protocol_handshake (void); +extern int protocol_c...

v1 was here: https://www.redhat.com/archives/libguestfs/2020-February/msg00081.html v2 replaces struct connection *conn = GET_CONN; with GET_CONN; which sets conn implicitly and asserts that it is non-NULL. If we actually want to test if conn is non-NULL or behave differently, then you must use threadlocal_get_conn() instead, and some existing uses do that. Rich.

The third patch is a large but mechanical change which gets rid of passing around struct connection * entirely within the server, preferring instead to reference the connection through thread-local storage. I hope this is a gateway to simplifying other parts of the code. Rich.

..."backend_finalize") at assert.c:101 #4 0x00005577156ad04e in backend_finalize (b=<optimized out>, conn=conn at entry=0x55771f1ac710) at backend.c:240 #5 0x00005577156b6ea8 in negotiate_handshake_newstyle_options (conn=<optimized out>) at protocol-handshake-newstyle.c:484 #6 protocol_handshake_newstyle (conn=0x55771f1ac710) at protocol-handshake-newstyle.c:762 #7 0x00005577156b5705 in protocol_handshake (conn=conn at entry=0x55771f1ac710) at protocol-handshake.c:55 #8 0x00005577156af73a in handle_single_connection (sockin=<optimized out>, sockout=15) at connections.c:167 #9 0x00...

...conn, size_t i) __attribute__((__nonnull__ (1))); +extern int connection_get_status (struct connection *conn) + __attribute__((__nonnull__ (1))); +extern int connection_set_status (struct connection *conn, int value) + __attribute__((__nonnull__ (1))); + +/* protocol-handshake.c */ +extern int protocol_handshake (struct connection *conn) + __attribute__((__nonnull__ (1))); +extern int protocol_compute_eflags (struct connection *conn, uint16_t *flags) + __attribute__((__nonnull__ (1, 2))); + +/* protocol-handshake-oldstyle.c */ +extern int protocol_handshake_oldstyle (struct connection *conn) + __attribu...

...l meta_context_base_allocation; + char *exportname_from_set_meta_context; + char *exportname; + int sockin, sockout; connection_recv_function recv; connection_send_function send; @@ -273,8 +274,9 @@ extern int connection_set_status (int value); /* protocol-handshake.c */ extern int protocol_handshake (void); -extern int protocol_common_open (uint64_t *exportsize, uint16_t *flags) - __attribute__((__nonnull__ (1, 2))); +extern int protocol_common_open (uint64_t *exportsize, uint16_t *flags, + const char *exportname) + __attribute__((__nonnull__ (1, 2, 3))); /...

These are a couple of patches in preparation for the Block Status implementation. While the patches (especially the second one) are very large they are really just elementary code motion. Rich.

This takes Rich's API proposal and starts fleshing it out with enough meat that I was able to test 'nbdkit eval' advertising multiple exports with descriptions paired with 'qemu-nbd --list'. Eric Blake (3): server: Add exports list functions server: Prepare to use export list from plugin sh, eval: Add .list_exports support Richard W.M. Jones (1): server: Implement

Since the v1 series (0/4, at [1]), I've applied patches 1 and 2, rewritten patch 3 [Forbid NUL in export and context names] into patch 4 here, patch 4 there turned into patch 6 here, and everything else here is new. [1]https://www.redhat.com/archives/libguestfs/2019-September/msg00180.html I don't know if there is a handy reusable function for checking whether a string contains valid