Displaying 3 results from an estimated 3 matches for "promoteintop_any_extend".
2009 Jan 18
0
[LLVMdev] PIC16 backend for llvm 2.5
...ere's also of no mention of the fact that you are allowed to not place anything
in Results, and what that means.
Also, is there any reason not to use ReplaceNodeResults rather than introducing
a new method for type legalization?
> + case ISD::ANY_EXTEND:
> + Results.push_back(PromoteIntOp_ANY_EXTEND(N)); break;
This is wrong if PromoteIntOp_ANY_EXTEND returned a value with
no node. Likewise for all the others. Better I think to simply
handle the custom case immediately and return rather than trying
to share code with these other cases.
Also, you could just make DAGTypeLegalizer::CustomLowe...
2009 Jan 19
1
[LLVMdev] PIC16 backend for llvm 2.5
...by different targets, and have been implemented differently.
The former is meant to legalize illegal value types and the latter is
meant to legalize operations with illegal operands. So they might need
different treatments.
> > + case ISD::ANY_EXTEND:
> > + Results.push_back(PromoteIntOp_ANY_EXTEND(N)); break;
>
> This is wrong if PromoteIntOp_ANY_EXTEND returned a value with
> no node. Likewise for all the others. Better I think to simply
> handle the custom case immediately and return rather than trying
> to share code with these other cases.
>
Taken care of.
> Als...
2009 Jan 18
2
[LLVMdev] PIC16 backend for llvm 2.5
On Fri, 2009-01-16 at 10:03 +0100, Duncan Sands wrote:
> Hi Sanjiv,
>
> > Well the magnitude of the task is not small.
> > ExpandIntegerOperand() calls LowerOperation() to allow targets to handle
> > illegal operands. So we will need to change the interface of
> > LowerOperation() to pass an extra argument called Results, which is an
> > array of SDValue.