search for: progress_counter

...================================================================== RCS file: /cvs/src/usr.bin/ssh/sftp-client.c,v retrieving revision 1.46 diff -u -r1.46 sftp-client.c --- sftp-client.c 17 Feb 2004 05:39:51 -0000 1.46 +++ sftp-client.c 3 Mar 2004 03:05:36 -0000 @@ -805,13 +805,8 @@ max_req = 1; progress_counter = 0; - if (showprogress) { - if (size) - start_progress_meter(remote_path, size, - &progress_counter); - else - printf("Fetching %s to %s\n", remote_path, local_path); - } + if (showprogress && size != 0) + start_progress_meter(remote_path, size, &progress_c...

...ftp-client.c @@ -2010,7 +2010,7 @@ sftp_upload(struct sftp_conn *conn, const char *local_path, int fsync_flag, int inplace_flag) { int r, local_fd; - u_int openmode, id, status = SSH2_FX_OK, reordered = 0; + u_int openmode, id, status = SSH2_FX_OK, failed = 0, reordered = 0; off_t offset, progress_counter; u_char type, *handle, *data; struct sshbuf *msg; @@ -2150,6 +2150,8 @@ sftp_upload(struct sftp_conn *conn, const char *local_path, if ((r = sshbuf_get_u32(msg, &status)) != 0) fatal_fr(r, "parse status"); debug3("SSH2_FXP_STATUS %u", status); + if (status...

Hi, With reference to the latest version of the portable OpenSSH, in file sftp-client.c, it looks to me there may be a bug in function sftp_upload. My understanding is that, when variable "len" is equal to 0, no more SSH_FXP_WRITE messages are sent out and you start draining the queue of pending responses. Variable "len" is set to 0 either when the upload is interrupted, or

https://bugzilla.mindrot.org/show_bug.cgi?id=2021 --- Comment #10 from Loganaden Velvindron <loganaden at gmail.com> --- ping :-) ? -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug.

...write to local */ write_error = read_error = write_errno = num_req = offset = 0; + +#ifdef REGET + if (rflag) { + long posn; + posn = lseek(local_fd, 0L, SEEK_END); + debug3("reget: restarting at file position %ld\n", posn); + offset = (u_int64_t)posn; + } +#endif + max_req = 1; progress_counter = 0; @@ -969,8 +990,13 @@ } int +#ifdef REGET +do_upload(struct sftp_conn *conn, char *local_path, char *remote_path, + int pflag, int rflag) +#else do_upload(struct sftp_conn *conn, char *local_path, char *remote_path, int pflag) +#endif { int local_fd, status; u_int handle_len...

https://bugzilla.mindrot.org/show_bug.cgi?id=2021 Loganaden Velvindron <loganaden at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2199|0 |1 is obsolete| | --- Comment #12 from Loganaden Velvindron