search for: process_write

Hi Damien! I produced a little patch to the package ver. 4.6p1 for linux. My company, for many bureaucratic reasons, was interested in triggering each uploaded file to the server using sftp subsystem. In Internet and in ML, all folks solve the problem using a script joining sftp command section to ssh command section, but unfortunately isn't my case. The patch consist in a

...quot; with OpenSSH version 4.3p2 in the same machine. When I installed the 4.6p1 package to my machine and test sftp from a client, I got the following log messages in the authlog: Sep 5 17:09:51 wcarsx0h sshd[23483]: subsystem request for sftp Sep 5 17:09:56 wcarsx0h sftp-server[23840]: error: process_write: write failed Sep 5 17:09:56 wcarsx0h sshd[23483]: error: channel 0: chan_read_failed for ist Further debugging on process_write of sftp-server.c, I found that the errno returned from the "write" function is always "File too large" no matter what is the size of the file. I app...

...@@ -567,7 +581,7 @@ process_open(void) if (fd < 0) { status = errno_to_portable(errno); } else { - handle = handle_new(HANDLE_FILE, name, fd, NULL); + handle = handle_new(HANDLE_FILE, name, fd, flags, NULL); if (handle < 0) { close(fd); } else { @@ -660,7 +674,8 @@ process_write(void) else if (readonly) status = SSH2_FX_PERMISSION_DENIED; else { - if (lseek(fd, off, SEEK_SET) < 0) { + if (!(handle_to_flags(handle) & O_APPEND) && + lseek(fd, off, SEEK_SET) < 0) { status = errno_to_portable(errno); error("process_write: seek failed&...

...@ -424,6 +427,8 @@ process_read(void) id = get_int(); handle = get_handle(); + if (handle < 0) + goto out; off = get_int64(); len = get_int(); @@ -450,6 +455,7 @@ process_read(void) } } } +out: if (status != SSH2_FX_OK) send_status(id, status); } @@ -461,10 +467,12 @@ process_write(void) u_int64_t off; u_int len; int handle, fd, ret, status = SSH2_FX_FAILURE; - char *data; + char *data = NULL; id = get_int(); handle = get_handle(); + if (handle < 0) + goto out; off = get_int64(); data = get_string(&len); @@ -488,8 +496,10 @@ process_write(void)...

If we can get people to test their platforms against the last snapshot/cvs tree I'd be greatful. (http://www.openssh.com/portable.html) I know NeXT platform has problems. I'm going to spend tonight looking at it. Also, take a moment to see what manpage type ./configure decided for your system and if it's 'cat' please let us know. Thanks. - Ben