search for: process_rename

...current parallel filesystem is FhGFS and we started having complaints about problems with file transfers? We managed to diagnose this to particular ssh clients that do not support the new posix rename extension. Bottom line our filesystem does not support hard links and I think the problem is that process_rename assumes link(old path,newpath) will always return one. Shouldn't this situation, i.e., link returning a symlink, be contemplated in the code? For the time being we changed the code so that posix rename is the default but shouldn't this be addressed? All the best, MAO -------------- next...

...Status: NEW Severity: normal Priority: P2 Component: sftp-server AssignedTo: bitbucket at mindrot.org ReportedBy: tilman.vogel at web.de Looking for a solution to the above problem, I saw in CVSWeb that in current versions of OpenSSH, there is code in process_rename() in sftp-server.c which checks if links are available on the target filesystem. It does so by checking the errno given by link() against EOPNOTSUPP. The problem is: At least on Linux 2.6.x with glibc 2.3.5, link() returns EPERM in this case as is also documented in my copy of "man 2 link&q...

There are a couple of races in sftp-server as this patch shows: --- sftp-server.c 28 Jan 2003 18:06:53 -0000 1.1.1.2 +++ sftp-server.c 5 Feb 2003 19:19:42 -0000 @@ -832,19 +832,22 @@ process_rename(void) { u_int32_t id; - struct stat st; char *oldpath, *newpath; - int ret, status = SSH2_FX_FAILURE; + int status; id = get_int(); oldpath = get_string(NULL); newpath = get_string(NULL); TRACE("rename id %u old %s new %s", id, oldpath, newpath); /* fail if 'newpath...

...Version: 3.8p1 Platform: All OS/Version: All Status: NEW Severity: major Priority: P2 Component: sftp-server AssignedTo: openssh-bugs at mindrot.org ReportedBy: iwish at musician.org I have found that in the static void process_rename(void) function of sftp-server.c when a file being renamed in Linux (and I assume all types on UN*Xs) is mounted on a fat32 partition the rename fails.This may effect other non-posix filesystem files as well. I tracked the problem down to the link(oldpath, newpath) == -1) failing, since the S_ISREG...

Most fixes are trivial. The one from Alex is fixing a real bug that several users have reported. Alex sent the patch half a year ago and it was not yet integrated. The patch "Use /proc/mounts instead of /etc/mtab" is a repost. The patch "btrfs-receive optionally honors the end-cmd" is a preparation step to allow backup tools to multiplex a single communication stream (e.g. a