search for: process_config_lin

Is this a misuse of strtok() in OpenSSH-2.1.1p2? readconf.c:process_config_line() calls strtok() to parse config lines. When it finds oProtocol it calls compat.c:proto_spec() which in turns uses strtok(). However on return of proto_spec(), process_config_line() calls strtok() once more to (quoting from the source code) /* Check that there is no garbage at end of line. */...

....c 7 Nov 2001 01:18:31 -0000 1.1.1.2 +++ readconf.c 8 Feb 2002 08:04:10 -0000 @@ -720,8 +720,9 @@ default: linenum = 0; while (fgets(line, sizeof(line), f)) { /* Update line number counter. */ + const char *hostname = (options->hostname)? options->hostname: host; linenum++; - if (process_config_line(options, host, line, filename, linenum, &active) != 0) + if (process_config_line(options, hostname, line, filename, linenum, &active) != 0) bad_options++; } fclose(f); Is this behaviour acceptable? --- Regards, Shun-ichi Goto <gotoh at taiyo.co.jp> R&D Group, TA...

...exec/ssh-pkcs11-helper\" -D_PATH_SSH_SK_HELPER=\"/usr/local/libexec/ssh-sk-helper\" -D_PATH_SSH_PIDDIR=\"/var/run\" -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/empty\" -DHAVE_CONFIG_H -c session.c -o session.o ranlib libssh.a readconf.c:1033:1: error: conflicting types for ?process_config_line?; have ?int(Options *, struct passwd *, const char *, const char *, char *, const char *, int, int *, int)? 1033 | process_config_line(Options *options, struct passwd *pw, const char *host, | ^~~~~~~~~~~~~~~~~~~ In file included from readconf.c:66: readconf.h:243:10: note: previous declara...

...imb/.ssh/identity type 0 debug1: identity file /home/jimb/.ssh/id_rsa type -1 /bin/sh: line 1: exec: none: not found debug1: identity file /home/jimb/.ssh/id_dsa type 2 ssh_exchange_identification: Connection closed by remote host debug1: Calling cleanup 0x805f31c(0x0) $ The problem seems to be in process_config_line: on entry, 'line' contains a terminating newline: $ gdb ./ssh GNU gdb 2003-04-17-cvs Copyright 2003 Free Software Foundation, Inc. GDB is free software, covered by the GNU General Public License, and you are welcome to change it and/or distribute copies of it under certain conditions. Typ...

...nst char *host, const char *original_host, Options *options, - int flags, int *activep, int *want_final_pass, int depth); + const char *host, const char *original_host, struct sshbuf *remote_command, + Options *options, int flags, int *activep, int *want_final_pass, int depth); static int process_config_line_depth(Options *options, struct passwd *pw, - const char *host, const char *original_host, char *line, - const char *filename, int linenum, int *activep, int flags, + const char *host, const char *original_host, struct sshbuf *remote_command, + char *line, const char *filename, int line...

On Mon, 30 Mar 2015 09:19:02 +1100 (AEDT) Damien Miller <djm at mindrot.org> wrote: > What version of OpenSSH is this? 6.8 portable on Linux. > Also, when reporting fuzzer-derived problems it really helps to > include the test-case. The "test case" is a one byte file containing a zero byte. But here it is :-) -- Hanno B?ck http://hboeck.de/ mail/jabber: hanno at

...is this? > > > > 6.8 portable on Linux. > > That's strange - the line numbers in the valgrind stack trace don't > match. E.g. > > ==5578== at 0x4C2CFCA: __GI_strchr (in > /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) > ==5578== by 0x117B6B: process_config_line (readconf.c:785) > ==5578== by 0x119DED: read_config_file (readconf.c:1633) reproduced; the line numbers were wrong. diff --git a/readconf.c b/readconf.c index 42a2961..5130407 100644 --- a/readconf.c +++ b/readconf.c @@ -763,7 +763,9 @@ process_config_line(Options *options, struct passwd...

... and I guess your next question will be about compilation environment, so: ``` $ gcc --version gcc (Gentoo 13.2.1_p20240210 p14) 13.2.1 20240210 Copyright (C) 2023 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. ``` I'm running on gentoo. I tested that the

https://bugzilla.mindrot.org/show_bug.cgi?id=1967 Bug #: 1967 Summary: Potential memory leak Classification: Unclassified Product: Portable OpenSSH Version: 5.9p1 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P2 Component: ssh AssignedTo: unassigned-bugs at

...nst char *host, const char *original_host, Options *options, - int flags, int *activep, int *want_final_pass, int depth); + const char *host, const char *original_host, struct sshbuf *remote_command, + Options *options, int flags, int *activep, int *want_final_pass, int depth); static int process_config_line_depth(Options *options, struct passwd *pw, - const char *host, const char *original_host, char *line, - const char *filename, int linenum, int *activep, int flags, + const char *host, const char *original_host, struct sshbuf *remote_command, + char *line, const char *filename, int line...

Hey there, I often want different behavior in my ssh client depending on whether I'm logging into an interactive session or running a remote non-interactive command. We can see at, say, https://unix.stackexchange.com/a/499562/305714 that this isn't a unique wish, and existing solutions are kind of baroque. Typical reasons to do this are to immediately go into a screen or tmux session; for

...Keywords: patch Severity: minor Priority: P2 Component: Miscellaneous AssignedTo: bitbucket at mindrot.org ReportedBy: dtucker at zip.com.au Blocks: 1353 Recent versions of gcc emit a the following warnings: readconf.c: In function 'process_config_line': readconf.c:695: warning: dereferencing type-punned pointer will break strict-aliasing rules servconf.c: In function 'process_server_config_line': servconf.c:979: warning: dereferencing type-punned pointer will break strict-aliasing rules servconf.c:990: warning: dereferencing type-pu...

...normal Priority: P2 Component: ssh AssignedTo: openssh-unix-dev at mindrot.org ReportedBy: spaceacademy at hotmail.com If I modify my config to change Identityfile to something like: Identityfile /cygdrive/c/documents and settings/user/my documents/.ssh/id_rsa process_config_line() of readconf.c just calls strdelim() once so the path will be truncated at the first space. ssh fails with the error that there is garbage at the end of this line. ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

...+++ readconf.c 30 Sep 2002 19:00:22 -0000 @@ -724,6 +724,19 @@ if (bad_options > 0) fatal("%s: terminating, %d bad configuration options", filename, bad_options); + + /* + * If proxy_command is set to 'none' (actually ' none' due to the way + * the code in process_config_line works), unset it. This allows for + * excluding certain hosts from using the proxy command while having it + * enabled by default (i.e. for 'Host *') + */ + if (options->proxy_command != NULL) { + if (strcmp(options->proxy_command, " none") == 0) { + xfree(options-&gt...

On 01/06/15 22:17, Tom G. Christensen wrote: > On sparc-sun-solaris2.6 and sparc-sun-solaris2.7 the testsuite fails: > run test cfgparse.sh ... > reparse minimal config > reparse regress config > listenaddress order > bad addr or host: ::1 (no address associated with name) > listenaddress order 1 > bad addr or host: ::1 (no address associated with name) > listenaddress

....2.3-L/opt/sparc-linux/sparc-linux/sys-include/ -lssh -lopenbsd-compat -lresolv -lcrypto -lutil -lz -lnsl -ldl -lcrypt /opt/sparc-linux/bin/sparc-linux-ld.real: AVERTISSEMENT: ne peut trouver le symbole d'entr?e _start; utilise par d?faut 0000000000012200 readconf.o(.text+0x1014): In function `process_config_line': /usr/src/SparcV8Linux/openssh-4.6p1/readconf.c:527: undefined reference to `__muldi3' readconf.o(.text+0x1028):/usr/src/SparcV8Linux/openssh-4.6p1/readconf.c:529: undefined reference to `__divdi3' ./libssh.a(packet.o)(.text+0xab4): In function `set_newkeys': /usr/src/SparcV8Linux...

...c struct { ... keywords[] = ", add near the end of the keywords[] array: - in initialize_options(), initialize the display_comment_str option to -1. - in fill_default_options(), if the display_comment_str option hasn't been set (-1) then set it to 0 ("no"). - in process_config_line() just before the 'default' case, add a case to process the oDisplayCommentStr option. diff: 118c118,119 < oClearAllForwardings, oNoHostAuthenticationForLocalhost --- > oClearAllForwardings, oNoHostAuthenticationForLocalhost, > oDisplayCommentStr 189a191 &g...

...oglevel", oLogLevel }, + { "prngcommandfile", oPrngCommandFile }, { NULL, 0 } }; @@ -583,6 +586,10 @@ *intptr = value; break; + case oPrngCommandFile: + charptr = &ssh_prng_command_file; /* globally def in ssh.h */ + goto parse_string; + default: fatal("process_config_line: Unimplemented opcode %d", opcode); } @@ -788,6 +795,8 @@ options->user_hostfile2 = SSH_USER_HOSTFILE2; if (options->log_level == (LogLevel) - 1) options->log_level = SYSLOG_LEVEL_INFO; + if (ssh_prng_command_file == NULL) + ssh_prng_command_file = xstrdup(SS...

These patches implement a new mux client request to list the currently opened TCP forwardings. It also removes some todos regarding keeping the list of forwardings in the options up-to-date. Bert Wesarg (6): attach the forwarding type to struct Forward merge local and remote forward lists generate unique ids for forwardings to be used for identification remove closed forwardings from

This patch series consists of minor fixes and cleanups I made during update to openssh V_4_6 branch. openssh/auth-pam.c | 9 ++++----- openssh/auth2.c | 2 -- openssh/readconf.c | 7 ++++--- openssh/servconf.c | 14 ++++++++------ openssh/sftp-server.c | 9 ++++++--- openssh/sshd.c | 2 +- 6 files changed, 23 insertions(+), 20 deletions(-) -- ldv