search for: prix16

...@@ return 0; NEWSTYLE.OPT_EXPORT_NAME.CHECK_REPLY: - conn->h->exportsize = be64toh (conn->sbuf.export_name_reply.exportsize); - conn->h->eflags = be16toh (conn->sbuf.export_name_reply.eflags); - debug (conn->h, "exportsize: %" PRIu64 " eflags: 0x%" PRIx16, - conn->h->exportsize, conn->h->eflags); - if (conn->h->eflags == 0) { + uint64_t exportsize; + uint16_t eflags; + + exportsize = be64toh (conn->sbuf.export_name_reply.exportsize); + eflags = be16toh (conn->sbuf.export_name_reply.eflags); + if (nbd_internal_se...

Per recent discussion here: https://www.redhat.com/archives/libguestfs/2019-May/thread.html#00175

...eof (data3)); + memcpy (&data4, guid_bytes + 8, sizeof (data4)); + + /* ensure proper endianness */ + data1 = le32toh (data1); + data2 = le16toh (data2); + data3 = le16toh (data3); + data4 = be64toh (data4); + + return safe_asprintf (g, + "%08" PRIX32 "-%04" PRIX16 "-%04" PRIX16 "-%04" PRIX64 "-%06" PRIX64, + data1, data2, data3, (data4 >> 48), (data4 << 16)); +} + /* NB: This function DOES NOT test for the existence of the file. It * will return non-NULL even if the file/directory does not exist. * Yo...

...eof (data3)); + memcpy (&data4, guid_bytes + 8, sizeof (data4)); + + /* ensure proper endianness */ + data1 = le32toh (data1); + data2 = le16toh (data2); + data3 = le16toh (data3); + data4 = be64toh (data4); + + return safe_asprintf (g, + "%08" PRIX32 "-%04" PRIX16 "-%04" PRIX16 "-%04" PRIX64 "-%012" PRIX64, + data1, data2, data3, data4 >> 48, data4 & 0xffffffffffff); +} + /* NB: This function DOES NOT test for the existence of the file. It * will return non-NULL even if the file/directory does not exist....

...sizeof (data3)); + memcpy (&data4, guid_bytes + 8, sizeof (data4)); + + /* ensure proper endianness */ + data1 = htole32 (data1); + data2 = htole16 (data2); + data3 = htole16 (data3); + data4 = htobe64 (data4); + + snprintf (guid, len, + "%08" PRIX32 "-%04" PRIX16 "-%04" PRIX16 "-%04" PRIX64 "-%06" PRIX64, + data1, data2, data3, (data4 >> 48), (data4 << 16)); + + return guid; +} + /* NB: This function DOES NOT test for the existence of the file. It * will return non-NULL even if the file/directory does...

...se SET_NEXT_STATE (%OPT_STARTTLS.START); diff --git a/generator/states-oldstyle.c b/generator/states-oldstyle.c index babefc0..c0d8af8 100644 --- a/generator/states-oldstyle.c +++ b/generator/states-oldstyle.c @@ -58,6 +58,11 @@ h->gflags = gflags; debug (h, "gflags: 0x%" PRIx16, gflags); + if (gflags) { + set_error (0, "handshake: oldstyle server should not set gflags"); + SET_NEXT_STATE (%.DEAD); + return 0; + } if (nbd_internal_set_size_and_flags (h, exportsize, eflags) == -1) { SET_NEXT_STATE (%.DEAD); diff --git a/lib/handle.c b/lib/handl...

We discovered a possible Downgrade Attack in libnbd. Lifecycle --------- Reported: 2019-09-14 Fixed: 2019-09-16 Published: 2019-09-16 There is no CVE number assigned for this issue yet, but the bug is being categorized and processed by Red Hat's security team which may result in a CVE being published later. Description ----------- Libnbd includes the method nbd_set_tls(h,

...} + return 0; + + NEWSTYLE.OPT_EXPORT_NAME.CHECK_REPLY: + conn->h->exportsize = be64toh (conn->sbuf.export_name_reply.exportsize); + conn->h->eflags = be16toh (conn->sbuf.export_name_reply.eflags); + debug (conn->h, "exportsize: %" PRIu64 " eflags: 0x%" PRIx16, + conn->h->exportsize, conn->h->eflags); + if (conn->h->eflags == 0) { + SET_NEXT_STATE (%.DEAD); + set_error (EINVAL, "handshake: invalid eflags == 0 from server"); + return -1; + } + SET_NEXT_STATE (%.READY); + return 0; + +} /* END STATE MACHINE */ diff...

Some of these affect attempts to connect to older qemu-nbd versions, some of them were triggered by manual edits to qemu-nbd source code to provoke various other compliant (if uncommon) server behaviors. Eric Blake (4): starttls: Skip error payload if falling back to unencrypted states: Reject payload to NBD_REP_ACK meta-context: Skip error payload if server lacks meta_context states: Add

This isn't quite finished because not all of the tests or examples have been updated, but it demonstrates an idea: Should we forget about the concept of having multiple connections managed under a single handle? In this patch there is a single ‘struct nbd_handle *’ which manages a single state machine and connection (and therefore no nbd_connection). To connect to a multi-conn server you must

v9 was here: https://www.redhat.com/archives/libguestfs/2017-July/msg00139.html This depends on these three series (the first two being single minor patches): https://www.redhat.com/archives/libguestfs/2017-July/msg00207.html https://www.redhat.com/archives/libguestfs/2017-July/msg00209.html https://www.redhat.com/archives/libguestfs/2017-July/msg00215.html There is no substantive change. I

This depends on the patch series "[PATCH 00/27] Reimplement many daemon APIs in OCaml." (https://www.redhat.com/archives/libguestfs/2017-July/msg00098.html) v8 was posted here: https://www.redhat.com/archives/libguestfs/2017-June/msg00274.html v9: - I split up the mega-patch into a more reviewable series of smaller, incremental patches. There are some other changes vs v8, but

This fixes almost everything. Note that it adds an extra commit which fixes the whole utf8/iconv business. It's probably better to list what isn't fixed: (1) I didn't leave the osinfo code around because I'm still haven't looked too closely at virt-builder-repository. Can't we just fetch this code from the git history when we need it? (2) I didn't change the way

v10: https://www.redhat.com/archives/libguestfs/2017-July/msg00245.html No actual change here, but I rebased and retested. Also this series now does not depend on any other patch series since everything else needed is upstream. Rich.

v6 was posted here: https://www.redhat.com/archives/libguestfs/2017-June/msg00103.html and this requires the utilities refactoring posted here: https://www.redhat.com/archives/libguestfs/2017-June/msg00169.html Inspection is now complete[*], although not very well tested. I'm intending to compare the output of many guests using old & new virt-inspector to see if I can find any

v5: https://www.redhat.com/archives/libguestfs/2017-June/msg00065.html Since v5, this now implements inspection almost completely for Linux and Windows guests. Rich.

v7 was: https://www.redhat.com/archives/libguestfs/2017-June/msg00169.html https://www.redhat.com/archives/libguestfs/2017-June/msg00184.html I believe this addresses all comments received so far. Also it now passes a test where I compared about 100 disk images processed with old and new virt-inspector binaries. The output is identical in all cases except one which is caused by a bug in blkid