search for: private_data

Asias He (4): vhost-net: Always access vq->private_data under vq mutex vhost-test: Always access vq->private_data under vq mutex vhost-scsi: Always access vq->private_data under vq mutex vhost: Remove custom vhost rcu usage drivers/vhost/net.c | 37 ++++++++++++++++--------------------- drivers/vhost/scsi.c | 17 ++++++----------- drive...

Asias He (4): vhost-net: Always access vq->private_data under vq mutex vhost-test: Always access vq->private_data under vq mutex vhost-scsi: Always access vq->private_data under vq mutex vhost: Remove custom vhost rcu usage drivers/vhost/net.c | 37 ++++++++++++++++--------------------- drivers/vhost/scsi.c | 17 ++++++----------- drive...

On Fri, 30 Dec 2016 18:53:22 +0100 Volker Lendecke via samba <samba at lists.samba.org> wrote: > On Fri, Dec 30, 2016 at 05:55:58PM +0100, Stefan G. Weichinger via > samba wrote: > > Am 2016-12-30 um 17:42 schrieb Rowland Penny via samba: > > > > >OK, try this, open a terminal, type 'winbindd -i' > > >This should directly run winbind in the

...config HOME:schema_mode = rfc2307 doing parameter idmap config HOME:range = 10000-99999 doing parameter winbind nss info = rfc2307 pm_process() returned Yes lp_servicenumber: couldn't find homes Maximum core file size limits now 16777216(soft) -1(hard) Registering messaging pointer for type 2 - private_data=(nil) Registering messaging pointer for type 9 - private_data=(nil) Registered MSG_REQ_POOL_USAGE Registering messaging pointer for type 11 - private_data=(nil) Registering messaging pointer for type 12 - private_data=(nil) Registered MSG_REQ_DMALLOC_MARK and LOG_CHANGED Registering messaging point...

...parameter winbind enum groups = Yes doing parameter winbind use default domain = Yes doing parameter winbind refresh tickets = Yes pm_process() returned Yes lp_servicenumber: couldn't find homes Maximum core file size limits now 16777216(soft) -1(hard) Registering messaging pointer for type 2 - private_data=(nil) Registering messaging pointer for type 9 - private_data=(nil) Registered MSG_REQ_POOL_USAGE Registering messaging pointer for type 11 - private_data=(nil) Registering messaging pointer for type 12 - private_data=(nil) Registered MSG_REQ_DMALLOC_MARK and LOG_CHANGED Registering messaging point...

Amit Shah <amit.shah at redhat.com> writes: > Mateusz Guzik points out that we update the 'file' struct's private_data > field before we've successfully done all our checks. This means we can > return an error with the private_data field updated. This could lead to > problems. > > Fix by moving the assignment after all checks are done. No, this is a bit weird, but it's fine. If we fail op...

Amit Shah <amit.shah at redhat.com> writes: > Mateusz Guzik points out that we update the 'file' struct's private_data > field before we've successfully done all our checks. This means we can > return an error with the private_data field updated. This could lead to > problems. > > Fix by moving the assignment after all checks are done. No, this is a bit weird, but it's fine. If we fail op...

...= Yes > doing parameter winbind use default domain = Yes > doing parameter winbind refresh tickets = Yes > pm_process() returned Yes > lp_servicenumber: couldn't find homes > Maximum core file size limits now 16777216(soft) -1(hard) > Registering messaging pointer for type 2 - private_data=(nil) > Registering messaging pointer for type 9 - private_data=(nil) > Registered MSG_REQ_POOL_USAGE > Registering messaging pointer for type 11 - private_data=(nil) > Registering messaging pointer for type 12 - private_data=(nil) > Registered MSG_REQ_DMALLOC_MARK and LOG_CHANGED &g...

...amba 4.1.x does not have these issues. Kind regards, Martin #winbindd -i -d9 [16738]: request interface version (version = 27) [16738]: request location of privileged pipe accepted socket 24 closing socket 22, client exited [16738]: domain_info [ALS2] Deregistering messaging pointer for type 33 - private_data=(nil) Deregistering messaging pointer for type 13 - private_data=(nil) Deregistering messaging pointer for type 1028 - private_data=(nil) Deregistering messaging pointer for type 1027 - private_data=(nil) Deregistering messaging pointer for type 1029 - private_data=(nil) Deregistering messaging poi...

...was decided to set it at backend start. This is currently done in vhost_init_used()->vhost_init_is_le() but it obfuscates the core vhost code. This patch moves the is_le setup to a dedicated function that is called from the backend code. Note vhost_net is the only backend that can pass vq->private_data == NULL to vhost_init_used(), hence the "if (sock)" branch. No behaviour change. Signed-off-by: Greg Kurz <gkurz at linux.vnet.ibm.com> --- drivers/vhost/net.c | 6 ++++++ drivers/vhost/scsi.c | 3 +++ drivers/vhost/test.c | 2 ++ drivers/vhost/vhost.c | 12 +++++++...

...was decided to set it at backend start. This is currently done in vhost_init_used()->vhost_init_is_le() but it obfuscates the core vhost code. This patch moves the is_le setup to a dedicated function that is called from the backend code. Note vhost_net is the only backend that can pass vq->private_data == NULL to vhost_init_used(), hence the "if (sock)" branch. No behaviour change. Signed-off-by: Greg Kurz <gkurz at linux.vnet.ibm.com> --- drivers/vhost/net.c | 6 ++++++ drivers/vhost/scsi.c | 3 +++ drivers/vhost/test.c | 2 ++ drivers/vhost/vhost.c | 12 +++++++...

...was decided to set it at backend start. This is currently done in vhost_init_used()->vhost_init_is_le() but it obfuscates the core vhost code. This patch moves the is_le setup to a dedicated function that is called from the backend code. Note vhost_net is the only backend that can pass vq->private_data == NULL to vhost_init_used(), hence the "if (sock)" branch. No behaviour change. Reviewed-by: Cornelia Huck <cornelia.huck at de.ibm.com> Signed-off-by: Greg Kurz <gkurz at linux.vnet.ibm.com> --- Hi Michael, This is a cleanup patch I had posted last year: http://patchwor...

...was decided to set it at backend start. This is currently done in vhost_init_used()->vhost_init_is_le() but it obfuscates the core vhost code. This patch moves the is_le setup to a dedicated function that is called from the backend code. Note vhost_net is the only backend that can pass vq->private_data == NULL to vhost_init_used(), hence the "if (sock)" branch. No behaviour change. Reviewed-by: Cornelia Huck <cornelia.huck at de.ibm.com> Signed-off-by: Greg Kurz <gkurz at linux.vnet.ibm.com> --- Hi Michael, This is a cleanup patch I had posted last year: http://patchwor...

...> host-userspace vhost vsock guest vsock > > > ============== =========== ============ > > > connect() --------> vhost_transport_send_pkt_work() initializing > > > | vq->private_data==NULL > > > | will not be queued > > > V > > > schedule_timeout(2s) > > > vhost_vsock_start() <--------- device ready > > > set vq->private_data > > > > >...

...> host-userspace vhost vsock guest vsock > > > ============== =========== ============ > > > connect() --------> vhost_transport_send_pkt_work() initializing > > > | vq->private_data==NULL > > > | will not be queued > > > V > > > schedule_timeout(2s) > > > vhost_vsock_start() <--------- device ready > > > set vq->private_data > > > > >...

...t/net.c b/drivers/vhost/net.c > index 9eda69e40678..df01c939cd00 100644 > --- a/drivers/vhost/net.c > +++ b/drivers/vhost/net.c > @@ -917,6 +917,9 @@ static long vhost_net_set_backend(struct vhost_net *n, unsigned index, int fd) > > vhost_net_disable_vq(n, vq); > vq->private_data = sock; > + > + vhost_adjust_vring_endian(vq); > + > r = vhost_init_used(vq); > if (r) > goto err_used; This is in fact a bug in existing code: if vhost_init_used fails, it preferably should not have side-effects. It's best to update it last thing. > diff --gi...

...t/net.c b/drivers/vhost/net.c > index 9eda69e40678..df01c939cd00 100644 > --- a/drivers/vhost/net.c > +++ b/drivers/vhost/net.c > @@ -917,6 +917,9 @@ static long vhost_net_set_backend(struct vhost_net *n, unsigned index, int fd) > > vhost_net_disable_vq(n, vq); > vq->private_data = sock; > + > + vhost_adjust_vring_endian(vq); > + > r = vhost_init_used(vq); > if (r) > goto err_used; This is in fact a bug in existing code: if vhost_init_used fails, it preferably should not have side-effects. It's best to update it last thing. > diff --gi...

...ore) May 4 17:38:41 print winbindd[1702]: unable to change to /var/log/samba/cores/winbindd May 4 17:38:41 print winbindd[1702]: refusing to dump core Another: [2015/05/04 17:51:39.909354, 5] ../source3/lib/messages.c:340(messaging_deregister) Deregistering messaging pointer for type 33 - private_data=(nil) [2015/05/04 17:51:39.909699, 5] ../source3/lib/messages.c:340(messaging_deregister) Deregistering messaging pointer for type 13 - private_data=(nil) [2015/05/04 17:51:39.909853, 5] ../source3/lib/messages.c:340(messaging_deregister) Deregistering messaging pointer for type 1028 - privat...

Hi, I have a Samba4 domain controller installed on Debian Wheezy (Domain = CHEZMOI.PRIV). I try to installed an another Samba4 server which is just a member of the CHEZMOI.PRIV domain. But I don't succeed. I have followed this page : https://wiki.samba.org/index.php/Samba4/Domain_Member But I have : ~# net ads join -U administrator Enter administrator's password: kinit succeeded but

...; This is currently done in vhost_init_used()->vhost_init_is_le() but it > > obfuscates the core vhost code. This patch moves the is_le setup to a > > dedicated function that is called from the backend code. > > > > Note vhost_net is the only backend that can pass vq->private_data == NULL to > > vhost_init_used(), hence the "if (sock)" branch. > > > > No behaviour change. > > > > Reviewed-by: Cornelia Huck <cornelia.huck at de.ibm.com> > > Signed-off-by: Greg Kurz <gkurz at linux.vnet.ibm.com> > > --- > &gt...