search for: printmachineinstruction

llvm no build? llvm/llvm/lib/Target/PIC16/PIC16AsmPrinter.cpp: In member function ‘bool llvm::PIC16AsmPrinter::printMachineInstruction(const llvm::MachineInstr*)’: llvm/lib/Target/PIC16/PIC16AsmPrinter.cpp:80: error: ‘CurBank’ was not declared in this scope llvm/lib/Target/PIC16/PIC16AsmPrinter.cpp: In member function ‘virtual bool llvm::PIC16AsmPrinter::runOnMachineFunction (llvm::MachineFunction&)’: llvm/lib/Target/PI...

Mike Stump wrote: > llvm no build? > > llvm/llvm/lib/Target/PIC16/PIC16AsmPrinter.cpp: In member function > ‘bool llvm::PIC16AsmPrinter::printMachineInstruction(const > llvm::MachineInstr*)’: > llvm/lib/Target/PIC16/PIC16AsmPrinter.cpp:80: error: ‘CurBank’ was not > declared in this scope > llvm/lib/Target/PIC16/PIC16AsmPrinter.cpp: In member function ‘virtual > bool llvm::PIC16AsmPrinter::runOnMachineFunction > (llvm::MachineFunct...

On Friday 10 July 2009 00:19, Chris Lattner wrote: > asmprinter::printInstruction will lower a MachineInstr to an MCInst, > then call the MCInst asmprinter to do the hard formatting work. You > can see a horrible simple skeleton of this idea in > X86ATTAsmPrinter::printMachineInstruction. Yep, that's where I hit the problem. I'm patching the sources for the comment emitter and of course MCInst doesn't have the right interfaces yet. > > I'm porting some > > patches we have here that affect MachineInstrs and am wondering > > whether I > > ne...

...asmprinting (for example) will no longer work directly on MachineInstr. Instead, asmprinter::printInstruction will lower a MachineInstr to an MCInst, then call the MCInst asmprinter to do the hard formatting work. You can see a horrible simple skeleton of this idea in X86ATTAsmPrinter::printMachineInstruction. There is a ton of refactoring and cleanup left to do, but a great benefit of this is that it really helps clean up the targets and make them do the right things in the right places. > I'm porting some > patches we have here that affect MachineInstrs and am wondering > whether...

Can someone explain what MCInst is vs. MachineIntr? I'm porting some patches we have here that affect MachineInstrs and am wondering whether I need to make similar changes in MCInst. Why do we have two machine instruction representations? -Dave

I noticed that the AsmWriter backend of TableGen is no longer handling the IMPLICIT_DEF case in printInstruction() function (by calling printImplicitDef). It was doing so in llvm 2.6. Is it supposed to be handled explicitly in printMachineInstruction()? What is the recommended method? Manjunath