Displaying 6 results from an estimated 6 matches for "printerpass".
2010 Mar 17
4
[LLVMdev] [PATCH] Before/After IR Dumps
...reene wrote:
> On Sunday 14 March 2010 18:32:35 Chris Lattner wrote:
> > This is much better than the first iteration but still has many issues.
I believe I've addressed all your points with this patch except I didn't use
StringRef. It doesn't appear to be useful since createPrinterPass will
be sent a const std::string & and will feed a constant std::string &
in the create*PrinterPass interfaces.
Any additional feedback from anyone?
-Dave
-------------- next part --------------
A non-text attachment was scrubbed...
Name:...
2010 Mar 19
0
[LLVMdev] [PATCH] Before/After IR Dumps
...On Sunday 14 March 2010 18:32:35 Chris Lattner wrote:
> > > This is much better than the first iteration but still has many issues.
>
> I believe I've addressed all your points with this patch except I didn't
> use StringRef. It doesn't appear to be useful since createPrinterPass will
> be sent a const std::string & and will feed a constant std::string & in the
> create*PrinterPass interfaces.
>
> Any additional feedback from anyone?
Ping?
-Dave
2010 Mar 22
1
[LLVMdev] [PATCH] Before/After IR Dumps
...attner wrote:
> > > > This is much better than the first iteration but still has many
> > > > issues.
> >
> > I believe I've addressed all your points with this patch except I didn't
> > use StringRef. It doesn't appear to be useful since createPrinterPass
> > will be sent a const std::string & and will feed a constant std::string &
> > in the create*PrinterPass interfaces.
> >
> > Any additional feedback from anyone?
>
> Ping?
Ping?
-Dave
2010 Mar 26
0
[LLVMdev] [PATCH] Before/After IR Dumps
...On Sunday 14 March 2010 18:32:35 Chris Lattner wrote:
>>> This is much better than the first iteration but still has many issues.
>
> I believe I've addressed all your points with this patch except I didn't use
> StringRef. It doesn't appear to be useful since createPrinterPass will
> be sent a const std::string & and will feed a constant std::string &
> in the create*PrinterPass interfaces.
>
> Any additional feedback from anyone?
This is looking much better, thanks. I'd still prefer using StringRef instead of std::string here because it cleans...
2010 Mar 15
0
[LLVMdev] [PATCH] Before/After IR Dumps
...y 14 March 2010 18:32:35 Chris Lattner wrote:
> This is much better than the first iteration but still has many issues.
> There is no need to keep cc'ing cfe-dev on these patches which have nothing
> to do with clang.
There's a clang patch in this set.
> Please rename the getPrinterPass method to createPrinterPass to indicate
> that the result returns a new pass, not returning an existing one. Please
Ok.
> make it take a StringRef, not an std::string and eliminate the <string>
> #include from Pass.h.
Ok.
> MachineFunctionPrinterPass.h doesn't need to #in...
2010 Mar 14
3
[LLVMdev] [PATCH] Before/After IR Dumps
...ot;
>> Seems raw_ostream is forward declared but not defined (adding a missing
>> #include fixed that).
>
> It shouldn't need to be defined. Perhaps std::string is the issue, though I
> don't know why I don't see the problem. Probably because
> MachineFunctionPrinterPass.h includes <string> somewhere along
> the line.
This is much better than the first iteration but still has many issues. There is no need to keep cc'ing cfe-dev on these patches which have nothing to do with clang.
Please rename the getPrinterPass method to createPrinterPass to indic...