search for: prf_data

...patch is doing. The key type before the change is StringRef, while the after the key type is uint64_t. Are you suggesting treating uint64_t md5 sum key as a string of 8 bytes or storing md5 has in text form which will double the size? In the raw format, md5 sum key can be an embedded field in the prf_data variable instead of as different var referenced by prf_data. > > If this is not the case, you should show your current patch so that we can > discuss things concretely. It is not. See above about the difference. > >> >> > >> > >> >> >> >&g...

...to make room. > +Filipe, do you remember how much memory UBSan was using that caused a > problem? > My proposal does help reducing rodata size significantly. David > -- Sean Silva > >> >> >> In the raw format, md5 sum key can be an embedded field in the >> prf_data variable instead of as different var referenced by prf_data. >> >> > >> > If this is not the case, you should show your current patch so that we >> > can >> > discuss things concretely. >> >> It is not. See above about the difference. >> &...

...se cases and the relevant workflow issues. > > -- Sean Silva > >> >> >> David >> >> >> > -- Sean Silva >> > >> >> >> >> >> >> In the raw format, md5 sum key can be an embedded field in the >> >> prf_data variable instead of as different var referenced by prf_data. >> >> >> >> > >> >> > If this is not the case, you should show your current patch so that >> >> > we >> >> > can >> >> > discuss things concretely. &gt...

...>> >> >> David >> >> >> >> >> >> > -- Sean Silva >> >> > >> >> >> >> >> >> >> >> >> In the raw format, md5 sum key can be an embedded field in the >> >> >> prf_data variable instead of as different var referenced by >> >> >> prf_data. >> >> >> >> >> >> > >> >> >> > If this is not the case, you should show your current patch so >> >> >> > that >> >> &g...

...;> >> >> >> >> > -- Sean Silva >> >> >> > >> >> >> >> >> >> >> >> >> >> >> >> In the raw format, md5 sum key can be an embedded field in the >> >> >> >> prf_data variable instead of as different var referenced by >> >> >> >> prf_data. >> >> >> >> >> >> >> >> > >> >> >> >> > If this is not the case, you should show your current patch so >> >> &gt...

...; > -- Sean Silva >>>> >> >> > >>>> >> >> >> >>>> >> >> >> >>>> >> >> >> In the raw format, md5 sum key can be an embedded field in the >>>> >> >> >> prf_data variable instead of as different var referenced by >>>> >> >> >> prf_data. >>>> >> >> >> >>>> >> >> >> > >>>> >> >> >> > If this is not the case, you should show your curren...

On Fri, Sep 4, 2015 at 5:21 PM, Sean Silva <chisophugis at gmail.com> wrote: > > > On Fri, Sep 4, 2015 at 3:57 PM, Xinliang David Li <davidxl at google.com> > wrote: >> >> > >> > I think it is reasonable to simply replace the key we currently use with >> > MD5(key) for getting a size reduction. In practice for my use cases, I >> >