search for: prev_mode

...00000004fd6b5 in kn_opus_decode (decHandle=0x712357d0, decProp=0x1675698, src=0x16756d0, dest=0x71245a60, dstLen=0x1673210) at MSTranscodeOPUS.c:100 *And the code flow what we have observed for this specific incident:* *Called this as mode is CELT_ONLY,* if (data!=NULL && st->prev_mode > 0 && ( (mode == MODE_CELT_ONLY && st->prev_mode != MODE_CELT_ONLY && !st->prev_redundancy) || (mode != MODE_CELT_ONLY && st->prev_mode == MODE_CELT_ONLY) ) ) { *transition = 1*; /* Decide where to allocate the stack memor...

...dest=0x71245a60, > > dstLen=0x1673210) at MSTranscodeOPUS.c:100 > > > > *_And the code flow what we have observed for this specific incident:_* > *_ > _* > *_Called this as mode is CELT_ONLY,_* > > if (data!=NULL && st->prev_mode > 0 && ( > (mode == MODE_CELT_ONLY && st->prev_mode != MODE_CELT_ONLY && > !st->prev_redundancy) > || (mode != MODE_CELT_ONLY && st->prev_mode == MODE_CELT_ONLY) ) > ) > { > _transition =...

Yes, good point. I added the checking of prev_mode for Silk DTX to avoid using stale data from the Silk state. The PR is updated, and I'm attaching an updated patch. /Gustaf On Tue, 9 Apr 2019 at 12:42, Mark Harris <mark.hsj at gmail.com> wrote: > On 2019-04-08 4:55, Gustaf Ullberg wrote: > > Thank you Mark. > > > &gt...

...> > > > > > > *_And the code flow what we have observed for this specific > incident:_* > > *_ > > _* > > *_Called this as mode is CELT_ONLY,_* > > > > if (data!=NULL && st->prev_mode > 0 && ( > > (mode == MODE_CELT_ONLY && st->prev_mode != MODE_CELT_ONLY && > > !st->prev_redundancy) > > || (mode != MODE_CELT_ONLY && st->prev_mode == MODE_CELT_ONLY) ) > > ) >...

...712357d0, > decProp=0x1675698, src=0x16756d0, dest=0x71245a60, > > dstLen=0x1673210) at MSTranscodeOPUS.c:100 > > > *And the code flow what we have observed for this specific incident:* > > *Called this as mode is CELT_ONLY,* > > if (data!=NULL && st->prev_mode > 0 && ( > (mode == MODE_CELT_ONLY && st->prev_mode != MODE_CELT_ONLY && > !st->prev_redundancy) > || (mode != MODE_CELT_ONLY && st->prev_mode == MODE_CELT_ONLY) ) > ) > { > *transition = 1*; > /* Decid...

Hi, I'm curious to know when would be the 1.1.1 stable version available. In 1.1, we are facing crash when opus library is trying to decode the CELT-only, full band and 20 ms. So we tried with 1.1.1 beta and it looks to be fine. Is there any open issue regarding this in 1.1 version? Thanks Suresh -------------- next part -------------- An HTML attachment was scrubbed... URL:

...673210) at MSTranscodeOPUS.c:100 > > > > > > > > *_And the code flow what we have observed for this specific > incident:_* > > *_ > > _* > > *_Called this as mode is CELT_ONLY,_* > > > > if (data!=NULL && st->prev_mode > 0 && ( > > (mode == MODE_CELT_ONLY && st->prev_mode != MODE_CELT_ONLY && > > !st->prev_redundancy) > > || (mode != MODE_CELT_ONLY && st->prev_mode == MODE_CELT_ONLY) ) > > ) > > { &gt...

...> > > *_And the code flow what we have observed for this specific > > incident:_* > > > *_ > > > _* > > > *_Called this as mode is CELT_ONLY,_* > > > > > > if (data!=NULL && st->prev_mode > 0 && ( > > > (mode == MODE_CELT_ONLY && st->prev_mode != > MODE_CELT_ONLY && > > > !st->prev_redundancy) > > > || (mode != MODE_CELT_ONLY && st->prev_mode == > MODE_CELT_ONLY) ) > &g...

...erved for this > specific > > > incident:_* > > > > *_ > > > > _* > > > > *_Called this as mode is CELT_ONLY,_* > > > > > > > > if (data!=NULL && st->prev_mode > 0 && ( > > > > (mode == MODE_CELT_ONLY && st->prev_mode != > > MODE_CELT_ONLY && > > > > !st->prev_redundancy) > > > > || (mode != MODE_CELT_ONLY && st->prev_mo...

Thank you Mark. I agree and have now updated the pull request with a new commit, addressing your comments. Please take a look. /Gustaf On Fri, 5 Apr 2019 at 11:41, Mark Harris <mark.hsj at gmail.com> wrote: > On 2019-04-01 3:37, Gustaf Ullberg wrote: > > Hi everyone, > > > > Some time ago, I sent a pull request > > <https://github.com/xiph/opus/pull/107>

..._And the code flow what we have observed for this specific > > incident:_* > > > *_ > > > _* > > > *_Called this as mode is CELT_ONLY,_* > > > > > > if (data!=NULL && st->prev_mode > 0 && ( > > > (mode == MODE_CELT_ONLY && st->prev_mode != > MODE_CELT_ONLY && > > > !st->prev_redundancy) > > > || (mode != MODE_CELT_ONLY && st->prev_mode == > MODE_...

...t; incident:_* > > > > > *_ > > > > > _* > > > > > *_Called this as mode is CELT_ONLY,_* > > > > > > > > > > if (data!=NULL && st->prev_mode > 0 && ( > > > > > (mode == MODE_CELT_ONLY && st->prev_mode != > > > MODE_CELT_ONLY && > > > > > !st->prev_redundancy) > > > > > || (mode != MODE...

...ific > > > incident:_* > > > > *_ > > > > _* > > > > *_Called this as mode is CELT_ONLY,_* > > > > > > > > if (data!=NULL && st->prev_mode > 0 && ( > > > > (mode == MODE_CELT_ONLY && st->prev_mode != > > MODE_CELT_ONLY && > > > > !st->prev_redundancy) > > > > || (mode != MODE_CELT_ONLY &&amp...

On 2019-04-08 4:55, Gustaf Ullberg wrote: > Thank you Mark. > > I agree and have now updated the pull request with a new commit, > addressing your comments. > Please take a look. > > /Gustaf I think you will also need to check the mode of the previous frame (st->prev_mode) before using internal SILK encoder state. It could have been in SILK DTX some time ago, but then switched to CELT. Normally there would be at least one non-DTX SILK/Hybrid frame before it switches to CELT only, but it is possible to switch directly from SILK DTX to CELT only mode (for example, i...

...gt;> > > > > *_ >> > > > > _* >> > > > > *_Called this as mode is CELT_ONLY,_* >> > > > > >> > > > > if (data!=NULL && st->prev_mode > 0 && ( >> > > > > (mode == MODE_CELT_ONLY && st->prev_mode != >> > > MODE_CELT_ONLY && >> > > > > !st->prev_redundancy) >> > > > >...

On 2019-04-10 3:27, Gustaf Ullberg wrote: > Yes, good point. I added the checking of prev_mode for Silk DTX to avoid > using stale data from the Silk state. > The PR is updated, and I'm attaching an updated patch. > > /Gustaf Thanks. This looks good to me. - Mark