search for: preserve_times

We use rsync to update an nfs server. After an update, we noticed that a large number of clients didn't see the updated data. It took me a while to be able to reliably reproduce this problem, but it happens on old and new versions of rysnc. It also happens across all the platforms we use here (sun/linux/netapp). This shows the problem: [Note my home directory is NFS mounted]

...PPORT_LINKS if (S_ISLNK(st.st_mode)) { diff -r --unified rsync-2.5.4pre1-orig/options.c rsync-2.5.4pre1/options.c --- rsync-2.5.4pre1-orig/options.c Thu Feb 28 09:49:57 2002 +++ rsync-2.5.4pre1/options.c Tue Mar 12 22:01:45 2002 @@ -31,6 +31,7 @@ int preserve_uid = 0; int preserve_gid = 0; int preserve_times = 0; +int drop_suid = 0; int update_only = 0; int cvs_exclude = 0; int dry_run=0; @@ -199,6 +200,7 @@ rprintf(F," -g, --group preserve group\n"); rprintf(F," -D, --devices preserve devices (root only)\n"); rprintf(F," -t, --times...

...============================================================ RCS file: /cvsroot/rsync/generator.c,v retrieving revision 1.282 diff -u -r1.282 generator.c --- generator.c 1 Jun 2006 08:04:40 -0000 1.282 +++ generator.c 2 Jun 2006 13:00:01 -0000 @@ -45,6 +45,7 @@ extern int preserve_gid; extern int preserve_times; extern int omit_dir_times; +extern int omit_dir_changes; extern int delete_mode; extern int delete_before; extern int delete_during; @@ -348,10 +349,11 @@ iflags |= ITEM_REPORT_TIME; if ((file->mode & CHMOD_BITS) != (st->st_mode & CHMOD_BITS)) iflags |= ITEM_REPORT_PER...

...================================================== RCS file: /cvsroot/rsync/options.c,v retrieving revision 1.147 diff -u -w -r1.147 options.c --- options.c 17 Apr 2004 17:07:23 -0000 1.147 +++ options.c 20 Apr 2004 21:06:18 -0000 @@ -46,6 +46,7 @@ int preserve_uid = 0; int preserve_gid = 0; int preserve_times = 0; +int copy_atimes = 0; int update_only = 0; int cvs_exclude = 0; int dry_run = 0; @@ -241,6 +242,7 @@ rprintf(F," -g, --group preserve group\n"); rprintf(F," -D, --devices preserve devices (root only)\n"); rprintf(F," -t, --time...

...) flags |= SAME_ACCESS_TIME; There's also a much more important issue with respect to this flag (below). > *** ./rsync.c Mon Jan 24 04:13:39 2000 > --- ./rsync.c Sun Feb 6 21:01:26 2000 ... > *************** > *** 162,181 **** > st = &st2; > } > > - if (preserve_times && !S_ISLNK(st->st_mode) && > - st->st_mtime != file->modtime) { > - /* don't complain about not setting times on directories > - because some filesystems can't do it */ > - if (set_modtime(fname,file->modtime) != 0 && > -...

...===== RCS file: /cvsroot/rsync/generator.c,v retrieving revision 1.77 diff -u -w -r1.77 generator.c --- generator.c 7 Mar 2004 20:29:59 -0000 1.77 +++ generator.c 10 Apr 2004 23:28:35 -0000 @@ -43,6 +43,7 @@ extern int always_checksum; extern char *compare_dest; extern int link_dest; +extern int preserve_times; /* choose whether to skip a particular file */ @@ -90,7 +91,11 @@ return 0; } - return (cmp_modtime(st->st_mtime,file->modtime) == 0); + if (preserve_times && cmp_time(st->st_atime,file->atime) != 0) { + return 0; + } + + return (cmp_tim...

I've run into a bug in the IO handling when reading a file. Suppose I have a file that lives on an NFS filesystem. That filesystem is NOT being exported with auth=0 permissions. So, if I try to access a file as root, it successfully opens the file, but subsequent reads fail with EACCES. This produces a destination file full of null bytes. I noticed this with 2.5.7, but checked 2.6.2 as

...ut rsync insists in changing the timestamps. I know that symlink timestamps can't be changed. So I've spent a week trying to prevent rsync from changing symlink timestamps by systematically editing rsync.c near lines 462 & and config.h.in near line 230 in an attempt to circumvent either preserve_times or lutines without success. I even changed the default umask to recreate the symlinks hoping the problem would go away. I've also followed the 540 relevant rsync mail list topics on this. I'm currently using rsync 3.0.4 with the fileflags.diff & crtimes.diff patches on OS-X 10.5.5. R...

...r 23 11:16:15 2004 +++ rsync-2.6.2-new/rsync.c Wed Sep 15 01:35:16 2004 @@ -129,7 +129,6 @@ STRUCT_STAT st2; int change_uid, change_gid; - if (dry_run) return 0; if (!st) { if (link_stat(fname,&st2) != 0) { @@ -142,6 +141,10 @@ if (preserve_times && !S_ISLNK(st->st_mode) && cmp_modtime(st->st_mtime, file->modtime) != 0) { + if (dry_run) { + rprintf(FINFO,"modtime: %s\n",fname); + return 0; + } /* don't complain...

...urse into directories\n"); rprintf(F," -R, --relative use relative path names\n"); @@ -332,6 +334,7 @@ {"devices", 'D', POPT_ARG_NONE, &preserve_devices , 0, 0, 0 }, {"times", 't', POPT_ARG_NONE, &preserve_times , 0, 0, 0 }, {"checksum", 'c', POPT_ARG_NONE, &always_checksum , 0, 0, 0 }, + {"ignorecase", 0, POPT_ARG_NONE, &ignore_case, 0, 0, 0 }, {"verbose", 'v', POPT_ARG_NONE, 0, 'v', 0, 0 }, {...

...s) { hard_link_cluster(file, ndx, diff -uNr rsync-2.6.6/options.c rsync-2.6.6_patch/options.c --- rsync-2.6.6/options.c 2005-05-19 10:52:17.000000000 +0200 +++ rsync-2.6.6_patch/options.c 2006-01-11 15:56:00.000000000 +0100 @@ -48,6 +48,7 @@ int preserve_uid = 0; int preserve_gid = 0; int preserve_times = 0; +int preserve_atime = 0; int omit_dir_times = 0; int update_only = 0; int cvs_exclude = 0; @@ -286,6 +287,7 @@ rprintf(F," -g, --group preserve group\n"); rprintf(F," -D, --devices preserve devices (root only)\n"); rprintf(F,"...

..., descrip, argDesc */ @@ -336,7 +336,7 @@ {"group", 'g', POPT_ARG_NONE, &preserve_gid, 0, 0, 0 }, {"devices", 'D', POPT_ARG_NONE, &preserve_devices, 0, 0, 0 }, {"times", 't', POPT_ARG_NONE, &preserve_times, 0, 0, 0 }, - {"checksum", 'c', POPT_ARG_NONE, &always_checksum, 0, 0, 0 }, + {"checksum", 'c', POPT_ARG_NONE, &always_checksum, OPT_CHECKSUM, 0, 0 }, {"verbose", 'v', POPT_ARG_NONE, 0, '...

...rlen(fname) + strlen(".cvsignore") <= MAXPATHLEN - 1) { strcpy(p, ".cvsignore"); diff -ru rsync-2.5.6cvs/options.c rsync-2.5.6cvsJ/options.c --- rsync-2.5.6cvs/options.c Tue Jan 14 09:35:25 2003 +++ rsync-2.5.6cvsJ/options.c Tue Jan 14 09:35:40 2003 @@ -45,6 +45,7 @@ int preserve_times = 0; int update_only = 0; int cvs_exclude = 0; +int rsync_exclude = 0; int dry_run=0; int local_server=0; int ignore_times=0; @@ -237,6 +238,7 @@ rprintf(F," -e, --rsh=COMMAND specify the remote shell\n"); rprintf(F," --rsync-path=PATH specify path to r...

...har *fname); int copy_file(char *source, char *dest, mode_t mode); int robust_unlink(char *fname); *** options.c@@/main/original/1 Tue Apr 9 14:03:18 2002 --- options.c Tue Apr 9 15:59:10 2002 *************** *** 44,49 **** --- 44,50 ---- int preserve_uid = 0; int preserve_gid = 0; int preserve_times = 0; + int preserve_atime = 0; int update_only = 0; int cvs_exclude = 0; int dry_run=0; *************** *** 220,225 **** --- 221,227 ---- rprintf(F," -g, --group preserve group\n"); rprintf(F," -D, --devices preserve devices (root only)\n&q...

...diff -pur rsync-3.0.7/rsync.c rsync-3.0.7.new/rsync.c --- rsync-3.0.7/rsync.c 2009-12-19 21:39:49.000000000 +0000 +++ rsync-3.0.7.new/rsync.c 2010-06-14 10:24:49.339960221 +0100 @@ -34,6 +34,7 @@ extern int preserve_xattrs; extern int preserve_perms; extern int preserve_executability; extern int preserve_times; +extern int copy_devices; extern int am_root; extern int am_server; extern int am_sender; @@ -328,7 +329,8 @@ int read_ndx_and_attrs(int f_in, int *if if (iflags & ITEM_TRANSFER) { int i = ndx - cur_flist->ndx_start; - if (i < 0 || !S_ISREG(cur_flist->files[i]->mode)) {...

...file list"); + recur_local_exclude_list = NULL; + start_write = stats.total_written; flist = flist_new(); diff -ru rsync-2.5.6/options.c rsync-2.5.6J/options.c --- rsync-2.5.6/options.c Mon Jan 27 20:11:57 2003 +++ rsync-2.5.6J/options.c Thu Feb 13 11:13:01 2003 @@ -45,6 +45,7 @@ int preserve_times = 0; int update_only = 0; int cvs_exclude = 0; +const char *rsync_exclude = NULL; int dry_run=0; int local_server=0; int ignore_times=0; @@ -84,7 +85,6 @@ int modify_window=0; int blocking_io=-1; - /** Network address family. **/ #ifdef INET6 int default_af_hint = 0; /* Any protocol */...

...0pre9/rsync.c Thu Feb 7 16:24:58 2008 +++ rsync-3.0.0pre9-flags/rsync.c Fri Feb 15 19:39:33 2008 @@ -32,6 +32,7 @@ extern int dry_run; extern int preserve_acls; extern int preserve_xattrs; extern int preserve_perms; +extern int preserve_fileflags; extern int preserve_executability; extern int preserve_times; extern int am_root; @@ -60,6 +61,16 @@ iconv_t ic_chck = (iconv_t)-1; iconv_t ic_send = (iconv_t)-1, ic_recv = (iconv_t)-1; # endif +#ifdef SUPPORT_FLAGS +#ifndef UF_NOUNLINK +#define UF_NOUNLINK 0 +#endif +#ifndef SF_NOUNLINK +#define SF_NOUNLINK 0 +#endif +#define NOCHANGE_FLAGS (UF_IMMUTAB...

People of cygwin & rsync, I recently attempted to get cygwin and rsync working to solve a backup/mirroring need in my computer life. Well, as you might guess, I ran into a little but of trouble. Strangely enough, rsync seemed to be regularly hanging when I attempted to do a "get" (sycronize a remote to a local dir). Well, considering I want to automate this, that was not going

...9: external declaration in primary source file extern int preserve_perms; ^ rsync.c(36): remark #1419: external declaration in primary source file extern int preserve_executability; ^ rsync.c(37): remark #1419: external declaration in primary source file extern int preserve_times; ^ rsync.c(38): remark #1419: external declaration in primary source file extern int omit_dir_times; ^ rsync.c(39): remark #1419: external declaration in primary source file extern int am_root; ^ rsync.c(40): remark #1419: external declaration in primar...