search for: preserve_acls

Hi, I'm using 2.6.9 but I get: recv_files phase=1 generate_files phase=2 recv_files phase=2 recv_files finished generate_files phase=3 deleting in home delete_in_dir(home) [generator] make_file(home/administ,*,2) Internal error: wrong write used in receiver. _exit_cleanup(code=2, file=io.c, line=1204): entered _exit_cleanup(code=19, file=main.c, line=1182): entered rsync error: received

...peedup is 0.00 rsync error: some files could not be transferred (code 23) at main.c(1031) [sender=3.0.3dev] PATCH: --- rsync-3.0.2_base/rsync.c 2008-04-08 21:37:18.000000000 -0500 +++ rsync-3.0.2/rsync.c 2008-04-14 13:05:44.000000000 -0500 @@ -31,6 +31,7 @@ extern int dry_run; extern int preserve_acls; extern int preserve_xattrs; +extern int force_change; extern int preserve_perms; extern int preserve_fileflags; extern int preserve_executability; @@ -445,6 +446,11 @@ if (daemon_chmod_modes && !S_ISLNK(new_mode)) new_mode = tweak_mode(new_mode, daemon_chmod_modes); +#ifdef...

...eiver. It looks like the receiver tried to read each file's ACL before it actually created the file. I think I have tracked down the problem. In lines 1392-1393, the generator reads the old ACL of a destination file about to be overwritten so it knows whether to itemize an ACL change: if (preserve_acls && real_ret == 0) get_acl(fname, &real_sx); Presumably real_ret is zero if and only if the destination file actually exists. However, back in lines 1210-1226, the generator sets real_ret to 0 if a basis file is found, even though the destination file does not exist: if (statret !...

...er=3.0.3dev] PATCH: diff -Naur rsync-3.0.3pre3_base/rsync.c rsync-3.0.3pre3_patched/rsync.c --- rsync-3.0.3pre3_base/rsync.c 2008-06-23 22:31:58.000000000 -0700 +++ rsync-3.0.3pre3_patched/rsync.c 2008-06-23 22:59:03.000000000 -0700 @@ -31,6 +31,7 @@ extern int dry_run; extern int preserve_acls; extern int preserve_xattrs; +extern int force_change; extern int preserve_perms; extern int preserve_fileflags; extern int preserve_executability; @@ -445,6 +446,11 @@ if (daemon_chmod_modes && !S_ISLNK(new_mode)) new_mode = tweak_mode(new_mode, daemon_chmod_mod...

...9-flags/compat.c --- rsync-3.0.0pre9/compat.c Sat Jan 26 20:58:17 2008 +++ rsync-3.0.0pre9-flags/compat.c Fri Feb 15 19:33:09 2008 @@ -44,6 +44,7 @@ extern int protocol_version; extern int protect_args; extern int preserve_uid; extern int preserve_gid; +extern int preserve_fileflags; extern int preserve_acls; extern int preserve_xattrs; extern int need_messages_from_generator; @@ -60,7 +61,7 @@ extern iconv_t ic_send, ic_recv; #endif /* These index values are for the file-list's extra-attribute array. */ -int uid_ndx, gid_ndx, acls_ndx, xattrs_ndx, unsort_ndx; +int uid_ndx, gid_ndx, fileflags...

...to be included in the patch distribution, it's just a proof of concept. diff -pur rsync-3.0.7/generator.c rsync-3.0.7.new/generator.c --- rsync-3.0.7/generator.c 2009-12-23 19:36:27.000000000 +0000 +++ rsync-3.0.7.new/generator.c 2010-06-15 11:08:41.919557425 +0100 @@ -39,6 +39,7 @@ extern int preserve_acls; extern int preserve_xattrs; extern int preserve_links; extern int preserve_devices; +extern int copy_devices; extern int preserve_specials; extern int preserve_hard_links; extern int preserve_executability; @@ -980,7 +981,7 @@ static int try_dests_reg(struct file_str do { pathjoin(cmp...

In the mandriva rpm of rsync, we apply for our rpm the acl patch in the patches directory. I am trying to update our rpm to rsync 2.6.6 but one of the test failed with this patch. It seems to be a minor problem, but can you have a look ? Thanks by advance. Following the message (a bit long): ----- itemize log follows Testing for symlinks using 'test -h' +

...fix.??Has?this?already?been?fixed?in?2.6.3?or?the? upcoming .4, or is someone interested in what I did? What I did was pretty simple.??To?acls.c?I?added?a?function? test_if_acls_match().??I?then?modified?skip_file()?in?generator.c?to?use? this, instead of stat()'s modes, if both link_dest and preserve_acls are set.?? This solves both of the above problems.??The?differences?in?stat()'s?return? of modes between Linux and Solaris is avoided because skip_file() isn't looking at the modes of the old and new files; it's looking at the ACLs.?? And because it is looking at the ACLs, it'll...

...fix. Has this already been fixed in 2.6.3 or the upcoming .4, or is someone interested in what I did? What I did was pretty simple. To acls.c I added a function test_if_acls_match(). I then modified skip_file() in generator.c to use this, instead of stat()'s modes, if both link_dest and preserve_acls are set. This solves both of the above problems. The differences in stat()'s return of modes between Linux and Solaris is avoided because skip_file() isn't looking at the modes of the old and new files; it's looking at the ACLs. And because it is looking at the ACLs, it'll...

.../options.c 2009-04-13 08:01:14.000000000 +1200 +++ rsync-3.0.6-writedev/options.c 2009-10-15 20:56:18.000000000 +1300 @@ -48,6 +48,7 @@ int keep_dirlinks = 0; int copy_dirlinks = 0; int copy_links = 0; +int write_devices = 0; int preserve_links = 0; int preserve_hard_links = 0; int preserve_acls = 0; @@ -350,6 +351,7 @@ rprintf(F," -o, --owner preserve owner (super-user only)\n"); rprintf(F," -g, --group preserve group\n"); rprintf(F," --devices preserve device files (super-user only)\n"); + rprintf(F...