search for: pr34474

Hi Craig, thanks for digging into this. So InstCombine is the wrong place for fixing PR34474. Can you give me a hint where such an optimization should go into CodeGen? I am not really familiar with stuff that happens after the MidLevel. Cheers, Michael Am 13.09.2017 um 19:21 schrieb Craig Topper: > And that is less instructions. So from InstCombine's perspective the > multip...

...p if some other > transform is reversing your transform. Can you send the whole patch and a > test case? > > ~Craig > > On Wed, Sep 13, 2017 at 10:01 AM, Haidl, Michael via llvm-dev < > llvm-dev at lists.llvm.org> wrote: > >> Hi, >> >> I am working on PR34474 and try to add a new optimization to >> InstCombine. Like in other parts of the visitMul function I add a Shl >> through the IR builder and create a new BinaryOp which I return from >> visitMul. If I understand correctly the new BinaryOp returned from >> visitMul should repl...

...were you thinking? > > ~Craig > > On Wed, Sep 13, 2017 at 10:06 PM, Haidl, Michael <michael.haidl at uni-muenster.de <mailto:michael.haidl at uni-muenster.de>> wrote: > Hi Craig, > > thanks for digging into this. So InstCombine is the wrong place for > fixing PR34474. Can you give me a hint where such an optimization should > go into CodeGen? I am not really familiar with stuff that happens after > the MidLevel. > > Cheers, > Michael > > Am 13.09.2017 um 19:21 schrieb Craig Topper: > > And that is less instructions. So from InstComb...

Hi, I am working on PR34474 and try to add a new optimization to InstCombine. Like in other parts of the visitMul function I add a Shl through the IR builder and create a new BinaryOp which I return from visitMul. If I understand correctly the new BinaryOp returned from visitMul should replace the original Instruction in...

...Sep 13, 2017 at 10:06 PM, Haidl, Michael >> <michael.haidl at uni-muenster.de <mailto:michael.haidl at uni-muenster.de>> >> wrote: >> >> Hi Craig, >> >> thanks for digging into this. So InstCombine is the wrong place for >> fixing PR34474. Can you give me a hint where such an optimization >> should >> go into CodeGen? I am not really familiar with stuff that happens >> after >> the MidLevel. >> >> Cheers, >> Michael >> >> Am 13.09.2017 um 19:21 schrieb...

...ailto:michael.haidl at uni-muenster.de> <mailto:michael.haidl at uni-muenster.de<mailto:michael.haidl at uni-muenster.de>>> >> wrote: >> >> Hi Craig, >> >> thanks for digging into this. So InstCombine is the wrong place for >> fixing PR34474. Can you give me a hint where such an optimization >> should >> go into CodeGen? I am not really familiar with stuff that happens >> after >> the MidLevel. >> >> Cheers, >> Michael >> >> Am 13.09.2017 um 19:21 schrieb...

...Michael > >> <michael.haidl at uni-muenster.de <mailto:michael.haidl at uni-muenster.de>> > >> wrote: > >> > >> Hi Craig, > >> > >> thanks for digging into this. So InstCombine is the wrong place for > >> fixing PR34474. Can you give me a hint where such an optimization > >> should > >> go into CodeGen? I am not really familiar with stuff that happens > >> after > >> the MidLevel. > >> > >> Cheers, > >> Michael > >> &gt...