Displaying 2 results from an estimated 2 matches for "pr30188".
Did you mean:
pr10189
2016 Sep 02
2
Problem with "[SimplifyCFG] Handle tail-sinking of more than 2 incoming branches"
Hello,
I’m getting some failures on our internal testing happening after this commit.
I dug a little bit into it and it ended up begin caused by the fact that this optimization is sinking some instructions that shouldn’t be sunk
In particular we have some loads that need to have a constant address to be selected, because they load from a “special address space”.
What the optimization is doing
2016 Sep 02
2
Problem with "[SimplifyCFG] Handle tail-sinking of more than 2 incoming branches"
...yCFG.
> On 2 Sep 2016, at 13:35, Michael Kuperstein <mkuper at google.com> wrote:
>
> Hello Marcello,
>
> We're currently planning to disable this optimization - at least temporarily - for cases where we'll end up creating PHIs of pointers for performance reasons (see PR30188).
>
> Having said that - I don't believe this is something you can rely on for correctness.
> From an IR semantics perspective, this is a completely legal transformation that can be introduced by any optimization pass, for whatever reason. We can't control that throughout the enti...