Displaying 2 results from an estimated 2 matches for "pr28821".
2016 Aug 03
2
RFC: We should stop merging allocas in the inliner
...to just fail for no
reason: "NArchive::N7z::GetStringForSizeValue(unsigned int)" in
7zHandler.cpp has exactly the same sequence of instructions after the
change but 3x larger stack. But this appears to be rare and mostly relating
to functions with already small stack sizes. I've filed PR28821 to track
this.
Anyways, while clearly some stuff will need cleaning up, I don't see
anything really scary jumping out here.
-Chandler
On Tue, Aug 2, 2016 at 1:02 AM Chandler Carruth <chandlerc at gmail.com> wrote:
> Seeing no big concerns raised with this direction...
>
> On...
2016 Aug 01
16
RFC: We should stop merging allocas in the inliner
Chris added alloca merging in the inliner a looooong time ago, 2009. The
reason he added it was because at the time we didn't do stack coloring and
without it we had serious stack size problems in LLVM.
Since then, a few rather important things have changed:
- We have reasonably powerful stack coloring support in the backend based
on lifetime markers
- Clang (the primary frontend I'm