search for: pr2823

...ires ABI alignment). I've now created a patch that makes sure that any struct typed alloca is never changed by instcombine, unless all it's uses are bitcasts to the same type. This seems like the most sane way to do things. This change did expose some alignment-related bug in llvm-gcc, see PR2823. This means that committing preserve-struct.diff will result in a test-suite failure (at least SingleSource/UnitTests/Vector/divides, I haven't finished testing Multisource yet), but this is caused by llvm-gcc, not instcombine. Related to this issue, I've created two more patches. I'm...

...reated a patch that makes sure that any struct typed > alloca is never > changed by instcombine, unless all it's uses are bitcasts to the > same type. > This seems like the most sane way to do things. This change did > expose some > alignment-related bug in llvm-gcc, see PR2823. This means that > committing > preserve-struct.diff will result in a test-suite failure (at least > SingleSource/UnitTests/Vector/divides, I haven't finished testing > Multisource > yet), but this is caused by llvm-gcc, not instcombine. > > Related to this issue, I'...

On Sep 13, 2008, at 1:07 PM, Matthijs Kooijman wrote: > Hi Dan, > >> Changing PromoteCastOfAllocation to not replace aggregate allocas >> with >> non-aggregate allocas if they have GEP users sounds reasonable to me. > This sounds reasonable indeed, but still a bit arbitrary. Haven't > figured out > anything better yet, though. > >> Finding the

Hi Dan, > Changing PromoteCastOfAllocation to not replace aggregate allocas with > non-aggregate allocas if they have GEP users sounds reasonable to me. This sounds reasonable indeed, but still a bit arbitrary. Haven't figured out anything better yet, though. > Finding the maximum alignment is sometimes still useful though, so > it would be nice to update the alignment field of