search for: pr26808

TLDR: Heads up for out of tree backends - you're going to need to update your *DAGToDAGISel::Select method to unconditionally replace nodes directly instead of returning the desired replacement. So I'm working on fixing the undefined behaviour I described in llvm.org/PR26808. As part of this, we need to stop looking into deleted SDNodes to check if they were, in fact, deleted. A big place that we do this is in SelectionDAGISel::DoInstructionSelection, where we can find this helpful comment that came with the commit that added the check for DELETED_NODE: SelectionDAGIS...

...LDR: Heads up for out of tree backends - you're going to need to update > your *DAGToDAGISel::Select method to unconditionally replace nodes > directly instead of returning the desired replacement. > > So I'm working on fixing the undefined behaviour I described in > llvm.org/PR26808. As part of this, we need to stop looking into deleted > SDNodes to check if they were, in fact, deleted. A big place that we do > this is in SelectionDAGISel::DoInstructionSelection, where we can find > this helpful comment that came with the commit that added the check for > DELETED_N...

...t of tree backends - you're going to need to update >> your *DAGToDAGISel::Select method to unconditionally replace nodes >> directly instead of returning the desired replacement. >> >> So I'm working on fixing the undefined behaviour I described in >> llvm.org/PR26808. As part of this, we need to stop looking into deleted >> SDNodes to check if they were, in fact, deleted. A big place that we do >> this is in SelectionDAGISel::DoInstructionSelection, where we can find >> this helpful comment that came with the commit that added the check for &g...

...you're going to need to update >>> your *DAGToDAGISel::Select method to unconditionally replace nodes >>> directly instead of returning the desired replacement. >>> >>> So I'm working on fixing the undefined behaviour I described in >>> llvm.org/PR26808. As part of this, we need to stop looking into deleted >>> SDNodes to check if they were, in fact, deleted. A big place that we do >>> this is in SelectionDAGISel::DoInstructionSelection, where we can find >>> this helpful comment that came with the commit that added the...