search for: ppcallbacks

On Mon, Nov 9, 2015 at 4:00 AM, Aboud, Amjad <amjad.aboud at intel.com> wrote: > I found a way to skip representing macros in AST and create them directly > in CGDebugInfo through PPCallbacks during preprocessing. > > To do that, I needed to extend ASTConsumer interface with this extra > method: > > > > /// If the consumer is interested in notifications from Preprocessor, > > /// for example: notifications on macro definitions, etc., it should > return...

> Right - I was wondering if CGDebugInfo already implemented PPCallbacks or was otherwise being notified of PPCallback related things, possibly through a layer or two of indirection. I checked the approach of skipping representing macros in AST, and communicate them directly from Parser to CGDebugInfo. However, I could not find a way to initialize this communication. T...

...via cfe-dev < > cfe-dev at lists.llvm.org> wrote: > >> On Mon, Nov 9, 2015 at 4:00 AM, Aboud, Amjad <amjad.aboud at intel.com> >> wrote: >> >>> I found a way to skip representing macros in AST and create them >>> directly in CGDebugInfo through PPCallbacks during preprocessing. >>> >>> To do that, I needed to extend ASTConsumer interface with this extra >>> method: >>> >>> >>> >>> /// If the consumer is interested in notifications from Preprocessor, >>> >>> /// for e...

> Do we really need to touch the AST? Or would it be reasonable to wire up the CGDebugInfo directly to the PPCallbacks, if it isn't already? (perhaps it is already wired up for other reasons?) This sound as a good idea, I will check that approach. PPCallbacks is only an interface, has nothing connected to it, but we will create a new class, which implement PPCallbacks, for macros. So we can connect whatever we...

...ect: Re: [llvm-dev] RFC: Supporting macros in LLVM debug info On Tue, Nov 3, 2015 at 12:16 AM, Aboud, Amjad <amjad.aboud at intel.com<mailto:amjad.aboud at intel.com>> wrote: > Do we really need to touch the AST? Or would it be reasonable to wire up the CGDebugInfo directly to the PPCallbacks, if it isn't already? (perhaps it is already wired up for other reasons?) This sound as a good idea, I will check that approach. PPCallbacks is only an interface, has nothing connected to it, but we will create a new class, which implement PPCallbacks, for macros. Right - I was wondering if CG...

...> >> >> >> >> >> >> >> On Tue, Nov 3, 2015 at 12:16 AM, Aboud, Amjad <amjad.aboud at intel.com> >> wrote: >> >> > Do we really need to touch the AST? Or would it be reasonable to wire >> up the CGDebugInfo directly to the PPCallbacks, if it isn't already? >> (perhaps it is already wired up for other reasons?) >> >> This sound as a good idea, I will check that approach. >> >> PPCallbacks is only an interface, has nothing connected to it, but we >> will create a new class, which implement P...

...fter the "start_file" of the main source. [Design] To support macros the following components need to be modified: Clang, LLVM IR, Dwarf Debug emitter. In clang, we need to handle these source directives: 1. #define 2. #undef 3. #include The idea is to make a use of "PPCallbacks" class, which allows preprocessor to notify the parser each time one of the above directives occurs. These are the callbacks that should be implemented: "MacroDefined", "MacroUndefined", "FileChanged", and "InclusionDirective". AST will be extended to s...