search for: port_fail

...nt avail_slots = 63, ret; + int avail_slots = 63, payload_count = 0, ret; /* There's no possible scenario where releasing VCPI or keeping it the * same would make the state invalid @@ -3575,6 +3575,13 @@ drm_dp_mst_atomic_check_topology_state(struct drm_dp_mst_topology_mgr *mgr, goto port_fail; } + if (++payload_count > mgr->max_payloads) { + DRM_DEBUG_ATOMIC("[MST MGR:%p] state %p has too many payloads (max=%d)\n", + mgr, mst_state, mgr->max_payloads); + ret = -EINVAL; + goto port_fail; + } + drm_dp_mst_topology_put_port(vcpi->port); } DRM_...

[sorry about the resend-copy pasted the wrong header and I want to make sure this doesn't get missed!] This patchset does some cleaning up of the atomic VCPI helpers for MST, and converts nouveau over to using them. I would have included amdgpu in this patch as well, but at the moment moving them over to the atomic helpers is nontrivial. Cc: Daniel Vetter <daniel at ffwll.ch> Lyude

This patchset does some cleaning up of the atomic VCPI helpers for MST, and converts nouveau over to using them. I would have included amdgpu in this patch as well, but at the moment moving them over to the atomic helpers is nontrivial. Cc: Daniel Vetter <daniel at ffwll.ch> Lyude Paul (5): drm/dp_mst: Add some atomic state iterator macros drm/dp_mst: Start tracking per-port VCPI

This patchset does some cleaning up of the atomic VCPI helpers for MST, and converts nouveau over to using them. I would have included amdgpu in this patch as well, but at the moment moving them over to the atomic helpers is nontrivial. Cc: Daniel Vetter <daniel at ffwll.ch> Lyude Paul (5): drm/dp_mst: Add some atomic state iterator macros drm/dp_mst: Start tracking per-port VCPI

This patchset does some cleaning up of the atomic VCPI helpers for MST, and converts nouveau over to using them. I would have included amdgpu in this patch as well, but at the moment moving them over to the atomic helpers is nontrivial. Cc: Daniel Vetter <daniel at ffwll.ch> Lyude Paul (5): drm/dp_mst: Add some atomic state iterator macros drm/dp_mst: Start tracking per-port VCPI

...gt; + > + avail_slots -= vcpi->vcpi; > + if (avail_slots < 0) { > + DRM_DEBUG_ATOMIC("[MST PORT:%p] not enough vcpi slots in mst_state %p (avail=%d)\n", > + vcpi->port, mst_state, > + avail_slots + vcpi->vcpi); > + ret = -ENOSPC; > + goto port_fail; > + } > + > + drm_dp_put_port(port); > + } > + DRM_DEBUG_ATOMIC("[MST MGR:%p] mst_state %p vcpi avail=%d used=%d\n", > + mgr, mst_state, avail_slots, > + 63 - avail_slots); > + > + return 0; > +port_fail: > + drm_dp_put_port(port); > + return r...

..., + vcpi->port, vcpi->vcpi); + + avail_slots -= vcpi->vcpi; + if (avail_slots < 0) { + DRM_DEBUG_ATOMIC("[MST PORT:%p] not enough vcpi slots in mst_state %p (avail=%d)\n", + vcpi->port, mst_state, + avail_slots + vcpi->vcpi); + ret = -ENOSPC; + goto port_fail; + } + + drm_dp_put_port(port); + } + DRM_DEBUG_ATOMIC("[MST MGR:%p] mst_state %p vcpi avail=%d used=%d\n", + mgr, mst_state, avail_slots, + 63 - avail_slots); + + return 0; +port_fail: + drm_dp_put_port(port); + return ret; +} + +/** + * drm_dp_mst_atomic_check - Check that the n...

This patchset does some cleaning up of the atomic VCPI helpers for MST, and converts nouveau over to using them. I would have included amdgpu in this patch as well, but at the moment moving them over to the atomic helpers is nontrivial. [sorry for still not adding your R-Bs! I ended up needing to make a lot of changes to make it so we do actually kref() each port in the atomic state] Cc: Daniel

...ts < 0) { > > > + DRM_DEBUG_ATOMIC("[MST PORT:%p] not enough vcpi slots > > > in mst_state %p (avail=%d)\n", > > > + vcpi->port, mst_state, > > > + avail_slots + vcpi->vcpi); > > > + ret = -ENOSPC; > > > + goto port_fail; > > > + } > > > + > > > + drm_dp_put_port(port); > > > + } > > > + DRM_DEBUG_ATOMIC("[MST MGR:%p] mst_state %p vcpi avail=%d used=%d\n", > > > + mgr, mst_state, avail_slots, > > > + 63 - avail_slots); > > > +...

...pi; > > + if (avail_slots < 0) { > > + DRM_DEBUG_ATOMIC("[MST PORT:%p] not enough vcpi slots > > in mst_state %p (avail=%d)\n", > > + vcpi->port, mst_state, > > + avail_slots + vcpi->vcpi); > > + ret = -ENOSPC; > > + goto port_fail; > > + } > > + > > + drm_dp_put_port(port); > > + } > > + DRM_DEBUG_ATOMIC("[MST MGR:%p] mst_state %p vcpi avail=%d used=%d\n", > > + mgr, mst_state, avail_slots, > > + 63 - avail_slots); > > + > > + return 0; > > +port_f...

..., + vcpi->port, vcpi->vcpi); + + avail_slots -= vcpi->vcpi; + if (avail_slots < 0) { + DRM_DEBUG_ATOMIC("[MST PORT:%p] not enough VCPI slots in mst state %p (avail=%d)\n", + vcpi->port, mst_state, + avail_slots + vcpi->vcpi); + ret = -ENOSPC; + goto port_fail; + } + + drm_dp_mst_topology_put_port(vcpi->port); + } + DRM_DEBUG_ATOMIC("[MST MGR:%p] mst state %p VCPI avail=%d used=%d\n", + mgr, mst_state, avail_slots, + 63 - avail_slots); + + return 0; +port_fail: + drm_dp_mst_topology_put_port(vcpi->port); + return ret; +} + +/** +...

...t; + DRM_DEBUG_ATOMIC("[MST PORT:%p] not enough vcpi slots > > > > in mst_state %p (avail=%d)\n", > > > > + vcpi->port, mst_state, > > > > + avail_slots + vcpi->vcpi); > > > > + ret = -ENOSPC; > > > > + goto port_fail; > > > > + } > > > > + > > > > + drm_dp_put_port(port); > > > > + } > > > > + DRM_DEBUG_ATOMIC("[MST MGR:%p] mst_state %p vcpi avail=%d used=%d\n", > > > > + mgr, mst_state, avail_slots, > > > > +...

...gt; + > + avail_slots -= vcpi->vcpi; > + if (avail_slots < 0) { > + DRM_DEBUG_ATOMIC("[MST PORT:%p] not enough VCPI slots in mst state %p (avail=%d)\n", > + vcpi->port, mst_state, > + avail_slots + vcpi->vcpi); > + ret = -ENOSPC; > + goto port_fail; > + } > + > + drm_dp_put_port(port); > + } > + DRM_DEBUG_ATOMIC("[MST MGR:%p] mst state %p VCPI avail=%d used=%d\n", > + mgr, mst_state, avail_slots, > + 63 - avail_slots); > + > + return 0; > +port_fail: > + drm_dp_put_port(port); > + return r...

..., + vcpi->port, vcpi->vcpi); + + avail_slots -= vcpi->vcpi; + if (avail_slots < 0) { + DRM_DEBUG_ATOMIC("[MST PORT:%p] not enough VCPI slots in mst state %p (avail=%d)\n", + vcpi->port, mst_state, + avail_slots + vcpi->vcpi); + ret = -ENOSPC; + goto port_fail; + } + + drm_dp_put_port(port); + } + DRM_DEBUG_ATOMIC("[MST MGR:%p] mst state %p VCPI avail=%d used=%d\n", + mgr, mst_state, avail_slots, + 63 - avail_slots); + + return 0; +port_fail: + drm_dp_put_port(port); + return ret; +} + +/** + * drm_dp_mst_atomic_check - Check that the n...

...> > > > > in mst state %p (avail=%d)\n", > > > > > > > + vcpi->port, mst_state, > > > > > > > + avail_slots + vcpi->vcpi); > > > > > > > + ret = -ENOSPC; > > > > > > > + goto port_fail; > > > > > > > + } > > > > > > > + > > > > > > > + drm_dp_put_port(port); > > > > > > > + } > > > > > > > + DRM_DEBUG_ATOMIC("[MST MGR:%p] mst state %p VCPI avail=%d > > > > &...

...ough > > > > > VCPI slots > > > > > in mst state %p (avail=%d)\n", > > > > > + vcpi->port, mst_state, > > > > > + avail_slots + vcpi->vcpi); > > > > > + ret = -ENOSPC; > > > > > + goto port_fail; > > > > > + } > > > > > + > > > > > + drm_dp_put_port(port); > > > > > + } > > > > > + DRM_DEBUG_ATOMIC("[MST MGR:%p] mst state %p VCPI avail=%d > > > > > used=%d\n", > > > > > +...

...ts < 0) { > > > + DRM_DEBUG_ATOMIC("[MST PORT:%p] not enough VCPI slots > > > in mst state %p (avail=%d)\n", > > > + vcpi->port, mst_state, > > > + avail_slots + vcpi->vcpi); > > > + ret = -ENOSPC; > > > + goto port_fail; > > > + } > > > + > > > + drm_dp_put_port(port); > > > + } > > > + DRM_DEBUG_ATOMIC("[MST MGR:%p] mst state %p VCPI avail=%d used=%d\n", > > > + mgr, mst_state, avail_slots, > > > + 63 - avail_slots); > > > +...

...pi; > > + if (avail_slots < 0) { > > + DRM_DEBUG_ATOMIC("[MST PORT:%p] not enough VCPI slots > > in mst state %p (avail=%d)\n", > > + vcpi->port, mst_state, > > + avail_slots + vcpi->vcpi); > > + ret = -ENOSPC; > > + goto port_fail; > > + } > > + > > + drm_dp_put_port(port); > > + } > > + DRM_DEBUG_ATOMIC("[MST MGR:%p] mst state %p VCPI avail=%d used=%d\n", > > + mgr, mst_state, avail_slots, > > + 63 - avail_slots); > > + > > + return 0; > > +port_f...

...cpi->vcpi; > > + if (avail_slots < 0) { > > + DRM_DEBUG_ATOMIC("[MST PORT:%p] not enough VCPI slots in mst state %p (avail=%d)\n", > > + vcpi->port, mst_state, > > + avail_slots + vcpi->vcpi); > > + ret = -ENOSPC; > > + goto port_fail; > > + } > > + > > + drm_dp_put_port(port); > > + } > > + DRM_DEBUG_ATOMIC("[MST MGR:%p] mst state %p VCPI avail=%d used=%d\n", > > + mgr, mst_state, avail_slots, > > + 63 - avail_slots); > > + > > + return 0; > > +port_f...

...t; + DRM_DEBUG_ATOMIC("[MST PORT:%p] not enough VCPI slots > > > > in mst state %p (avail=%d)\n", > > > > + vcpi->port, mst_state, > > > > + avail_slots + vcpi->vcpi); > > > > + ret = -ENOSPC; > > > > + goto port_fail; > > > > + } > > > > + > > > > + drm_dp_put_port(port); > > > > + } > > > > + DRM_DEBUG_ATOMIC("[MST MGR:%p] mst state %p VCPI avail=%d used=%d\n", > > > > + mgr, mst_state, avail_slots, > > > > +...