search for: poll_enqueu

Displaying 7 results from an estimated 7 matches for "poll_enqueu".

Did you mean: poll_enqueue
2013 Jul 22
3
[PATCH 06/10] virtio: console: fix race in port_fops_poll() and port unplug
...would be to remove the waitqueue (port->waitqueue = NULL in > unplug_port()), but I'm not sure of the effect on the other parts > yet. I'll leave this one for later analysis. No, you are confused by the name, I think, poll_wait() doesn't actually wait. It's more like a poll_enqueue(). Cheers, Rusty.
2013 Jul 22
3
[PATCH 06/10] virtio: console: fix race in port_fops_poll() and port unplug
...would be to remove the waitqueue (port->waitqueue = NULL in > unplug_port()), but I'm not sure of the effect on the other parts > yet. I'll leave this one for later analysis. No, you are confused by the name, I think, poll_wait() doesn't actually wait. It's more like a poll_enqueue(). Cheers, Rusty.
2013 Jul 23
1
[PATCH 06/10] virtio: console: fix race in port_fops_poll() and port unplug
...gt;waitqueue = NULL in >>> unplug_port()), but I'm not sure of the effect on the other parts >>> yet. I'll leave this one for later analysis. >> No, you are confused by the name, I think, >> >> poll_wait() doesn't actually wait. It's more like a poll_enqueue(). > > Yes, but the caller will wait then and since the wakeup was called > before adding into waitqueue. It may block forever? No, we enqueue then check: port = filp->private_data; poll_wait(filp, &port->waitqueue, wait); if (!port->guest_connected) { /* Port got unp...
2013 Jul 23
1
[PATCH 06/10] virtio: console: fix race in port_fops_poll() and port unplug
...gt;waitqueue = NULL in >>> unplug_port()), but I'm not sure of the effect on the other parts >>> yet. I'll leave this one for later analysis. >> No, you are confused by the name, I think, >> >> poll_wait() doesn't actually wait. It's more like a poll_enqueue(). > > Yes, but the caller will wait then and since the wakeup was called > before adding into waitqueue. It may block forever? No, we enqueue then check: port = filp->private_data; poll_wait(filp, &port->waitqueue, wait); if (!port->guest_connected) { /* Port got unp...
2013 Jul 23
0
[PATCH 06/10] virtio: console: fix race in port_fops_poll() and port unplug
...he waitqueue (port->waitqueue = NULL in >> unplug_port()), but I'm not sure of the effect on the other parts >> yet. I'll leave this one for later analysis. > No, you are confused by the name, I think, > > poll_wait() doesn't actually wait. It's more like a poll_enqueue(). Yes, but the caller will wait then and since the wakeup was called before adding into waitqueue. It may block forever? > > Cheers, > Rusty.
2013 Jul 19
2
[PATCH 06/10] virtio: console: fix race in port_fops_poll() and port unplug
On 07/19/2013 03:48 PM, Amit Shah wrote: > On (Fri) 19 Jul 2013 [15:03:50], Jason Wang wrote: >> On 07/19/2013 04:16 AM, Amit Shah wrote: >>> Between poll() being called and processed, the port can be unplugged. >>> Check if this happened, and bail out. >>> >>> Signed-off-by: Amit Shah <amit.shah at redhat.com> >>> --- >>>
2013 Jul 19
2
[PATCH 06/10] virtio: console: fix race in port_fops_poll() and port unplug
On 07/19/2013 03:48 PM, Amit Shah wrote: > On (Fri) 19 Jul 2013 [15:03:50], Jason Wang wrote: >> On 07/19/2013 04:16 AM, Amit Shah wrote: >>> Between poll() being called and processed, the port can be unplugged. >>> Check if this happened, and bail out. >>> >>> Signed-off-by: Amit Shah <amit.shah at redhat.com> >>> --- >>>