search for: pointerunion

I just switched gcc from 4.6.2 to 4.7.1 and see the massive amount of warnings, see few examples below. They mostly didn't exist with gcc-4.6.2. rev.159224 Yuri /usr/home/yuri/llvm-2012-06/latest-unpatched/llvm-fix/include/llvm/ADT/PointerUnion.h:56:10: warning: enumeral mismatch in conditional expression: ‘llvm::PointerLikeTypeTraits<llvm::PointerUnion<clang::FunctionTemplateDecl*, clang::MemberSpecializationInfo*> >::<anonymous enum>’ vs ‘llvm::PointerLikeTypeTraits<llvm::PointerUnion<clang::FunctionTemplateS...

...m> wrote: > I just switched gcc from 4.6.2 to 4.7.1 and see the massive amount of > warnings, see few examples below. > They mostly didn't exist with gcc-4.6.2. > > rev.159224 > > Yuri > > > /usr/home/yuri/llvm-2012-06/latest-unpatched/llvm-fix/include/llvm/ADT/PointerUnion.h:56:10: > warning: enumeral mismatch in conditional expression: > > ‘llvm::PointerLikeTypeTraits<llvm::PointerUnion<clang::FunctionTemplateDecl*, > clang::MemberSpecializationInfo*> >::<anonymous enum>’ vs > > ‘llvm::PointerLikeTypeTraits<llvm::PointerUnion&l...

...yfoad2/git/llvm-project/llvm/include/llvm/ADT/ArrayRef.h:12, from /home/jayfoad2/git/llvm-project/llvm/include/llvm/Support/SourceMgr.h:18, from /home/jayfoad2/git/llvm-project/llvm/lib/Support/SourceMgr.cpp:15: /home/jayfoad2/git/llvm-project/llvm/include/llvm/ADT/PointerUnion.h: In instantiation of ‘constexpr const int llvm::pointer_union_detail::PointerUnionUIntTraits<std::__debug::vector<unsigned char, std::allocator<unsigned char> >*, std::__debug::vector<short unsigned int, std::allocator<short unsigned int> >*, std::__debug::vector<uns...

.../ArrayRef.h:12, >> from >> /home/jayfoad2/git/llvm-project/llvm/include/llvm/Support/SourceMgr.h:18, >> from >> /home/jayfoad2/git/llvm-project/llvm/lib/Support/SourceMgr.cpp:15: >> /home/jayfoad2/git/llvm-project/llvm/include/llvm/ADT/PointerUnion.h: >> In instantiation of ‘constexpr const int >> llvm::pointer_union_detail::PointerUnionUIntTraits<std::__debug::vector<unsigned >> char, std::allocator<unsigned char> >*, std::__debug::vector<short >> unsigned int, std::allocator<short unsigned int&gt...

...from >> >> /home/jayfoad2/git/llvm-project/llvm/include/llvm/Support/SourceMgr.h:18, >> >> from >> >> /home/jayfoad2/git/llvm-project/llvm/lib/Support/SourceMgr.cpp:15: >> >> /home/jayfoad2/git/llvm-project/llvm/include/llvm/ADT/PointerUnion.h: >> >> In instantiation of ‘constexpr const int >> >> llvm::pointer_union_detail::PointerUnionUIntTraits<std::__debug::vector<unsigned >> >> char, std::allocator<unsigned char> >*, std::__debug::vector<short >> >> unsigned int, std...

...x/Signals.inc:481:1 #2 0x1f01653 SignalHandler(int) /usr/local/google/home/blaikie/dev/llvm/src/lib/Support/Unix/Signals.inc:198:60 #3 0x7f6893e22340 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x10340) #4 0x1ae3a9f bool llvm::DenseMapBase<llvm::SmallDenseMap<void*, std::pair<llvm::PointerUnion<llvm::MetadataAsValue*, llvm::Metadata*>, unsigned long>, 4u, llvm::DenseMapInfo<void*>, llvm::detail::DenseMapPair<void*, std::pair<llvm::PointerUnion<llvm::MetadataAsValue*, llvm::Metadata*>, unsigned long> > >, void*, std::pair<llvm::PointerUnion<llvm::M...

...ers. > > I hadn’t considered AssertVH, and I agree that losing it isn’t an option. > > Would it be possible to redesign AssertVH to be non-ABI fragile across debug/release builds? I haven’t looked at it recently, but maybe it could be a pointer to a CallbackVH in the debug mode, or a PointerUnion<rawpointer, callbackvh> or something. > > If you want methods to still be inlined in the non-assert case, you still have an ABI break in how you interpret the pointer... > I’m suggesting that AssertVH be redesigned: it could be a PointerUnion (in all build modes) and .o files whi...

...pp for Release+Asserts build /src/llvm-trunk-dev/include/llvm/ADT/PointerIntPair.h: In member function ‘const PointerTy* llvm::PointerIntPair<PointerTy, IntBits, IntType, PtrTraits>::getAddrOfPointer() const [with PointerTy = void*, unsigned int IntBits = 1u, IntType = bool, PtrTraits = llvm::PointerUnionUIntTraits<llvm::VNInfo*, llvm::SmallVector<llvm::VNInfo*, 4u>*>]’: /src/llvm-trunk-dev/include/llvm/ADT/PointerUnion.h:153: instantiated from ‘const PT1* llvm::PointerUnion<PT1, PT2>::getAddrOf() const [with T = llvm::VNInfo*, PT1 = llvm::VNInfo*, PT2 = llvm::SmallVector<llvm...

...library-level consumers. I hadn’t considered AssertVH, and I agree that losing it isn’t an option. Would it be possible to redesign AssertVH to be non-ABI fragile across debug/release builds? I haven’t looked at it recently, but maybe it could be a pointer to a CallbackVH in the debug mode, or a PointerUnion<rawpointer, callbackvh> or something. > We also have quite a few places in LLVM today that conserve memory usage in non-assert builds by removing unnecessary members of classes. We can say that this makes the ABI more fragile, but it is a valuable space optimization. Chris, are you saying...

for example /// getPointerUnionTypeNum - If the argument has type PT1* or PT2* return /// false or true respectively. template <typename PT1, typename PT2> static inline int getPointerUnionTypeNum(PT1 *P) { return 0; } template <typename PT1, typename PT2> static inline int getPointerUnionTypeNum(PT2 *P) { r...

...to the method I'm working on, is as follows: // signal handling... #4 0x00005556e48d6120 llvm::ReplaceableMetadataImpl::getOrCreate(llvm::Metadata&) (/home/sjessu/build-no-debug/bin/clang-10+0x2787120) #5 0x00005556e48db8c2 llvm::MetadataTracking::track(void*, llvm::Metadata&, llvm::PointerUnion<llvm::MetadataAsValue*, llvm::Metadata*>) (/home/sjessu/build-no-debug/bin/clang-10+0x278c8c2) #6 0x00005556e48dbc12 llvm::MDNode::MDNode(llvm::LLVMContext&, unsigned int, llvm::Metadata::StorageType, llvm::ArrayRef<llvm::Metadata*>, llvm::ArrayRef<llvm::Metadata*>) (/home/sj...

...Vector.h" #include "llvm/ADT/CachedHashString.h" #include "llvm/ADT/DenseSet.h" #include "llvm/ADT/IndexedMap.h" #include "llvm/ADT/IntEqClasses.h" #include "llvm/ADT/MapVector.h" #include "llvm/ADT/Optional.h" #include "llvm/ADT/PointerUnion.h" #include "llvm/ADT/STLExtras.h" #include "llvm/ADT/SetVector.h" #include "llvm/ADT/SmallPtrSet.h" #include "llvm/ADT/SmallSet.h" #include "llvm/ADT/SmallVector.h" #include "llvm/ADT/SparseBitVector.h" #include "llvm/ADT/Statis...

...;> // signal handling... >> #4 0x00005556e48d6120 >> llvm::ReplaceableMetadataImpl::getOrCreate(llvm::Metadata&) >> (/home/sjessu/build-no-debug/bin/clang-10+0x2787120) >> #5 0x00005556e48db8c2 llvm::MetadataTracking::track(void*, >> llvm::Metadata&, llvm::PointerUnion<llvm::MetadataAsValue*, >> llvm::Metadata*>) (/home/sjessu/build-no-debug/bin/clang-10+0x278c8c2) >> #6 0x00005556e48dbc12 llvm::MDNode::MDNode(llvm::LLVMContext&, unsigned >> int, llvm::Metadata::StorageType, llvm::ArrayRef<llvm::Metadata*>, >> llvm::ArrayR...

...g.h" >> #include "llvm/ADT/DenseSet.h" >> #include "llvm/ADT/IndexedMap.h" >> #include "llvm/ADT/IntEqClasses.h" >> #include "llvm/ADT/MapVector.h" >> #include "llvm/ADT/Optional.h" >> #include "llvm/ADT/PointerUnion.h" >> #include "llvm/ADT/STLExtras.h" >> #include "llvm/ADT/SetVector.h" >> #include "llvm/ADT/SmallPtrSet.h" >> #include "llvm/ADT/SmallSet.h" >> #include "llvm/ADT/SmallVector.h" >> #include "llvm/ADT/...

...DT/DenseSet.h" >>>> #include "llvm/ADT/IndexedMap.h" >>>> #include "llvm/ADT/IntEqClasses.h" >>>> #include "llvm/ADT/MapVector.h" >>>> #include "llvm/ADT/Optional.h" >>>> #include "llvm/ADT/PointerUnion.h" >>>> #include "llvm/ADT/STLExtras.h" >>>> #include "llvm/ADT/SetVector.h" >>>> #include "llvm/ADT/SmallPtrSet.h" >>>> #include "llvm/ADT/SmallSet.h" >>>> #include "llvm/ADT/SmallVector.h...

...0x000000010e61c549 SignalHandler(int) + 345 4 libsystem_platform.dylib 0x00007fff9d1a852a _sigtramp + 26 5 libsystem_platform.dylib 0x0000000000000003 _sigtramp + 1659206387 6 clang 0x000000010df459d6 llvm::MetadataTracking::track(void*, llvm::Metadata&, llvm::PointerUnion<llvm::MetadataAsValue*, llvm::Metadata*>) + 262 7 clang 0x000000010e1bcf50 llvm::MetadataTracking::track(llvm::Metadata*&) + 64 8 clang 0x000000010e1bcefa llvm::TrackingMDRef::track() + 42 9 clang 0x000000010e1bcec6 llvm::Trackin...

...llvm/ADT/CachedHashString.h" > #include "llvm/ADT/DenseSet.h" > #include "llvm/ADT/IndexedMap.h" > #include "llvm/ADT/IntEqClasses.h" > #include "llvm/ADT/MapVector.h" > #include "llvm/ADT/Optional.h" > #include "llvm/ADT/PointerUnion.h" > #include "llvm/ADT/STLExtras.h" > #include "llvm/ADT/SetVector.h" > #include "llvm/ADT/SmallPtrSet.h" > #include "llvm/ADT/SmallSet.h" > #include "llvm/ADT/SmallVector.h" > #include "llvm/ADT/SparseBitVector.h"...

...include "llvm/ADT/DenseSet.h" >>> #include "llvm/ADT/IndexedMap.h" >>> #include "llvm/ADT/IntEqClasses.h" >>> #include "llvm/ADT/MapVector.h" >>> #include "llvm/ADT/Optional.h" >>> #include "llvm/ADT/PointerUnion.h" >>> #include "llvm/ADT/STLExtras.h" >>> #include "llvm/ADT/SetVector.h" >>> #include "llvm/ADT/SmallPtrSet.h" >>> #include "llvm/ADT/SmallSet.h" >>> #include "llvm/ADT/SmallVector.h" >>>...

...DT/DenseSet.h" >>>> #include "llvm/ADT/IndexedMap.h" >>>> #include "llvm/ADT/IntEqClasses.h" >>>> #include "llvm/ADT/MapVector.h" >>>> #include "llvm/ADT/Optional.h" >>>> #include "llvm/ADT/PointerUnion.h" >>>> #include "llvm/ADT/STLExtras.h" >>>> #include "llvm/ADT/SetVector.h" >>>> #include "llvm/ADT/SmallPtrSet.h" >>>> #include "llvm/ADT/SmallSet.h" >>>> #include "llvm/ADT/SmallVector.h...

On Nov 11, 2013, at 12:09 PM, Alp Toker <alp at nuanti.com> wrote: >> Even when you have a !NDEBUG build, the platform assert() is pretty >> crummy on Windows and generates, at best a UTF-16 dump, or sometimes >> just pops up a dialog. WebKit and other projects take the same approach >> and define their own assertion macros to deal with this portably. >>