search for: pointertolinenumb

...t &> (Section->Symbol->Aux [0]) = Section->Header.SizeOfRawData; + reinterpret_cast <uint16_t &> (Section->Symbol->Aux [4]) = Section->Header.NumberOfRelocations; + reinterpret_cast <uint16_t &> (Section->Symbol->Aux [6]) = Section->Header.PointerToLineNumbers; This isn't endian-safe; I'd suggest expanding it to 8 assignments. Same issues with the write_le functions. We need endian safety not only so that cross-compiling, for example, from PPC Linux to MingW works, but also so that tests work cross-platform. 3. For the following bit: + t...

...->Aux.size () == 15); + write_uint32_le(Section->Symbol->Aux.data() + 0, Section->Header.SizeOfRawData); + write_uint16_le(Section->Symbol->Aux.data() + 4, Section->Header.NumberOfRelocations); + write_uint16_le(Section->Symbol->Aux.data() + 6, Section->Header.PointerToLineNumbers); ... + void add_common_symbol(MCSymbol *Symbol, uint64_t Size, unsigned ByteAlignment, bool External); Please wrap to 80 columns. + for (coff::relocations::const_iterator k = (*i)->Relocations.begin(); + k != (*i)->Relocations.end(...

Here is a full patch including Nathan's COFF support, tests that pass on Windows, and some changes to lit. Obviously the COFF support and changes to lit should be separate patches in the end. http://codereview.appspot.com/1624043/show - Michael Spencer -------------- next part -------------- A non-text attachment was scrubbed... Name: COFF-support.patch Type: application/octet-stream Size:

Hi guys, I have attached my patch to support generating win32 COFF object files. I would have posted earlier, but my system drive crashed and I had to rebuild my system; Luckily, my source code was on a secondary drive. I think this would be a good beginning for ongoing support of the COFF object file format and was hoping for some feedback as to whether it was commit worthy or what was needed to

...rite_uint32_le(Section->Symbol->Aux.data() + 0, Section- > >Header.SizeOfRawData); > + write_uint16_le(Section->Symbol->Aux.data() + 4, Section- > >Header.NumberOfRelocations); > + write_uint16_le(Section->Symbol->Aux.data() + 6, Section- > >Header.PointerToLineNumbers); > ... > + void add_common_symbol(MCSymbol *Symbol, uint64_t Size, > unsigned ByteAlignment, bool External); > > Please wrap to 80 columns. > > + for (coff::relocations::const_iterator k = (*i)- > >Relocations.begin(); > +...

...Symbol->Aux [0]) = > Section->Header.SizeOfRawData; > + reinterpret_cast <uint16_t &> (Section->Symbol->Aux [4]) = > Section->Header.NumberOfRelocations; > + reinterpret_cast <uint16_t &> (Section->Symbol->Aux [6]) = > Section->Header.PointerToLineNumbers; > > This isn't endian-safe; I'd suggest expanding it to 8 assignments. > Same issues with the write_le functions. We need endian safety not > only so that cross-compiling, for example, from PPC Linux to MingW > works, but also so that tests work cross-platform. > OK,...

...(Section->Symbol->Aux.data() + 0, >> Section->Header.SizeOfRawData); >> + write_uint16_le(Section->Symbol->Aux.data() + 4, >> Section->Header.NumberOfRelocations); >> + write_uint16_le(Section->Symbol->Aux.data() + 6, >> Section->Header.PointerToLineNumbers); >> ... >> + void add_common_symbol(MCSymbol *Symbol, uint64_t Size, unsigned >> ByteAlignment, bool External); >> >> Please wrap to 80 columns. >> >> + for (coff::relocations::const_iterator k = >> (*i)->Relocations.begin(); >>...