search for: po_ext_iterator

...stion would be: how do we mark the children iterator invalid before its first use. --snip-- I added two patches to this mail. The first one (dfi) is a proposal fixing the problem described in the cut-out above. The second one (poi) have to be applied anyway, as it fixes a compile bug rendering po_ext_iterator currently unusable. However this second issued occured as part of another problem: a child Stmt of a Stmt in a clang AST can be 0 (e.g. in for(;;)). I could work around it by providing po_ext_iterator an external set of visited nodes and just inserted 0 beforehand. However I'm quite sure it...

...t type is used by its superclass, po_iterator_storage. Default value of the set type is llvm::SmallPtrSet. This is correct, since po_iterator_storage::insertEdge expects that the set type provides an insert methods which returns a boolean value. Later three classes are derived from po_iterator -- po_ext_iterator, ipo_iterator, and ipo_ext_iterator -- however for these classes the default set type is std::set! This kind of set cannot be used with po_iterator because its insert method returns a std::pair, not a boolean. Thus, is a bug or a feature having std::set as default value of the template parameter?...

.... This does sound like a useful use-case, but I am uncomfortable with making DepthFirstIterator any heavier (by adding "CurrentTopNode" to it), is there another way to solve this problem? > The second one (poi) have to be applied anyway, as it fixes a > compile bug rendering po_ext_iterator currently unusable. Thanks, applied! http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20090706/080251.html -Chris