search for: pmladek

...fill completely after restore. This is because fill_balloon is only called once there. Calling fill_balloon repeatedly seems too aggressive, especially in light of the fact that it sleeps on failure: let's wake the config change handler and fill it asynchronously. Reported-by: Petr Mladek <pmladek at suse.com> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- I was unable to test this - for some reason my test VM doesn't resume (with or without the patch). Petr, does this work for you? drivers/virtio/virtio_balloon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(...

...fill completely after restore. This is because fill_balloon is only called once there. Calling fill_balloon repeatedly seems too aggressive, especially in light of the fact that it sleeps on failure: let's wake the config change handler and fill it asynchronously. Reported-by: Petr Mladek <pmladek at suse.com> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- I was unable to test this - for some reason my test VM doesn't resume (with or without the patch). Petr, does this work for you? drivers/virtio/virtio_balloon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(...

It has been long since I have sent v3 of the balloon conversion from a kthread to a workqueue. I have gained some more experience with the APIs in the meantime. I hope that you would like the outcome. I have added one more patch that fixes a separate problem with restoring the balloon after the system freeze. I have found this when testing the conversion. Changes against v3: + rebased on

It has been long since I have sent v3 of the balloon conversion from a kthread to a workqueue. I have gained some more experience with the APIs in the meantime. I hope that you would like the outcome. I have added one more patch that fixes a separate problem with restoring the balloon after the system freeze. I have found this when testing the conversion. Changes against v3: + rebased on

...stalling system resume - which is already a bug. > This patch adds the missing while cycle also into virtballoon_restore(). > Also it makes fill_balloon() to return the number of really modified > pages. Note that leak_balloon() already did this. > > Signed-off-by: Petr Mladek <pmladek at suse.com> This is a replacement for: virtio_balloon: Restore the entire balloon after the system freeze > --- > drivers/virtio/virtio_balloon.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/drivers/virtio/virtio_balloon.c b/drivers/vi...

...stalling system resume - which is already a bug. > This patch adds the missing while cycle also into virtballoon_restore(). > Also it makes fill_balloon() to return the number of really modified > pages. Note that leak_balloon() already did this. > > Signed-off-by: Petr Mladek <pmladek at suse.com> This is a replacement for: virtio_balloon: Restore the entire balloon after the system freeze > --- > drivers/virtio/virtio_balloon.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/drivers/virtio/virtio_balloon.c b/drivers/vi...

From: Petr Mladek <pmladek at suse.cz> This patch moves the deferred work from the "vballoon" kthread into a system freezable workqueue. We do not need to maintain and run a dedicated kthread. Also the event driven workqueues API makes the logic much easier. Especially, we do not longer need an own wait queue,...

On Thu, May 24, 2018 at 1:16 PM Steven Rostedt <rostedt at goodmis.org> wrote: > On Thu, 24 May 2018 13:40:24 +0200 > Petr Mladek <pmladek at suse.com> wrote: > > On Wed 2018-05-23 12:54:15, Thomas Garnier wrote: > > > When using -fPIE/PIC with function tracing, the compiler generates a > > > call through the GOT (call *__fentry__ at GOTPCREL). This instruction > > > takes 6 bytes instead of 5 on t...

On Fri, Dec 04, 2015 at 02:37:51PM +0100, Petr Mladek wrote: > From: Petr Mladek <pmladek at suse.cz> > > This patch moves the deferred work from the "vballoon" kthread into a > system freezable workqueue. > > We do not need to maintain and run a dedicated kthread. Also the event > driven workqueues API makes the logic much easier. Especially, we do >...

On Fri, Dec 04, 2015 at 02:37:51PM +0100, Petr Mladek wrote: > From: Petr Mladek <pmladek at suse.cz> > > This patch moves the deferred work from the "vballoon" kthread into a > system freezable workqueue. > > We do not need to maintain and run a dedicated kthread. Also the event > driven workqueues API makes the logic much easier. Especially, we do >...

On Wed 2018-05-23 12:54:15, Thomas Garnier wrote: > When using -fPIE/PIC with function tracing, the compiler generates a > call through the GOT (call *__fentry__ at GOTPCREL). This instruction > takes 6 bytes instead of 5 on the usual relative call. > > If PIE is enabled, replace the 6th byte of the GOT call by a 1-byte nop > so ftrace can handle the previous 5-bytes as before.

On Wed 2018-05-23 12:54:15, Thomas Garnier wrote: > When using -fPIE/PIC with function tracing, the compiler generates a > call through the GOT (call *__fentry__ at GOTPCREL). This instruction > takes 6 bytes instead of 5 on the usual relative call. > > If PIE is enabled, replace the 6th byte of the GOT call by a 1-byte nop > so ftrace can handle the previous 5-bytes as before.

...9.304135 | 4736.068459 | 4474.707822 | | Diff[%] | | 5.26 | -0.55 | ----------------------------------------------------- The 2nd way to create the workqueue has about the same results as kthread. This is why it is used in the patch. Signed-off-by: Petr Mladek <pmladek at suse.cz> --- drivers/virtio/virtio_balloon.c | 96 ++++++++++++++++++++--------------------- 1 file changed, 48 insertions(+), 48 deletions(-) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index 25ebe8eecdb7..a17f89ed3872 100644 --- a/drivers/virtio/virtio_b...

...9.304135 | 4736.068459 | 4474.707822 | | Diff[%] | | 5.26 | -0.55 | ----------------------------------------------------- The 2nd way to create the workqueue has about the same results as kthread. This is why it is used in the patch. Signed-off-by: Petr Mladek <pmladek at suse.cz> --- drivers/virtio/virtio_balloon.c | 96 ++++++++++++++++++++--------------------- 1 file changed, 48 insertions(+), 48 deletions(-) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index 25ebe8eecdb7..a17f89ed3872 100644 --- a/drivers/virtio/virtio_b...

...that most of the balloon stays leaked after the system freeze and restore. This patch adds the missing while cycle also into virtballoon_restore(). Also it makes fill_balloon() to return the number of really modified pages. Note that leak_balloon() already did this. Signed-off-by: Petr Mladek <pmladek at suse.com> --- drivers/virtio/virtio_balloon.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index 7efc32945810..d73a86db2490 100644 --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/v...

...tore. This is because fill_balloon is only called once there. > Calling fill_balloon repeatedly seems too aggressive, > especially in light of the fact that it sleeps on failure: let's > wake the config change handler and fill it asynchronously. > > Reported-by: Petr Mladek <pmladek at suse.com> > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > --- > > I was unable to test this - for some reason my test VM > doesn't resume (with or without the patch). > Petr, does this work for you? Ah, I have just realized that the problem happens only...

...ng these patches proved effective in consistently > switching heavily loaded vhost kthreads almost immediately. > > To: Josh Poimboeuf <jpoimboe at kernel.org> > To: Jiri Kosina <jikos at kernel.org> > To: Miroslav Benes <mbenes at suse.cz> > To: Petr Mladek <pmladek at suse.com> > To: Joe Lawrence <joe.lawrence at redhat.com> > To: "Michael S. Tsirkin" <mst at redhat.com> > To: Jason Wang <jasowang at redhat.com> > Cc: live-patching at vger.kernel.org > Cc: linux-kernel at vger.kernel.org > Cc: kvm at vger.kerne...

On Thu, 24 May 2018 13:40:24 +0200 Petr Mladek <pmladek at suse.com> wrote: > On Wed 2018-05-23 12:54:15, Thomas Garnier wrote: > > When using -fPIE/PIC with function tracing, the compiler generates a > > call through the GOT (call *__fentry__ at GOTPCREL). This instruction > > takes 6 bytes instead of 5 on the usual relative ca...

The previous version did not prevent updating the balloon when it was being removed. There was an idea to update the stats in a separate work and cancel it after the config reset. But this does not seem to work. The code for updating the stats communicates with the host. IMHO, it should not run after the reset (flushing buffers). Therefore I decided to use a boolean value and a spin lock (inspired

The previous version did not prevent updating the balloon when it was being removed. There was an idea to update the stats in a separate work and cancel it after the config reset. But this does not seem to work. The code for updating the stats communicates with the host. IMHO, it should not run after the reset (flushing buffers). Therefore I decided to use a boolean value and a spin lock (inspired