search for: plugsin

...02:25 AM, Richard W.M. Jones wrote: > I had an idea about how we might do this and still keep a single > .pwrite method for plugins. Maybe it's too complicated but here goes: > > > This is binary-compatible with old plugins, but not source compatible, so: > > > (2) Plugsin may optionally define NBDKIT_PLUGIN_LEVEL before including > <nbdkit-plugin.h>. Code wishing to use the flags variant of pwrite > can do: > > #define NBDKIT_PLUGIN_LEVEL 2 > #include <nbdkit-plugin.h> > > which would modify the definition of the struct (again), s...

...ndle, uint32_t count, uint64_t offset, int may_trim); int errno_is_preserved; void (*dump_plugin) (void); + int (*pwrite) (void *handle, const void *buf, uint32_t count, uint64_t offset, unsigned flags); This is binary-compatible with old plugins, but not source compatible, so: (2) Plugsin may optionally define NBDKIT_PLUGIN_LEVEL before including <nbdkit-plugin.h>. Code wishing to use the flags variant of pwrite can do: #define NBDKIT_PLUGIN_LEVEL 2 #include <nbdkit-plugin.h> which would modify the definition of the struct (again), something like: #ifndef NBDKIT_PLUG...

Tested via: term1$ qemu-nbd -k $PWD/sock -t -f raw -x foo junk --trace=nbd_\* term2$ ./nbdkit -f -v -e bar nbd socket=$PWD/sock export=foo term3$ qemu-io -t none -f raw nbd://localhost:10809/bar --trace=nbd_\* and checking the traces to see that 'w 0 1' vs. 'w -f 0 1' was able to influence whether the FUA flag showed up at the server in term1. Still to go: figure out how to