search for: plugin_script

...output_alloc output_conn *) let error_unless_nbdkit_python_plugin_working () = let cmd = sprintf "nbdkit %s %s --dump-plugin >/dev/null" - Python_script.python + nbdkit_python_plugin (quote (Python_script.path plugin_script)) in debug "%s" cmd; if Sys.command cmd <> 0 then error (f_"nbdkit %s plugin is not installed or not working. It is required if you want to use ‘-o rhv-upload’. See also the virt-v2v-output-rhv(1) manual.") - Python_script.python +...

...t_rhv_upload_precheck_source.code in > let vmcheck_script = > - Python_script.create ~name:"rhv-upload-vmcheck.py" > + Python_script.create ~name:"rhv-upload-vmcheck.py" ~tmpdir > Output_rhv_upload_vmcheck_source.code in > let plugin_script = > - Python_script.create ~name:"rhv-upload-plugin.py" > + Python_script.create ~name:"rhv-upload-plugin.py" ~tmpdir > Output_rhv_upload_plugin_source.code in > let createvm_script = > - Python_script.create ~name:"rhv-u...

Add an optional parameter for Python_script.create, to specific the temporary directory to use instead of creating a new one. --- v2v/python_script.ml | 13 ++++++++----- v2v/python_script.mli | 5 ++++- 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/v2v/python_script.ml b/v2v/python_script.ml index 3159373a1..6bb14ec1f 100644 --- a/v2v/python_script.ml +++

...Output_rhv_upload_precheck_source.code in let vmcheck_script = - Python_script.create ~name:"rhv-upload-vmcheck.py" + Python_script.create ~name:"rhv-upload-vmcheck.py" ~tmpdir Output_rhv_upload_vmcheck_source.code in let plugin_script = - Python_script.create ~name:"rhv-upload-plugin.py" + Python_script.create ~name:"rhv-upload-plugin.py" ~tmpdir Output_rhv_upload_plugin_source.code in let createvm_script = - Python_script.create ~name:"rhv-upload-createvm.py" +...

...~tmpdir in - let precheck_script = py_create ~name:"rhv-upload-precheck.py" - Output_rhv_upload_precheck_source.code in - let vmcheck_script = py_create ~name:"rhv-upload-vmcheck.py" - Output_rhv_upload_vmcheck_source.code in - let plugin_script = py_create ~name:"rhv-upload-plugin.py" - Output_rhv_upload_plugin_source.code in - let createvm_script = py_create ~name:"rhv-upload-createvm.py" - Output_rhv_upload_createvm_source.code in - let deletedisks_script = py_create ~nam...

v1 was here: https://www.redhat.com/archives/libguestfs/2020-April/msg00007.html There's a BZ for this now which I forgot to add to the commit message: https://bugzilla.redhat.com/show_bug.cgi?id=1814611 For v2: - Fix incorrect reference to $TMPDIR in existing manual. - Separate handling for small temporary files and large temporary files. Small temporary files go into $TMPDIR

...Python_script.create ~name:"rhv-upload-precheck.py" Output_rhv_upload_precheck_source.code in + let vmcheck_script = + Python_script.create ~name:"rhv-upload-vmcheck.py" + Output_rhv_upload_vmcheck_source.code in let plugin_script = Python_script.create ~name:"rhv-upload-plugin.py" Output_rhv_upload_plugin_source.code in @@ -226,6 +229,9 @@ object error_unless_nbdkit_working (); error_unless_nbdkit_python_plugin_working (); error_unless_output_alloc_sparse (); + (* P...

...c output_conn (* Create Python scripts for precheck, plugin and create VM. *) let precheck_script = Python_script.create ~name:"rhv-upload-precheck.py" + ~python:python_intepreter Output_rhv_upload_precheck_source.code in let plugin_script = Python_script.create ~name:"rhv-upload-plugin.py" + ~python:python_intepreter Output_rhv_upload_plugin_source.code in let createvm_script = Python_script.create ~name:"rhv-upload-createvm.py" +...

This adds a test of -o rhv-upload. Obviously for an upstream test we cannot require a working oVirt server. This test works by faking the ovirtsdk4 Python module, setting PYTHONPATH so that the fake module is picked up instead of the real module (if installed). However it's more complex than that because the nbdkit plugin also expects to talk to a working imageio HTTPS server. Therefore

...thout # modification, are permitted provided that the following conditions are @@ -31,34 +31,37 @@ include $(top_srcdir)/common-rules.mk -source = tar.pl +EXTRA_DIST = nbdkit-tar-plugin.pod -EXTRA_DIST = \ - $(source) \ - $(NULL) - -if HAVE_PERL +plugin_LTLIBRARIES = nbdkit-tar-plugin.la -plugin_SCRIPTS = nbdkit-tar-plugin -CLEANFILES += nbdkit-tar-plugin +nbdkit_tar_plugin_la_SOURCES = \ + tar.c \ + $(top_srcdir)/include/nbdkit-plugin.h \ + $(NULL) -# We have to do the rewriting here to avoid stupid exec_prefix. -nbdkit-tar-plugin: $(source) - rm -f $@ $@-t - sed 's,\@sbindir\@,${sbindir},...

For context see these threads: https://lists.gnu.org/archive/html/qemu-discuss/2020-06/threads.html#00053 https://lists.gnu.org/archive/html/qemu-block/2020-06/threads.html#01496 Rich.

v1 was here: https://www.redhat.com/archives/libguestfs/2018-September/msg00121.html v2: - Rewrote patch 2 from scratch so it incorporates Nir's suggestions. - Add fake module to EXTRA_DIST. - Retested. Unfortunately I am no longer able to test the ordinary conversion path because ovirtsdk4 is incompatible with Fedora 29 / Python 3.7:

This patch series fixes various issues in the rhv-upload output mode: - properly find and use RHV resources - cleanup orphan disks, and possibly the current disk transfer on failure In reality, the first 4 patches deal with resources, and the other 4 with cleanups. The latter block can be theoretically sent alone -- I just happened to start working on it as part of my "let's fix