search for: placespillsandrestores

...sicBlockName(MBB) << "\n"; + } + // DEBUG Code like this should also be inside ifndef NDEBUG. 3. It can still use more refactoring. :-) 4. clearSets(). It's not clear what sets it's clearing. Perhaps name it something like clearShrinkWrapData()? 5 +void PEI::placeSpillsAndRestores(MachineFunction &Fn) { + + DOUT << "Computing SAVE, RESTORE sets\n"; + + // If not shrink wrapping, all spills go into entry block, + // all restores in return blocks. + if (! ShrinkWrapping) { + // Do spills in the entry block. The shrink wrap version probably should go...

Here is an updated patch for shrink wrapping with: - spills/restores done with stack slot stores/loads - stack adjustment removed - refactoring (but still in need of more) - spill/restore insertion code unified with spill/restore placement code Documentation available here<http://wiki.github.com/jdmdj/llvm-work/shrink-wrapping-work> illustrates shrink wrapping with loops and discusses a

On Mon, Mar 2, 2009 at 10:35 AM, Evan Cheng <echeng at apple.com> wrote: > > On Mar 1, 2009, at 2:57 PM, John Mosby wrote: > > Obviously, all of this applies only when spills are done with push/pop, > which is the case on x86. I used this issue to start looking at generalizing > how spills and restores are handled, before looking too closely at other > targets, and

...ill use more refactoring. :-) > > 4. clearSets(). > It's not clear what sets it's clearing. Perhaps name it something like > clearShrinkWrapData()? > Agreed in toto, I will refactor further and try to get all remaining cleanups into the next patch. > 5 > +void PEI::placeSpillsAndRestores(MachineFunction &Fn) { > > > ... > > The shrink wrap version probably should go to its own function. Otherwise, > it should exit early when the non-shrink wrapping version is done. That > reduces nesting and please those of us who are a bit picky. > I originally wrote i...

...gt; 4.  clearSets(). >> It's not clear what sets it's clearing. Perhaps name it something like >> clearShrinkWrapData()? > > Agreed in toto, I will refactor further and try to get all remaining > cleanups into the next patch. > >> >> 5 >> +void PEI::placeSpillsAndRestores(MachineFunction &Fn) { >> >> >> ... >> The shrink wrap version probably should go to its own function. Otherwise, >> it should exit early when the non-shrink wrapping version is done. That >> reduces nesting and please those of us who are a bit picky. > &g...