Displaying 3 results from an estimated 3 matches for "pidvar".
Did you mean:
idvar
2018 Sep 11
2
Re: [PATCH nbdkit 4/4] tests: Add a helper function which waits for nbdkit to start up.
...ional.
I'm also seeing a common pattern of assigning pid=$(cat file.pid) right
after calling start_nbdkt. Would it be worth changing the signature of
start_nbdkit() to also populate a pid variable on success, as in:
start_nbdkit blocksize1.pid pid1 myarg1
start_nbdkit()
{
pidfile=$1
pidvar=$2
shift 2
...
pid=$(cat $pidfile)
eval $pidvar=$pid
which would also have the added benefit of avoiding the regression of
pid1 not being set if the second nbdkit process doesn't start?
But overall, I like the idea of refactoring the common code for less
repetition.
--
Eric Bl...
2018 Sep 11
0
Re: [PATCH nbdkit 4/4] tests: Add a helper function which waits for nbdkit to start up.
...f assigning pid=$(cat file.pid)
> right after calling start_nbdkt. Would it be worth changing the
> signature of start_nbdkit() to also populate a pid variable on
> success, as in:
>
> start_nbdkit blocksize1.pid pid1 myarg1
>
> start_nbdkit()
> {
> pidfile=$1
> pidvar=$2
> shift 2
> ...
> pid=$(cat $pidfile)
> eval $pidvar=$pid
It was nice that start_nbdkit has the same "signature" as
a regular nbdkit command.
> which would also have the added benefit of avoiding the regression
> of pid1 not being set if the second nbdkit pr...
2018 Sep 11
7
[PATCH nbdkit 0/4] tests: Move common functions into tests/functions.sh
Combine much common code into tests/functions.sh.
Patch 1: Preparation for patch 3.
Patch 2: Fix a long-standing bug in how man pages links are generated.
Patch 3: Common code for iterating a test function over every plugin.
Patch 4: Common code for starting nbdkit in a test and waiting for the
PID file to appear. This is the largest and most complex of
the patches but is