search for: phabriac

...>> >> I don't like the arcanist tool at all and we should have a documented >> manual way of committing code reviewed on Phabricator. >> >> # Long version >> >> The docs [2] to seem to suggest the **only correct way** (i.e. >> properly closes the phabriacator review) is to commit your change is >> via the arcanist command line tool. >> > > Interesting, I don't read it that way :) I personally don't use arc to > commit. > > >> I had/have several problems with the arcanist tool. >> >> * It is writte...

...came to actually committing code once it had been reviewed. # TL;DR I don't like the arcanist tool at all and we should have a documented manual way of committing code reviewed on Phabricator. # Long version The docs [2] to seem to suggest the **only correct way** (i.e. properly closes the phabriacator review) is to commit your change is via the arcanist command line tool. I had/have several problems with the arcanist tool. * It is written in PHP (provokes a knee-jerk "kill it with fire" reaction in me and likely others). IMHO not the most suitable language for writing a command...

...t;> >> I don't like the arcanist tool at all and we should have a documented >> manual way of committing code reviewed on Phabricator. >> >> # Long version >> >> The docs [2] to seem to suggest the **only correct way** (i.e. >> properly closes the phabriacator review) is to commit your change is >> via the arcanist command line tool. >> >> Interesting, I don't read it that way :) I personally don't use arc to commit. >> >> I had/have several problems with the arcanist tool. >> >> * It is written i...