search for: pep8

It turns out that a) the standalone pep8 executable is deprecated in favour of pycodestyle b) $python-pep8 does not exist in modern distros and thus the style checks for Python scripts have been skipped for a long time. Instead, switch to pycodestyle directly, updating the list of ignored issues to the two categories left. --- config.sh...

- wrap a too long line - join strings in multiple lines using + (plus) instead of \ (backslash) --- v2v/rhv-upload-plugin.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/v2v/rhv-upload-plugin.py b/v2v/rhv-upload-plugin.py index 4fad27fb8..bdc1e104a 100644 --- a/v2v/rhv-upload-plugin.py +++ b/v2v/rhv-upload-plugin.py @@ -86,7 +86,8 @@ def find_host(connection):

Fixes the majority of the pycodestyle issues in the Python scripts, and fix the existing test-v2v-python-syntax.sh to use pycodestyle to actually perform style checks. Pino Toscano (6): PEP 8: adapt whitespaces in lines PEP 8: move imports at the top PEP 8: adapt empty lines tests: find all the Python scripts for syntax checks -o rhv-upload: remove unused Python imports Revamp check

On Thu, 2017-02-09 at 10:53 +1100, Tom Robinson via samba wrote: > On 07/02/17 21:45, Tom Robinson via samba wrote: > > On 07/02/17 17:01, Andrew Bartlett via samba wrote: > > > On Tue, 2017-02-07 at 15:58 +1100, Tom Robinson via samba wrote: > > > > Hi, > > > > \ > > > > Next rid = 13001 > > > > krb5_init_context failed (Invalid

...ctags : build 'tags' file using ctags dist : makes a tarball for distribution distcheck : test that distribution tarball builds and installs distclean : removes the build directory etags : build TAGS file using etags install : installs the build files pep8 : run pep8 validator pydoctor : build python apidocs reconfigure : reconfigure if config scripts have changed test : Run the test suite (see test options below) testonly : run tests without doing a build first uninstall : removes the installed files wafdocs : b...

...str]], dict]: def inspect_get_drive_mappings(self, root: str) -> Union[List[Tuple[str, str]], dict]: def inspect_get_mountpoints(self, root: str) -> Union[List[Tuple[str, str]], dict]: In my opinion it is okay, pep8 complains about this and actually requires either: Option A def btrfs_subvolume_show(self, subvolume: str) -> Union[List[Tuple[str, str]], dict]: pass...

...using introspection to learn whether the plugin has a mandatory may_trim (old-style) or optional keywords (new style). But any such changes FIRST need to make sure I don't cause regressions, so beef up the testsuite to cover the zero call in the first place :) Eric Blake (3): python: Follow pep8 recommendations tests: Add coverage of zero in language bindings python: Test implementation of zero callback plugins/python/example.py | 10 ++++++++-- tests/python-exception.py | 4 ++++ tests/shebang.py | 5 ++++- tests/test-lang-plugins.c | 7 +++++++ tests/test.py...

Fix one dist issue, and almost all the builddir!=srcdir issues. (For the record, only 3 tests still fail in that setup.) Pino Toscano (3): libvirt-ocaml: add libvirt_c.h as source tests: fix path to sources of fake-virtio-win.iso tests: fix srcdir references bundled/libvirt-ocaml/Makefile.am | 1 + test-data/fake-virtio-win/Makefile.am | 2 +- tests/rhbz1232192.sh

On Thu, Feb 23, 2017 at 3:45 PM, Zhang Huangbin <zhb at iredmail.org> wrote: > > > On Feb 24, 2017, at 6:08 AM, Mark Moseley <moseleymark at gmail.com> wrote: > > > > * Do you use the perl poolmon script or something else? The perl script > was > > being weird for me, so I rewrote it in python but it basically does the > > exact same things. >

Seeing a build problem after updating my git tree: $ git remote -v origin git://git.samba.org/samba.git (fetch) origin git://git.samba.org/samba.git (push) $ git pull $ ./configure ... $ make clean WAF_MAKE=1 python ./buildtools/bin/waf build ./buildtools/wafsamba/samba_utils.py:397: DeprecationWarning: the md5 module is deprecated; use hashlib instead

...t;fsp_name. o Isaac Boukris <iboukris at gmail.com> * BUG 13571: CVE-2018-16853: Fix S4U2Self crash with MIT KDC build. o Günther Deschner <gd at samba.org> * BUG 13708: s3-vfs: Prevent NULL pointer dereference in vfs_glusterfs. o Joe Guo <joeg at catalyst.net.nz> * PEP8: fix E231: missing whitespace after ','. o Volker Lendecke <vl at samba.org> * BUG 13629: winbindd: Fix crash when taking profiles. o Stefan Metzmacher <metze at samba.org> * BUG 13600: CVE-2018-14629 dns: Fix CNAME loop prevention using counter regression. o Ga...

...t;fsp_name. o Isaac Boukris <iboukris at gmail.com> * BUG 13571: CVE-2018-16853: Fix S4U2Self crash with MIT KDC build. o Günther Deschner <gd at samba.org> * BUG 13708: s3-vfs: Prevent NULL pointer dereference in vfs_glusterfs. o Joe Guo <joeg at catalyst.net.nz> * PEP8: fix E231: missing whitespace after ','. o Volker Lendecke <vl at samba.org> * BUG 13629: winbindd: Fix crash when taking profiles. o Stefan Metzmacher <metze at samba.org> * BUG 13600: CVE-2018-14629 dns: Fix CNAME loop prevention using counter regression. o Ga...

...ld: The Samba AD DC, when build with MIT Kerberos is experimental o Tim Beale <timbeale at catalyst.net.nz> * BUG 13683: CVE-2018-16857: dsdb/util: Correctly treat lockOutObservationWindow as 64-bit int. o Joe Guo <joeg at catalyst.net.nz> * BUG 13683: CVE-2018-16857 PEP8: Fix E305: Expected 2 blank lines after class or function definition, found 1. o Aaron Haslett <aaronhaslett at catalyst.net.nz> * BUG 13600: CVE-2018-14629: dns: CNAME loop prevention using counter. o Gary Lockyer <gary at catalyst.net.nz> * BUG 13669: CVE-2018-16852: Fi...

...ld: The Samba AD DC, when build with MIT Kerberos is experimental o Tim Beale <timbeale at catalyst.net.nz> * BUG 13683: CVE-2018-16857: dsdb/util: Correctly treat lockOutObservationWindow as 64-bit int. o Joe Guo <joeg at catalyst.net.nz> * BUG 13683: CVE-2018-16857 PEP8: Fix E305: Expected 2 blank lines after class or function definition, found 1. o Aaron Haslett <aaronhaslett at catalyst.net.nz> * BUG 13600: CVE-2018-14629: dns: CNAME loop prevention using counter. o Gary Lockyer <gary at catalyst.net.nz> * BUG 13669: CVE-2018-16852: Fi...

Since support for python2 is dropped we can use the new python3 syntax for type hints. Signed-off-by: Sam Eiderman <sameid@google.com> --- generator/python.ml | 39 +++++++++++++++++++++++++++++++++++---- 1 file changed, 35 insertions(+), 4 deletions(-) diff --git a/generator/python.ml b/generator/python.ml index f0d6b5d96..3640ee39a 100644 --- a/generator/python.ml +++

Hi, this series cleans up the Python sources, either static or generated, including also tests, to make them PEP 8 compliant; see https://www.python.org/dev/peps/pep-0008/ and tools like pep8. Almost all the issues reported by pep8 are fixed, reducing the issues from 3818 to 7. The changes should have no effect on the actual code, while it will help Python users with consistency with other Python code. Thanks, Pino Toscano (8): python: PEP 8: adapt whitespaces in lines python: PE...

v7 was here: https://www.redhat.com/archives/libguestfs/2018-March/msg00143.html Since then: - Earlier patches are now upstream. - The to-do list is moved from the commit message to the TODO file. - This version forces -of raw + -oa sparse and gives an error in any other mode. We intend to lift these restrictions later. - Tested against latest imageio which supports longer timeouts,

...k. +files="rhv-upload-createvm.py rhv-upload-plugin.py rhv-upload-precheck.py" + +# Base version of Python. +python=python3 + +# Checks the files are syntactically correct, but not very much else. +for f in $files; do + $python -m py_compile $f +done + +# Checks the files correspond to PEP8 coding style. +# https://www.python.org/dev/peps/pep-0008/ +if $python-pep8 --version >/dev/null 2>&1; then + for f in $files; do + # Ignore: + # E226 missing whitespace around arithmetic operator + # E251 unexpected spaces around keyword / parameter equals +...

...k. +files="rhv-upload-createvm.py rhv-upload-plugin.py rhv-upload-precheck.py" + +# Base version of Python. +python=python3 + +# Checks the files are syntactically correct, but not very much else. +for f in $files; do + $python -m py_compile $f +done + +# Checks the files correspond to PEP8 coding style. +# https://www.python.org/dev/peps/pep-0008/ +if $python-pep8 --version >/dev/null 2>&1; then + for f in $files; do + # Ignore: + # E226 missing whitespace around arithmetic operator + # E251 unexpected spaces around keyword / parameter equals +...

v8 was here: https://www.redhat.com/archives/libguestfs/2018-April/msg00022.html v8 -> v9: - Addresses the only feedback from Tomáš. Rich.