search for: pclose

If either zcat or cpio fails when spawned in initrd-list, pclose will return the actual return value of it, but reply_with_perror still uses errno regardless; thus, the reported error is: libguestfs: error: initrd_list: pclose: Success which is not much helpful. Instead, when pclose returns > 0, extract the actual return value of the subprocess, and prin...

...) * this there is no opportunity in the protocol to send any error * message back. Instead we can only cancel the transfer. */ - reply (NULL, NULL); + reply(NULL, NULL); + + while ((r = fread(buffer, 1, sizeof buffer, fp)) > 0) + if (send_file_write(buffer, r) < 0) { + pclose(fp); - while ((r = fread (buffer, 1, sizeof buffer, fp)) > 0) { - if (send_file_write (buffer, r) < 0) { - pclose (fp); return -1; } - } - if (ferror (fp)) { - fprintf (stderr, "fread: %m"); - send_file_end (1); /* Cancel. */ - pclose (fp); + if (...

...le contents. After + * this there is no opportunity in the protocol to send any error + * message back. Instead we can only cancel the transfer. + */ + reply (NULL, NULL); + + while ((r = fread (buffer, 1, sizeof buffer, fp)) > 0) { + if (send_file_write (buffer, r) < 0) { + pclose (fp); + return -1; + } + } + + if (ferror (fp)) { + fprintf (stderr, "fread: %ld: %m\n", inode); + send_file_end (1); /* Cancel. */ + pclose (fp); + return -1; + } + + if (pclose (fp) != 0) { + fprintf (stderr, "pclose: %ld: %m\n", inode); + send_f...

...mporarily unavailable) making the system unusable and probably skipping documents. I'm using MAC Osx Server 10.4.3 (Darwin/BSD) and GCC 4.0. The problem: On function stdout_to_string a popen is called, but is not closed properly (according the popen manual) because is using fclose instead of pclose and hence processes created by popen are not killed. Solution: Omindex.cc line 201, replace fclose by pclose : If (pclose(sh) == -1) throw read ReadError(); This must correct the problem, I'm not sure if will cause the same error in other platforms or UNIX. Cheers

Dear all, When I compared the performance of some application on both a Xen domU and a standard linux machine (where domU runs on a similar physical mahine), I notice the application runs faster on the domU than on the physical machine. Instrumenting the application code shows the application spends more time on popen() calls on domU than on the physical machine. I wonder if xenlinux does some

...le contents. After + * this there is no opportunity in the protocol to send any error + * message back. Instead we can only cancel the transfer. + */ + reply (NULL, NULL); + + while ((r = fread (buffer, 1, sizeof buffer, fp)) > 0) { + if (send_file_write (buffer, r) < 0) { + pclose (fp); + return -1; + } + } + + if (ferror (fp)) { + fprintf (stderr, "fread: %m"); + send_file_end (1); /* Cancel. */ + pclose (fp); + return -1; + } + + if (pclose (fp) != 0) { + fprintf (stderr, "pclose: %m"); + send_file_end (1); /* Cancel. */...

...rotocol to send any error >> + * message back. Instead we can only cancel the transfer. >> + */ >> + reply (NULL, NULL); >> + >> + while ((r = fread (buffer, 1, sizeof buffer, fp)) > 0) { >> + if (send_file_write (buffer, r) < 0) { >> + pclose (fp); >> + return -1; >> + } >> + } >> + >> + if (ferror (fp)) { >> + fprintf (stderr, "fread: %ld: %m\n", inode); >> + send_file_end (1); /* Cancel. */ >> + pclose (fp); >> + return -1; >> + } >> +...

"icat" name comes from the employed command line tool which might be replaced later on with a different implementation. The command name is a bit confusing because it's similar to "cat" but act as "donwload". Therefore I am renaming it with a more clear name. At the same time I cleaned up a bit the code and improved it's readability and code comments. This

...1; } @@ -311,14 +311,14 @@ do_ntfscat_i (const mountable_t *mountable, int64_t inode) } if (ferror (fp)) { - fprintf (stderr, "fread: %ld: %m\n", inode); + fprintf (stderr, "fread: %" PRIi64 ": %m\n", inode); send_file_end (1); /* Cancel. */ pclose (fp); return -1; } if (pclose (fp) != 0) { - fprintf (stderr, "pclose: %ld: %m\n", inode); + fprintf (stderr, "pclose: %" PRIi64 ": %m\n", inode); send_file_end (1); /* Cancel. */ return -1; } -- 2.5.0

...e is no opportunity in the protocol to send any error > + * message back. Instead we can only cancel the transfer. > + */ > + reply (NULL, NULL); > + > + while ((r = fread (buffer, 1, sizeof buffer, fp)) > 0) { > + if (send_file_write (buffer, r) < 0) { > + pclose (fp); > + return -1; > + } > + } > + > + if (ferror (fp)) { > + fprintf (stderr, "fread: %ld: %m\n", inode); > + send_file_end (1); /* Cancel. */ > + pclose (fp); > + return -1; > + } > + > + if (pclose (fp) != 0) { > + fp...

...le contents. After + * this there is no opportunity in the protocol to send any error + * message back. Instead we can only cancel the transfer. + */ + reply (NULL, NULL); + + while ((r = fread (buffer, 1, sizeof buffer, fp)) > 0) { + if (send_file_write (buffer, r) < 0) { + pclose (fp); + return -1; + } + } + + if (ferror (fp)) { + fprintf (stderr, "fread: %m"); + send_file_end (1); /* Cancel. */ + pclose (fp); + return -1; + } + + if (pclose (fp) != 0) { + fprintf (stderr, "pclose: %m"); + send_file_end (1); /* Cancel. */...

...t; >>+ * message back. Instead we can only cancel the transfer. > >>+ */ > >>+ reply (NULL, NULL); > >>+ > >>+ while ((r = fread (buffer, 1, sizeof buffer, fp)) > 0) { > >>+ if (send_file_write (buffer, r) < 0) { > >>+ pclose (fp); > >>+ return -1; > >>+ } > >>+ } > >>+ > >>+ if (ferror (fp)) { > >>+ fprintf (stderr, "fread: %ld: %m\n", inode); > >>+ send_file_end (1); /* Cancel. */ > >>+ pclose (fp); > >>+...

...le contents. After + * this there is no opportunity in the protocol to send any error + * message back. Instead we can only cancel the transfer. + */ + reply (NULL, NULL); + + while ((r = fread (buffer, 1, sizeof buffer, fp)) > 0) { + if (send_file_write (buffer, r) < 0) { + pclose (fp); + return -1; + } + } + + if (ferror (fp)) { + fprintf (stderr, "fread: %m"); + send_file_end (1); /* Cancel. */ + pclose (fp); + return -1; + } + + if (pclose (fp) != 0) { + fprintf (stderr, "pclose: %m"); + send_file_end (1); /* Cancel. */...

Hi, the two patches improve the way memory is handled in supermin, by cleanly exiting on memory allocation failures, and free'ing memory when not needed (to keep working and not run out of memory). Pino Toscano (2): Check for failures in memory allocations Free memory buffers when not used src/ext2fs-c.c | 13 +++++++++++-- src/init.c | 13 +++++++++++++ 2 files changed, 24

...is is the error from the SMF logs: [ Apr 16 08:41:22 Executing start method ("/lib/svc/method/nfs-server start") ] [ Apr 16 08:41:24 Method "start" exited with status 0 ] [ Apr 18 10:59:23 Executing start method ("/lib/svc/method/nfs-server start") ] Assertion failed: pclose(fp) == 0, file ../common/libzfs_mount.c, line 380, function zfs_share If I re-enable nfs/server after the system is up it''s fine. The system was recently upgraded to use zfs and this has happened on the last two reboots. We have lots of other systems that share nfs through zfs fine and...

The command name is a bit confusing because it's similar to "cat" but act as "donwload". Therefore I am renaming it with a more clear name. At the same go I cleaned up a bit the code following the standards and improved the API documentation. This patch is ready for review. Code available at: https://github.com/noxdafox/libguestfs/tree/download_inode Matteo Cafasso (3):

...le contents. After + * this there is no opportunity in the protocol to send any error + * message back. Instead we can only cancel the transfer. + */ + reply (NULL, NULL); + + while ((r = fread (buffer, 1, sizeof buffer, fp)) > 0) { + if (send_file_write (buffer, r) < 0) { + pclose (fp); + return -1; + } + } + + if (ferror (fp)) { + fprintf (stderr, "fread: %ld: %m\n", inode); + send_file_end (1); /* Cancel. */ + pclose (fp); + return -1; + } + + if (pclose (fp) != 0) { + fprintf (stderr, "pclose: %ld: %m\n", inode); + send_f...

...back. Instead we can only cancel the transfer. >>>> + */ >>>> + reply (NULL, NULL); >>>> + >>>> + while ((r = fread (buffer, 1, sizeof buffer, fp)) > 0) { >>>> + if (send_file_write (buffer, r) < 0) { >>>> + pclose (fp); >>>> + return -1; >>>> + } >>>> + } >>>> + >>>> + if (ferror (fp)) { >>>> + fprintf (stderr, "fread: %ld: %m\n", inode); >>>> + send_file_end (1); /* Cancel. */ >>>> +...

...5K /export/home # zpool list NAME SIZE USED AVAIL CAP HEALTH ALTROOT SYS 195M 90K 195M 0% ONLINE - export 74G 114K 74.0G 0% ONLINE - # zfs set sharenfs=on export # zfs share export Assertion failed: pclose(fp) == 0, file ../common/libzfs_mount.c, line 399, function zfs_share Abort - core dumped

The Sleuth Kit is a filesystem forensic tool for accessing disk volumes and extracting digital evidence from. http://www.sleuthkit.org/ The icat API allows to download a file from a device given its metadata number (inode). It supports multiple filesystem types. The icat command allows to access to otherwise unreachable files such as filesystem data structures and deleted files which content is