search for: pcleaned

...w patch much better than the old one. Teaching the (abstract) ConstantValue class about jumptable indices is a little bit ugly but I do not see any better solution without massive refactoring. I have added TODOs here and elsewhere and plan to address them in future patches. I also added a test and pcleaned up a few things. The new patch is attached. I also uploaded it to http://codereview.appspot.com/96065/show which is more convenient for browsing. (you will have to register with an arbitrary pair of email address and password --if you have a gmail account you can use that) Cheers, Robert &gt...

...; Teaching the (abstract) ConstantValue class about jumptable indices > is a little > bit ugly but I do not see any better solution without massive > refactoring. > I have added TODOs here and elsewhere and plan to address them in > future > patches. I also added a test and pcleaned up a few things. Maybe I'm missing something but it looks like this is basically the same as the sample code that I sent back to you. Aside from the TODO comments, it looks like all you changed was to move the new code in BranchFolding into a new UpdateLiveSetUsingConstantPoolAndMapInd...

On Jul 2, 2009, at 10:48 AM, robert muth wrote: > I spend over a day trying to follow your suggestion. In the end I > was not successful. Here is what Iearned: > > After setting > > ARMJITInfo::hasCustomJumpTables -> true > setOperationAction for ISD::BR_JT -> Expand > > I needed to add a "brind" definition to ARMInstrInfo.td > I picked

On Thu, Jun 25, 2009 at 6:17 PM, Bob Wilson <bob.wilson at apple.com> wrote: > Hi Robert, > Evan asked me to review this patch, and I have some questions about it. I > apologize for not following the discussion earlier and for hitting you with > questions after you've already gone through several revisions. > > LLVM provides some default behavior for handling jump