search for: pci_sriov_configure_simple

...> > > + return -EBUSY; >> > > > > + >> > > > > + if (!__virtio_test_bit(vdev, VIRTIO_F_SR_IOV)) >> > > > > + return -EINVAL; >> > > > > + >> > > > > + sriov_configure = pci_sriov_configure_simple; >> > > > > + if (sriov_configure == NULL) >> > > > > + return -ENOENT; >> > > > >> > > > BTW what is all this trickery in aid of? >> > > >> > > When SR-IOV support is not compiled into the ker...

...>> + if (!(vdev->config->get_status(vdev) & VIRTIO_CONFIG_S_DRIVER_OK)) >>>> + return -EBUSY; >>>> + >>>> + if (!__virtio_test_bit(vdev, VIRTIO_F_SR_IOV)) >>>> + return -EINVAL; >>>> + >>>> + sriov_configure = pci_sriov_configure_simple; >>>> + if (sriov_configure == NULL) >>>> + return -ENOENT; >>> >>> BTW what is all this trickery in aid of? >> >> When SR-IOV support is not compiled into the kernel, >> pci_sriov_configure_simple is #defined as NULL. This allows it to c...

...>> + if (!(vdev->config->get_status(vdev) & VIRTIO_CONFIG_S_DRIVER_OK)) >>>> + return -EBUSY; >>>> + >>>> + if (!__virtio_test_bit(vdev, VIRTIO_F_SR_IOV)) >>>> + return -EINVAL; >>>> + >>>> + sriov_configure = pci_sriov_configure_simple; >>>> + if (sriov_configure == NULL) >>>> + return -ENOENT; >>> >>> BTW what is all this trickery in aid of? >> >> When SR-IOV support is not compiled into the kernel, >> pci_sriov_configure_simple is #defined as NULL. This allows it to c...

...ruct pci_dev *pci_dev, int num_vfs); >> + >> + if (!(vdev->config->get_status(vdev) & VIRTIO_CONFIG_S_DRIVER_OK)) >> + return -EBUSY; >> + >> + if (!__virtio_test_bit(vdev, VIRTIO_F_SR_IOV)) >> + return -EINVAL; >> + >> + sriov_configure = pci_sriov_configure_simple; >> + if (sriov_configure == NULL) >> + return -ENOENT; > > BTW what is all this trickery in aid of? When SR-IOV support is not compiled into the kernel, pci_sriov_configure_simple is #defined as NULL. This allows it to compile in that case, even though there is utterly no w...

...ruct pci_dev *pci_dev, int num_vfs); >> + >> + if (!(vdev->config->get_status(vdev) & VIRTIO_CONFIG_S_DRIVER_OK)) >> + return -EBUSY; >> + >> + if (!__virtio_test_bit(vdev, VIRTIO_F_SR_IOV)) >> + return -EINVAL; >> + >> + sriov_configure = pci_sriov_configure_simple; >> + if (sriov_configure == NULL) >> + return -ENOENT; > > BTW what is all this trickery in aid of? When SR-IOV support is not compiled into the kernel, pci_sriov_configure_simple is #defined as NULL. This allows it to compile in that case, even though there is utterly no w...

...vdev) & VIRTIO_CONFIG_S_DRIVER_OK)) > > > > > + return -EBUSY; > > > > > + > > > > > + if (!__virtio_test_bit(vdev, VIRTIO_F_SR_IOV)) > > > > > + return -EINVAL; > > > > > + > > > > > + sriov_configure = pci_sriov_configure_simple; > > > > > + if (sriov_configure == NULL) > > > > > + return -ENOENT; > > > > > > > > BTW what is all this trickery in aid of? > > > > > > When SR-IOV support is not compiled into the kernel, > > > pci_sriov_configu...

...virtio_device *vdev = &vp_dev->vdev; + int (*sriov_configure)(struct pci_dev *pci_dev, int num_vfs); + + if (!(vdev->config->get_status(vdev) & VIRTIO_CONFIG_S_DRIVER_OK)) + return -EBUSY; + + if (!__virtio_test_bit(vdev, VIRTIO_F_SR_IOV)) + return -EINVAL; + + sriov_configure = pci_sriov_configure_simple; + if (sriov_configure == NULL) + return -ENOENT; + + return sriov_configure(pci_dev, num_vfs); +} + static struct pci_driver virtio_pci_driver = { .name = "virtio-pci", .id_table = virtio_pci_id_table, @@ -596,6 +615,7 @@ static struct pci_driver virtio_pci_driver = { #ifdef CONF...

...virtio_device *vdev = &vp_dev->vdev; + int (*sriov_configure)(struct pci_dev *pci_dev, int num_vfs); + + if (!(vdev->config->get_status(vdev) & VIRTIO_CONFIG_S_DRIVER_OK)) + return -EBUSY; + + if (!__virtio_test_bit(vdev, VIRTIO_F_SR_IOV)) + return -EINVAL; + + sriov_configure = pci_sriov_configure_simple; + if (sriov_configure == NULL) + return -ENOENT; + + return sriov_configure(pci_dev, num_vfs); +} + static struct pci_driver virtio_pci_driver = { .name = "virtio-pci", .id_table = virtio_pci_id_table, @@ -596,6 +615,7 @@ static struct pci_driver virtio_pci_driver = { #ifdef CONF...

...gt; + > > > + if (!(vdev->config->get_status(vdev) & VIRTIO_CONFIG_S_DRIVER_OK)) > > > + return -EBUSY; > > > + > > > + if (!__virtio_test_bit(vdev, VIRTIO_F_SR_IOV)) > > > + return -EINVAL; > > > + > > > + sriov_configure = pci_sriov_configure_simple; > > > + if (sriov_configure == NULL) > > > + return -ENOENT; > > > > BTW what is all this trickery in aid of? > > When SR-IOV support is not compiled into the kernel, > pci_sriov_configure_simple is #defined as NULL. This allows it to compile > in t...

...es the support for this feature bit in virtio driver. Signed-off-by: Tiwei Bie <tiwei.bie at intel.com> Acked-by: Stefan Hajnoczi <stefanha at redhat.com> Acked-by: Michael S. Tsirkin <mst at redhat.com> --- v2: - Disable VFs when unbinding the driver (Alex, MST); - Don't use pci_sriov_configure_simple (Alex); drivers/virtio/virtio_pci_common.c | 30 ++++++++++++++++++++++++++++++ drivers/virtio/virtio_pci_modern.c | 14 ++++++++++++++ include/uapi/linux/virtio_config.h | 7 ++++++- 3 files changed, 50 insertions(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_pci_common.c b/drivers/virt...

...es the support for this feature bit in virtio driver. Signed-off-by: Tiwei Bie <tiwei.bie at intel.com> Acked-by: Stefan Hajnoczi <stefanha at redhat.com> Acked-by: Michael S. Tsirkin <mst at redhat.com> --- v2: - Disable VFs when unbinding the driver (Alex, MST); - Don't use pci_sriov_configure_simple (Alex); drivers/virtio/virtio_pci_common.c | 30 ++++++++++++++++++++++++++++++ drivers/virtio/virtio_pci_modern.c | 14 ++++++++++++++ include/uapi/linux/virtio_config.h | 7 ++++++- 3 files changed, 50 insertions(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_pci_common.c b/drivers/virt...

...I/O Virtualization): https://github.com/oasis-tcs/virtio-spec/issues/11 This patch enables the support for this feature bit in virtio driver. Signed-off-by: Tiwei Bie <tiwei.bie at intel.com> --- v3: - Drop the acks; v2: - Disable VFs when unbinding the driver (Alex, MST); - Don't use pci_sriov_configure_simple (Alex); drivers/virtio/virtio_pci_common.c | 30 ++++++++++++++++++++++++++++++ drivers/virtio/virtio_pci_modern.c | 14 ++++++++++++++ include/uapi/linux/virtio_config.h | 7 ++++++- 3 files changed, 50 insertions(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_pci_common.c b/drivers/virt...

...I/O Virtualization): https://github.com/oasis-tcs/virtio-spec/issues/11 This patch enables the support for this feature bit in virtio driver. Signed-off-by: Tiwei Bie <tiwei.bie at intel.com> --- v3: - Drop the acks; v2: - Disable VFs when unbinding the driver (Alex, MST); - Don't use pci_sriov_configure_simple (Alex); drivers/virtio/virtio_pci_common.c | 30 ++++++++++++++++++++++++++++++ drivers/virtio/virtio_pci_modern.c | 14 ++++++++++++++ include/uapi/linux/virtio_config.h | 7 ++++++- 3 files changed, 50 insertions(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_pci_common.c b/drivers/virt...

...t; to have something like this? Sorry, currently I don't have anything like this.. Best regards, Tiwei Bie > > Thanks, > > > > v3: > > - Drop the acks; > > > > v2: > > - Disable VFs when unbinding the driver (Alex, MST); > > - Don't use pci_sriov_configure_simple (Alex); > > > > drivers/virtio/virtio_pci_common.c | 30 ++++++++++++++++++++++++++++++ > > drivers/virtio/virtio_pci_modern.c | 14 ++++++++++++++ > > include/uapi/linux/virtio_config.h | 7 ++++++- > > 3 files changed, 50 insertions(+), 1 deletion(-) > > &g...

...ie > > > > > > > > Thanks, > > > > > > > > > > v3: > > > > - Drop the acks; > > > > > > > > v2: > > > > - Disable VFs when unbinding the driver (Alex, MST); > > > > - Don't use pci_sriov_configure_simple (Alex); > > > > > > > > drivers/virtio/virtio_pci_common.c | 30 ++++++++++++++++++++++++++++++ > > > > drivers/virtio/virtio_pci_modern.c | 14 ++++++++++++++ > > > > include/uapi/linux/virtio_config.h | 7 ++++++- > > > > 3 files chan...

...gt; > > > > > > > > > > v3: > > > > > > - Drop the acks; > > > > > > > > > > > > v2: > > > > > > - Disable VFs when unbinding the driver (Alex, MST); > > > > > > - Don't use pci_sriov_configure_simple (Alex); > > > > > > > > > > > > drivers/virtio/virtio_pci_common.c | 30 ++++++++++++++++++++++++++++++ > > > > > > drivers/virtio/virtio_pci_modern.c | 14 ++++++++++++++ > > > > > > include/uapi/linux/virtio_config.h | 7 +...

...> + int (*sriov_configure)(struct pci_dev *pci_dev, int num_vfs); > + > + if (!(vdev->config->get_status(vdev) & VIRTIO_CONFIG_S_DRIVER_OK)) > + return -EBUSY; > + > + if (!__virtio_test_bit(vdev, VIRTIO_F_SR_IOV)) > + return -EINVAL; > + > + sriov_configure = pci_sriov_configure_simple; > + if (sriov_configure == NULL) > + return -ENOENT; BTW what is all this trickery in aid of? > + > + return sriov_configure(pci_dev, num_vfs); > +} > + > static struct pci_driver virtio_pci_driver = { > .name = "virtio-pci", > .id_table = virtio_pci_i...

...*pci_dev, int num_vfs); > + > + if (!(vdev->config->get_status(vdev) & VIRTIO_CONFIG_S_DRIVER_OK)) > + return -EBUSY; > + > + if (!__virtio_test_bit(vdev, VIRTIO_F_SR_IOV)) > + return -EINVAL; > + > + sriov_configure = pci_sriov_configure_simple; > + if (sriov_configure == NULL) > + return -ENOENT; > + > + return sriov_configure(pci_dev, num_vfs); > +} > + > static struct pci_driver virtio_pci_driver = { > .name = "virtio-pci", > .id_table = vir...

...t; Acked-by: Michael S. Tsirkin <mst at redhat.com> > --- Generally you aren't supposed to carry forward acks when you make major changes. In this case I'm fine with the patch, so never mind. > v2: > - Disable VFs when unbinding the driver (Alex, MST); > - Don't use pci_sriov_configure_simple (Alex); > > drivers/virtio/virtio_pci_common.c | 30 ++++++++++++++++++++++++++++++ > drivers/virtio/virtio_pci_modern.c | 14 ++++++++++++++ > include/uapi/linux/virtio_config.h | 7 ++++++- > 3 files changed, 50 insertions(+), 1 deletion(-) > > diff --git a/drivers/virtio...

...sriov for us. I wish there was a patch emulating this without vDPA for QEMU, would make it easy to test your patches. Do you happen to have something like this? Thanks, > v3: > - Drop the acks; > > v2: > - Disable VFs when unbinding the driver (Alex, MST); > - Don't use pci_sriov_configure_simple (Alex); > > drivers/virtio/virtio_pci_common.c | 30 ++++++++++++++++++++++++++++++ > drivers/virtio/virtio_pci_modern.c | 14 ++++++++++++++ > include/uapi/linux/virtio_config.h | 7 ++++++- > 3 files changed, 50 insertions(+), 1 deletion(-) > > diff --git a/drivers/virtio...