search for: pci_pm_runtime_resume

...2: 000000edb16580b8 CR3: 000000020cc09000 CR4: 00000000003406f0 > [ 12.768193] Call Trace: > [ 12.768198] ? enqueue_task_fair+0x64/0x600 > [ 12.768211] ? drm_get_last_vbltimestamp+0x47/0x70 [drm] > [ 12.768223] ? drm_update_vblank_count+0x65/0x240 [drm] > [ 12.768227] ? pci_pm_runtime_resume+0xa0/0xa0 > [ 12.768238] ? drm_vblank_disable_and_save+0x55/0xc0 [drm] > [ 12.768250] ? drm_crtc_vblank_off+0xa9/0x1e0 [drm] > [ 12.768253] ? pci_pm_runtime_resume+0xa0/0xa0 > [ 12.768299] ? nouveau_display_fini+0x56/0xd0 [nouveau] > [ 12.768339] ? nouveau_display_susp...

...0 CR4: 00000000003406f0 >>> [ 12.768193] Call Trace: >>> [ 12.768198] ? enqueue_task_fair+0x64/0x600 >>> [ 12.768211] ? drm_get_last_vbltimestamp+0x47/0x70 [drm] >>> [ 12.768223] ? drm_update_vblank_count+0x65/0x240 [drm] >>> [ 12.768227] ? pci_pm_runtime_resume+0xa0/0xa0 >>> [ 12.768238] ? drm_vblank_disable_and_save+0x55/0xc0 [drm] >>> [ 12.768250] ? drm_crtc_vblank_off+0xa9/0x1e0 [drm] >>> [ 12.768253] ? pci_pm_runtime_resume+0xa0/0xa0 >>> [ 12.768299] ? nouveau_display_fini+0x56/0xd0 [nouveau] >>&gt...

...[ 1730.734356] ttm_mem_evict_first+0x157/0x1b0 [ttm] [ 1730.734358] ttm_bo_force_list_clean+0x6b/0x110 [ttm] [ 1730.734360] ttm_bo_evict_mm+0x26/0x50 [ttm] [ 1730.734375] nouveau_do_suspend+0xa9/0x1d0 [nouveau] [ 1730.734389] nouveau_pmops_runtime_suspend+0x59/0xc0 [nouveau] [ 1730.734391] ? pci_pm_runtime_resume+0xa0/0xa0 [ 1730.734392] pci_pm_runtime_suspend+0x55/0x170 [ 1730.734393] ? pci_pm_runtime_resume+0xa0/0xa0 [ 1730.734394] __rpm_callback+0xc1/0x1f0 [ 1730.734395] ? set_next_entity+0x162/0x610 [ 1730.734396] ? pci_pm_runtime_resume+0xa0/0xa0 [ 1730.734397] rpm_callback+0x24/0x80 [ 1730.73439...

On Sat, 2017-07-15 at 14:52 -0400, Ilia Mirkin wrote: > > OK, so this issue appears to be that we're calling > drm_crtc_vblank_off() on a crtc for which vblank is already disabled. > My guess is that this happens because the crtc is disabled. > > Not sure what the proper check is to see if vblanks are already disabled... Seems so, the below shut up suspend for both 8600 GT

...on+0x60/0x60 [ 246.899617] [<ffffffff8c6012e3>] pm_runtime_forbid+0x43/0x50 [ 246.899678] [<ffffffffc08f67c5>] nouveau_pmops_runtime_suspend+0xc5/0xd0 [nouveau] [ 246.899684] [<ffffffff8c4ced8d>] pci_pm_runtime_suspend+0x5d/0x190 [ 246.899687] [<ffffffff8c4ced30>] ? pci_pm_runtime_resume+0xa0/0xa0 [ 246.899690] [<ffffffff8c5ff252>] __rpm_callback+0x32/0x70 [ 246.899693] [<ffffffff8c5ff2b4>] rpm_callback+0x24/0x80 [ 246.899695] [<ffffffff8c4ced30>] ? pci_pm_runtime_resume+0xa0/0xa0 [ 246.899698] [<ffffffff8c5fffee>] rpm_suspend+0x11e/0x6f0 [ 246.8997...

...0050033 [ 12.768192] CR2: 000000edb16580b8 CR3: 000000020cc09000 CR4: 00000000003406f0 [ 12.768193] Call Trace: [ 12.768198] ? enqueue_task_fair+0x64/0x600 [ 12.768211] ? drm_get_last_vbltimestamp+0x47/0x70 [drm] [ 12.768223] ? drm_update_vblank_count+0x65/0x240 [drm] [ 12.768227] ? pci_pm_runtime_resume+0xa0/0xa0 [ 12.768238] ? drm_vblank_disable_and_save+0x55/0xc0 [drm] [ 12.768250] ? drm_crtc_vblank_off+0xa9/0x1e0 [drm] [ 12.768253] ? pci_pm_runtime_resume+0xa0/0xa0 [ 12.768299] ? nouveau_display_fini+0x56/0xd0 [nouveau] [ 12.768339] ? nouveau_display_suspend+0x51/0x110 [nouveau]...

...000000020cc09000 CR4: 00000000003406f0 > > [ 12.768193] Call Trace: > > [ 12.768198] ? enqueue_task_fair+0x64/0x600 > > [ 12.768211] ? drm_get_last_vbltimestamp+0x47/0x70 [drm] > > [ 12.768223] ? drm_update_vblank_count+0x65/0x240 [drm] > > [ 12.768227] ? pci_pm_runtime_resume+0xa0/0xa0 > > [ 12.768238] ? drm_vblank_disable_and_save+0x55/0xc0 [drm] > > [ 12.768250] ? drm_crtc_vblank_off+0xa9/0x1e0 [drm] > > [ 12.768253] ? pci_pm_runtime_resume+0xa0/0xa0 > > [ 12.768299] ? nouveau_display_fini+0x56/0xd0 [nouveau] > > [ 12.768339...

...deletions(-) > >> > >> diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c > >> index 3bed6beda051..51b11cbd48f6 100644 > >> --- a/drivers/pci/pci-driver.c > >> +++ b/drivers/pci/pci-driver.c > >> @@ -1277,10 +1277,14 @@ static int pci_pm_runtime_resume(struct device *dev) > >> > >> /* > >> * If pci_dev->driver is not set (unbound), the device should > >> - * always remain in D0 regardless of the runtime PM status > >> + * always remain in D0 regardless of the runtime PM status...

...6f0 >>>> [ 12.768193] Call Trace: >>>> [ 12.768198] ? enqueue_task_fair+0x64/0x600 >>>> [ 12.768211] ? drm_get_last_vbltimestamp+0x47/0x70 [drm] >>>> [ 12.768223] ? drm_update_vblank_count+0x65/0x240 [drm] >>>> [ 12.768227] ? pci_pm_runtime_resume+0xa0/0xa0 >>>> [ 12.768238] ? drm_vblank_disable_and_save+0x55/0xc0 [drm] >>>> [ 12.768250] ? drm_crtc_vblank_off+0xa9/0x1e0 [drm] >>>> [ 12.768253] ? pci_pm_runtime_resume+0xa0/0xa0 >>>> [ 12.768299] ? nouveau_display_fini+0x56/0xd0 [nouv...

...(I think): https://bugs.freedesktop.org/show_bug.cgi?id=98690 MacBook Pro 11.3 (GK107, GeForce GT 750M), Gentoo Linux, kernel 4.10.8. [ 49.196313] Workqueue: pm pm_runtime_work [ 49.196314] Call Trace: [ 49.196321] ? dump_stack+0x46/0x59 [ 49.196323] ? __warn+0xb9/0xe0 [ 49.196327] ? pci_pm_runtime_resume+0xa0/0xa0 [ 49.196329] ? warn_slowpath_fmt+0x4a/0x50 [ 49.196349] ? gen6_read32+0x92/0x1e0 [i915] [ 49.196369] ? hsw_enable_pc8+0x6b7/0x720 [i915] [ 49.196371] ? pci_pm_runtime_resume+0xa0/0xa0 [ 49.196384] ? intel_runtime_suspend+0x142/0x250 [i915] [ 49.196386] ? pci_pm_runtime_s...

...| 1 + > 3 files changed, 8 insertions(+), 3 deletions(-) > > diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c > index 3bed6beda051..51b11cbd48f6 100644 > --- a/drivers/pci/pci-driver.c > +++ b/drivers/pci/pci-driver.c > @@ -1277,10 +1277,14 @@ static int pci_pm_runtime_resume(struct device *dev) > > /* > * If pci_dev->driver is not set (unbound), the device should > - * always remain in D0 regardless of the runtime PM status > + * always remain in D0 regardless of the runtime PM status. > + * But if its parent can go to D3cold, this device...

We need to call drm_helper_hpd_irq_event() on resume to properly detect monitor connection / disconnection on some laptops. For runtime-resume (which gets called on resume from normal suspend too) we must call drm_helper_hpd_irq_event() from a workqueue to avoid a deadlock. Rename acpi_work to hpd_work, and move it out of the #ifdef CONFIG_ACPI blocks to make it suitable for generic work.

...8 dell-2017 kernel: ? drm_vma_offset_add+0x3c/0x60 feb 23 17:21:08 dell-2017 kernel: ? drm_mode_std+0x479/0x4a0 feb 23 17:21:08 dell-2017 kernel: ttm_mem_evict_first+0x18b/0x210 [ttm] feb 23 17:21:08 dell-2017 kernel: ttm_bo_force_list_clean+0x8a/0x150 [ttm] feb 23 17:21:08 dell-2017 kernel: ? pci_pm_runtime_resume+0xc0/0xc0 feb 23 17:21:08 dell-2017 kernel: nouveau_do_suspend+0x76/0x2a0 [nouveau] feb 23 17:21:08 dell-2017 kernel: nouveau_pmops_runtime_suspend+0x3d/0xa0 [nouveau] feb 23 17:21:08 dell-2017 kernel: pci_pm_runtime_suspend+0x56/0x150 feb 23 17:21:08 dell-2017 kernel: ? next_online_pgdat+0x1d/...

...cki wrote: > On Wednesday, February 21, 2018 10:57:14 AM CET Rafael J. Wysocki wrote: > > So if pci_pm_runtime_suspend() is modified to call pci_save_state() > > before returning 0 in the !dev->driver case, we can just move the > > pci_restore_standard_config() invocation in pci_pm_runtime_resume() up > > to the very top and check dev->driver later. > > I mean something like the patch below, overall (untested). > > Tentatively-signed-off-by: Rafael J. Wysocki <rafael.j.wysocki at intel.com> Okay I've tested this successfully now. I'll have to respin th...

...] [ 56.593328] nvkm_client_init+0xe/0x10 [nouveau] [ 56.593343] nvkm_client_resume+0xe/0x10 [nouveau] [ 56.593350] nvif_client_resume+0x14/0x20 [nouveau] [ 56.593365] nouveau_do_resume+0x4d/0x130 [nouveau] [ 56.593379] nouveau_pmops_runtime_resume+0x72/0x150 [nouveau] [ 56.593381] pci_pm_runtime_resume+0x7b/0xa0 [ 56.593382] __rpm_callback+0xc6/0x210 [ 56.593383] ? pci_restore_standard_config+0x40/0x40 [ 56.593384] rpm_callback+0x24/0x80 [ 56.593385] ? pci_restore_standard_config+0x40/0x40 [ 56.593385] rpm_resume+0x47d/0x680 [ 56.593400] ? i915_gem_timeline_init+0xe/0x10 [i915]...

...es changed, 8 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c >> index 3bed6beda051..51b11cbd48f6 100644 >> --- a/drivers/pci/pci-driver.c >> +++ b/drivers/pci/pci-driver.c >> @@ -1277,10 +1277,14 @@ static int pci_pm_runtime_resume(struct device *dev) >> >> /* >> * If pci_dev->driver is not set (unbound), the device should >> - * always remain in D0 regardless of the runtime PM status >> + * always remain in D0 regardless of the runtime PM status. >> + * But i...

...pm_runtime_resume __pm_runtime_resume(dev, 0) rpm_resume(dev, 0) __update_runtime_status(dev, RPM_RESUMING) callback = RPM_GET_CALLBACK(dev, runtime_resume) rpm_callback(callback, dev) __rpm_callback pci_pm_runtime_resume drv->pm->runtime_resume nouveau_pmops_runtime_resume nouveau_do_resume schedule_work(hpd_work) # <--- ... nouveau_display_hpd_work...

...53257ab8 > Call Trace: > [<ffffffffa021e4a2>] ? nouveau_display_init+0x42/0xd0 [nouveau] > [<ffffffffa021eda5>] ? nouveau_display_resume+0x15/0xa0 [nouveau] > [<ffffffffa020e7cb>] ? nouveau_pmops_runtime_resume+0x9b/0x100 [nouveau] > [<ffffffff812ac745>] ? pci_pm_runtime_resume+0x85/0xc0 > [<ffffffff812ac6c0>] ? pci_restore_standard_config+0x30/0x30 > [<ffffffff8137b6f6>] ? __rpm_callback+0x36/0x80 > [<ffffffff8137b768>] ? rpm_callback+0x28/0x90 > [<ffffffff8137c48d>] ? rpm_resume+0x39d/0x570 > [<ffffffff81071483>] ? __wak...

...D3cold when the bridge above it runtime suspends. + * Save its config space in case that happens. */ - if (!pci_dev->driver) + if (!pci_dev->driver) { + pci_save_state(pci_dev); return 0; + } if (!pm || !pm->runtime_suspend) return -ENOSYS; @@ -1276,16 +1279,18 @@ static int pci_pm_runtime_resume(struct device *dev) const struct dev_pm_ops *pm = dev->driver ? dev->driver->pm : NULL; /* - * If pci_dev->driver is not set (unbound), the device should - * always remain in D0 regardless of the runtime PM status + * Restoring config space is necessary even if the device is no...

...| 2 +- drivers/pci/pci.h | 1 + 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c index 3bed6beda051..51b11cbd48f6 100644 --- a/drivers/pci/pci-driver.c +++ b/drivers/pci/pci-driver.c @@ -1277,10 +1277,14 @@ static int pci_pm_runtime_resume(struct device *dev) /* * If pci_dev->driver is not set (unbound), the device should - * always remain in D0 regardless of the runtime PM status + * always remain in D0 regardless of the runtime PM status. + * But if its parent can go to D3cold, this device may have + * been in D3cold...