search for: pci_enable_msix

As result deprecation of MSI-X/MSI enablement functions pci_enable_msix() and pci_enable_msi_block() all drivers using these two interfaces need to be updated to use the new pci_enable_msi_range() and pci_enable_msix_range() interfaces. Signed-off-by: Alexander Gordeev <agordeev at redhat.com> Cc: Rusty Russell <rusty at rustcorp.com.au> Cc: "Michael...

As result deprecation of MSI-X/MSI enablement functions pci_enable_msix() and pci_enable_msi_block() all drivers using these two interfaces need to be updated to use the new pci_enable_msi_range() and pci_enable_msix_range() interfaces. Signed-off-by: Alexander Gordeev <agordeev at redhat.com> Cc: Rusty Russell <rusty at rustcorp.com.au> Cc: "Michael...

Hi Rusty et al, Based on recently accepted to the mainline pci_enable_msix_exact() function, I am sending a updated version of the patch. Please, let me know if it does not work for you and you need and incremental update from the previous version. Thanks! -- Regards, Alexander Gordeev agordeev at redhat.com

Hi Rusty et al, Based on recently accepted to the mainline pci_enable_msix_exact() function, I am sending a updated version of the patch. Please, let me know if it does not work for you and you need and incremental update from the previous version. Thanks! -- Regards, Alexander Gordeev agordeev at redhat.com

On Fri, Feb 21, 2014 at 06:01:28PM +0100, Alexander Gordeev wrote: > As result of deprecation of MSI-X/MSI enablement functions > pci_enable_msix() and pci_enable_msi_block() all drivers > using these two interfaces need to be updated to use the > new pci_enable_msi_range() or pci_enable_msi_exact() > and pci_enable_msix_range() or pci_enable_msix_exact() > interfaces. Acked-by: Michael S. Tsirkin <mst at redhat.com> &g...

On Fri, Feb 21, 2014 at 06:01:28PM +0100, Alexander Gordeev wrote: > As result of deprecation of MSI-X/MSI enablement functions > pci_enable_msix() and pci_enable_msi_block() all drivers > using these two interfaces need to be updated to use the > new pci_enable_msi_range() or pci_enable_msi_exact() > and pci_enable_msix_range() or pci_enable_msix_exact() > interfaces. Acked-by: Michael S. Tsirkin <mst at redhat.com> &g...

Alexander Gordeev <agordeev at redhat.com> writes: > As result deprecation of MSI-X/MSI enablement functions > pci_enable_msix() and pci_enable_msi_block() all drivers > using these two interfaces need to be updated to use the > new pci_enable_msi_range() and pci_enable_msix_range() > interfaces. > > Signed-off-by: Alexander Gordeev <agordeev at redhat.com> > Cc: Rusty Russell <rusty at rustcorp....

As result of deprecation of MSI-X/MSI enablement functions pci_enable_msix() and pci_enable_msi_block() all drivers using these two interfaces need to be updated to use the new pci_enable_msi_range() or pci_enable_msi_exact() and pci_enable_msix_range() or pci_enable_msix_exact() interfaces. Signed-off-by: Alexander Gordeev <agordeev at redhat.com> Cc: Rusty Russe...

From: Liu Yuan <tailai.ly at taobao.com> In the function vp_request_msix_vectors(), when pci_enable_msix() returns 0, there will be redundant double checks for 'err'. This patch fixes it to avoid the unnecessary check. Signed-off-by: Liu Yuan <tailai.ly at taobao.com> --- drivers/virtio/virtio_pci.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/...

From: Liu Yuan <tailai.ly at taobao.com> In the function vp_request_msix_vectors(), when pci_enable_msix() returns 0, there will be redundant double checks for 'err'. This patch fixes it to avoid the unnecessary check. Signed-off-by: Liu Yuan <tailai.ly at taobao.com> --- drivers/virtio/virtio_pci.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/...

pci_enable_msix currently returns -EINVAL if you ask for more vectors than supported by the device, which would typically cause fallback to regular interrupts. It's better to return the table size, making the driver retry MSI-X with less vectors. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --...

pci_enable_msix currently returns -EINVAL if you ask for more vectors than supported by the device, which would typically cause fallback to regular interrupts. It's better to return the table size, making the driver retry MSI-X with less vectors. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --...

...nts for MSI-X */ @@ -278,27 +280,24 @@ static void vp_free_vectors(struct virtio_device *vdev) vp_dev->msix_entries = NULL; } -static int vp_enable_msix(struct pci_dev *dev, struct msix_entry *entries, - int *options, int noptions) -{ - int i; - for (i = 0; i < noptions; ++i) - if (!pci_enable_msix(dev, entries, options[i])) - return options[i]; - return -EBUSY; -} - -static int vp_request_vectors(struct virtio_device *vdev, unsigned max_vqs) +static int vp_request_vectors(struct virtio_device *vdev, int nvectors, + bool per_vq_vectors) { struct virtio_pci_device *vp_dev = to_vp_...

...nts for MSI-X */ @@ -278,27 +280,24 @@ static void vp_free_vectors(struct virtio_device *vdev) vp_dev->msix_entries = NULL; } -static int vp_enable_msix(struct pci_dev *dev, struct msix_entry *entries, - int *options, int noptions) -{ - int i; - for (i = 0; i < noptions; ++i) - if (!pci_enable_msix(dev, entries, options[i])) - return options[i]; - return -EBUSY; -} - -static int vp_request_vectors(struct virtio_device *vdev, unsigned max_vqs) +static int vp_request_vectors(struct virtio_device *vdev, int nvectors, + bool per_vq_vectors) { struct virtio_pci_device *vp_dev = to_vp_...

1) Rename vp_request_vectors to vp_request_msix_vectors, and take non-MSI-X case out to caller. 2) Comment weird pci_enable_msix API 3) Rename vp_find_vq to setup_vq. 4) Fix spaces to tabs 5) Make nvectors calc internal to vp_try_to_find_vqs() 6) Rename vector to msix_vector for more clarity. Signed-off-by: Rusty Russell <rusty at rustcorp.com.au> Cc: "Michael S. Tsirkin" <mst at redhat.com> --- drive...

1) Rename vp_request_vectors to vp_request_msix_vectors, and take non-MSI-X case out to caller. 2) Comment weird pci_enable_msix API 3) Rename vp_find_vq to setup_vq. 4) Fix spaces to tabs 5) Make nvectors calc internal to vp_try_to_find_vqs() 6) Rename vector to msix_vector for more clarity. Signed-off-by: Rusty Russell <rusty at rustcorp.com.au> Cc: "Michael S. Tsirkin" <mst at redhat.com> --- drive...

...------------------------------------------------------------ Nothing exciting: virtio-blk users might see a bit of a boost from the doubling of the default queue length though. Cheers, Rusty. ---------------------------------------------------------------- Alexander Gordeev (1): virtio: Use pci_enable_msix_exact() instead of pci_enable_msix() Joel Stanley (3): tools/virtio: update internal copies of headers tools/virtio: fix missing kmemleak_ignore symbol tools/virtio: add a missing ) Randy Dunlap (1): MAINTAINERS: virtio-dev is subscribers only Rusty Russell (8): vir...

...------------------------------------------------------------ Nothing exciting: virtio-blk users might see a bit of a boost from the doubling of the default queue length though. Cheers, Rusty. ---------------------------------------------------------------- Alexander Gordeev (1): virtio: Use pci_enable_msix_exact() instead of pci_enable_msix() Joel Stanley (3): tools/virtio: update internal copies of headers tools/virtio: fix missing kmemleak_ignore symbol tools/virtio: add a missing ) Randy Dunlap (1): MAINTAINERS: virtio-dev is subscribers only Rusty Russell (8): vir...

...nfo->msix_entries, > + GFP_KERNEL); > + ivs_info->msix_names = kmalloc(nvectors * sizeof *ivs_info->msix_names, > + GFP_KERNEL); > + > + for (i = 0; i < nvectors; ++i) > + ivs_info->msix_entries[i].entry = i; > + > + err = pci_enable_msix(ivs_info->dev, ivs_info->msix_entries, > + ivs_info->nvectors); > + if (err > 0) { > + ivs_info->nvectors = err; /* msi-x positive error code > + returns the number available*/ > + err = pci_enable...

...nfo->msix_entries, > + GFP_KERNEL); > + ivs_info->msix_names = kmalloc(nvectors * sizeof *ivs_info->msix_names, > + GFP_KERNEL); > + > + for (i = 0; i < nvectors; ++i) > + ivs_info->msix_entries[i].entry = i; > + > + err = pci_enable_msix(ivs_info->dev, ivs_info->msix_entries, > + ivs_info->nvectors); > + if (err > 0) { > + ivs_info->nvectors = err; /* msi-x positive error code > + returns the number available*/ > + err = pci_enable...