search for: pci_device_sub

...;> How about using a dedicated subsystem vendor id for this? >> >> Thanks > If virtio vendor id is used then standard driver is expected > to bind, right? Maybe use a dedicated vendor id? I meant something like: static const struct pci_device_id vp_vdpa_id_table[] = { ??? { PCI_DEVICE_SUB(PCI_VENDOR_ID_REDHAT_QUMRANET, PCI_ANY_ID, VP_TEST_VENDOR_ID, VP_TEST_DEVICE_ID) }, ??? { 0 } }; Thanks

...;> How about using a dedicated subsystem vendor id for this? >> >> Thanks > If virtio vendor id is used then standard driver is expected > to bind, right? Maybe use a dedicated vendor id? I meant something like: static const struct pci_device_id vp_vdpa_id_table[] = { ??? { PCI_DEVICE_SUB(PCI_VENDOR_ID_REDHAT_QUMRANET, PCI_ANY_ID, VP_TEST_VENDOR_ID, VP_TEST_DEVICE_ID) }, ??? { 0 } }; Thanks

...t;> >>>> Thanks >>> If virtio vendor id is used then standard driver is expected >>> to bind, right? Maybe use a dedicated vendor id? >> >> I meant something like: >> >> static const struct pci_device_id vp_vdpa_id_table[] = { >> ??? { PCI_DEVICE_SUB(PCI_VENDOR_ID_REDHAT_QUMRANET, PCI_ANY_ID, >> VP_TEST_VENDOR_ID, VP_TEST_DEVICE_ID) }, >> ??? { 0 } >> }; >> >> Thanks >> > Then regular virtio will still bind to it. It has > > drivers/virtio/virtio_pci_common.c: { PCI_DEVICE(PCI_VENDOR_ID_REDHAT_Q...

...t;> >>>> Thanks >>> If virtio vendor id is used then standard driver is expected >>> to bind, right? Maybe use a dedicated vendor id? >> >> I meant something like: >> >> static const struct pci_device_id vp_vdpa_id_table[] = { >> ??? { PCI_DEVICE_SUB(PCI_VENDOR_ID_REDHAT_QUMRANET, PCI_ANY_ID, >> VP_TEST_VENDOR_ID, VP_TEST_DEVICE_ID) }, >> ??? { 0 } >> }; >> >> Thanks >> > Then regular virtio will still bind to it. It has > > drivers/virtio/virtio_pci_common.c: { PCI_DEVICE(PCI_VENDOR_ID_REDHAT_Q...

On 2020/6/2 ??3:08, Jason Wang wrote: >> >>> +static const struct pci_device_id vp_vdpa_id_table[] = { >>> +??? { PCI_DEVICE(PCI_VENDOR_ID_REDHAT_QUMRANET, PCI_ANY_ID) }, >>> +??? { 0 } >>> +}; >> This looks like it'll create a mess with either virtio pci >> or vdpa being loaded at random. Maybe just don't specify >> any IDs for

...d for this? > > > > > > Thanks > > If virtio vendor id is used then standard driver is expected > > to bind, right? Maybe use a dedicated vendor id? > > > I meant something like: > > static const struct pci_device_id vp_vdpa_id_table[] = { > ??? { PCI_DEVICE_SUB(PCI_VENDOR_ID_REDHAT_QUMRANET, PCI_ANY_ID, > VP_TEST_VENDOR_ID, VP_TEST_DEVICE_ID) }, > ??? { 0 } > }; > > Thanks > Then regular virtio will still bind to it. It has drivers/virtio/virtio_pci_common.c: { PCI_DEVICE(PCI_VENDOR_ID_REDHAT_QUMRANET, PCI_ANY_ID) }, -- MST

...> If virtio vendor id is used then standard driver is expected > > > > to bind, right? Maybe use a dedicated vendor id? > > > > > > I meant something like: > > > > > > static const struct pci_device_id vp_vdpa_id_table[] = { > > > ??? { PCI_DEVICE_SUB(PCI_VENDOR_ID_REDHAT_QUMRANET, PCI_ANY_ID, > > > VP_TEST_VENDOR_ID, VP_TEST_DEVICE_ID) }, > > > ??? { 0 } > > > }; > > > > > > Thanks > > > > > Then regular virtio will still bind to it. It has > > > > drivers/virtio/virtio...

On 2020/6/2 ??3:08, Jason Wang wrote: >> >>> +static const struct pci_device_id vp_vdpa_id_table[] = { >>> +??? { PCI_DEVICE(PCI_VENDOR_ID_REDHAT_QUMRANET, PCI_ANY_ID) }, >>> +??? { 0 } >>> +}; >> This looks like it'll create a mess with either virtio pci >> or vdpa being loaded at random. Maybe just don't specify >> any IDs for

...gt;>> If virtio vendor id is used then standard driver is expected >>>>> to bind, right? Maybe use a dedicated vendor id? >>>> I meant something like: >>>> >>>> static const struct pci_device_id vp_vdpa_id_table[] = { >>>> ??? { PCI_DEVICE_SUB(PCI_VENDOR_ID_REDHAT_QUMRANET, PCI_ANY_ID, >>>> VP_TEST_VENDOR_ID, VP_TEST_DEVICE_ID) }, >>>> ??? { 0 } >>>> }; >>>> >>>> Thanks >>>> >>> Then regular virtio will still bind to it. It has >>> >>> dr...

...gt;>> If virtio vendor id is used then standard driver is expected >>>>> to bind, right? Maybe use a dedicated vendor id? >>>> I meant something like: >>>> >>>> static const struct pci_device_id vp_vdpa_id_table[] = { >>>> ??? { PCI_DEVICE_SUB(PCI_VENDOR_ID_REDHAT_QUMRANET, PCI_ANY_ID, >>>> VP_TEST_VENDOR_ID, VP_TEST_DEVICE_ID) }, >>>> ??? { 0 } >>>> }; >>>> >>>> Thanks >>>> >>> Then regular virtio will still bind to it. It has >>> >>> dr...

...e[i].addr = NULL; > + } > + } > + > + ifcvf_destroy_adapter(adapter); > + pci_free_irq_vectors(pdev); > + > + pci_release_regions(pdev); > + pci_disable_device(pdev); > + > + kfree(adapter); > +} > + > +static struct pci_device_id ifcvf_pci_ids[] = { > + { PCI_DEVICE_SUB(IFCVF_VENDOR_ID, > + IFCVF_DEVICE_ID, > + IFCVF_SUBSYS_VENDOR_ID, > + IFCVF_SUBSYS_DEVICE_ID) }, > + { 0 }, > +}; > +MODULE_DEVICE_TABLE(pci, ifcvf_pci_ids); > + > +static struct pci_driver ifcvf_driver = { > + .name = IFCVF_DRIVER_NAME, > + .id_table = ifcvf...

...gt;mem_resource[i].addr = NULL; > + } > + } > + > + ifcvf_destroy_adapter(adapter); > + pci_free_irq_vectors(pdev); > + pci_release_regions(pdev); > + pci_disable_device(pdev); > + kfree(adapter); > +} > + > +static struct pci_device_id ifcvf_pci_ids[] = { > + { PCI_DEVICE_SUB(IFCVF_VENDOR_ID, > + IFCVF_DEVICE_ID, > + IFCVF_SUBSYS_VENDOR_ID, > + IFCVF_SUBSYS_DEVICE_ID) }, > + { 0 }, > +}; > +MODULE_DEVICE_TABLE(pci, ifcvf_pci_ids); > + > +static struct pci_driver ifcvf_driver = { > + .name = IFCVF_DRIVER_NAME, > + .id_table = ifcvf...

Time to kill some bad sample code people are copying from ;) This is a complete rewrite of the cirrus driver. The cirrus_mode_set() function is pretty much the only function which is carried over largely unmodified. Everything else is upside down. It is a single monster patch. But given that it does some pretty fundamental changes to the drivers workflow and also reduces the code size by