search for: pbmtext

Hi, the libguestfs library uses a number of external tools; for some of them, we search for them at build time, enabling some feature only if found, and later on assuming at runtime they are installed. However, the situation is more complex than that: - hardcoding the full path means that there is an incoherency in the way some of the tools are used, as some other tools (e.g. qemu-img) are

Hi, the libguestfs library uses a number of external tools; for some of them, we search for them at build time, enabling some feature only if found, and later on assuming at runtime they are installed. However, the situation is more complex than that: - hardcoding the full path means that there is an incoherency in the way some of the tools are used, as some other tools (e.g. qemu-img) are

...NE_UNQUOTED([DB_LOAD],["$DB_LOAD"],[Name of db_load program.]) -fi +AC_DEFINE_UNQUOTED([DB_DUMP],["$DB_DUMP"],[Name of db_dump program.]) +AC_DEFINE_UNQUOTED([DB_LOAD],["$DB_LOAD"],[Name of db_load program.]) dnl Check for netpbm programs (optional). AC_PATH_PROGS([PBMTEXT],[pbmtext],[no]) -- 2.19.0.rc0

Fix for: https://bugzilla.redhat.com/show_bug.cgi?id=1409024

...stfs_disk_create (g, filename, "raw", size, -1) == -1) diff --git a/lib/inspect-icon.c b/lib/inspect-icon.c index 3e44b23eb..533e9fb4b 100644 --- a/lib/inspect-icon.c +++ b/lib/inspect-icon.c @@ -390,7 +390,9 @@ icon_cirros (guestfs_h *g, size_t *size_r) return NOT_FOUND; /* Use pbmtext to render it. */ - pngfile = safe_asprintf (g, "%s/cirros.png", g->tmpdir); + pngfile = guestfs_int_make_temp_path (g, "cirros", "png"); + if (!pngfile) + return NOT_FOUND; guestfs_int_cmd_add_string_unquoted (cmd, PBMTEXT " < "); guestfs_...

We went around the houses a few times last year in order to try to fix this old Debian bug: https://bugzilla.redhat.com/show_bug.cgi?id=1409024 My last attempt was: https://www.redhat.com/archives/libguestfs/2017-October/msg00058.html which I believe was neither reviewed nor rejected, so I'm reposting the same patch again, simply rebased against current git. Rich.

Previously posted: https://www.redhat.com/archives/libguestfs/2017-October/msg00032.html This takes a completely different approach. It turns out that POSIX / the shell already defines a special exit code 127 for ‘command not found’. We can make a small adjustment to lib/command.c to return this exit code in that case. Then we just have to modify the db_dump code to test for this exit code. I

This function returns -1 if things like fork(2) fail, so it is right to return an error here. If the PBMTEXT command fails then that's a NOT_FOUND case. --- lib/inspect-icon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/inspect-icon.c b/lib/inspect-icon.c index 533e9fb4b..0edd3d1b0 100644 --- a/lib/inspect-icon.c +++ b/lib/inspect-icon.c @@ -400,7 +400,7 @@ icon_cirros (gu...

v1 -> v2: - Remove the unnecessary calls to guestfs_int_lazy_make_tmpdir in the final patch. Rich.

Miscellaneous small cleanups in lib/ directory. Rich.

Two (not related to each other) refactorings: Patches 1-12 split configure.ac into smaller files using the m4_include mechanism. Patches 13-15 split out parts of guestfs.pod (ie. guestfs(3)) into three new manual pages: guestfs-hacking(3) - how to extend and contribute to libguestfs guestfs-internals(3) - architecture and internals guestfs-security(3) - security and CVEs Patch 16 is a

Inspired by libvirt's virCommand* internal mini-library, this adds some internal APIs for running commands. The first patch contains the new APIs. The subsequent patches change various parts of the library over to use it. Rich.

...t;errno.h> #include <sys/wait.h> #include "guestfs.h" #include "guestfs-internal.h" #include "guestfs-internal-actions.h" -#include "guestfs_protocol.h" /* External tools are required for some icon types. Check we have them. */ #if defined(PBMTEXT) && defined (PNMTOPNG) diff --git a/src/inspect.c b/src/inspect.c index 0cc3d9f..1eac037 100644 --- a/src/inspect.c +++ b/src/inspect.c @@ -20,13 +20,11 @@ #include <stdio.h> #include <stdlib.h> -#include <stdint.h> #include <inttypes.h> #include <unistd.h&g...

--- generator/c.ml | 2 -- 1 file changed, 2 deletions(-) diff --git a/generator/c.ml b/generator/c.ml index 055b683..963cf21 100644 --- a/generator/c.ml +++ b/generator/c.ml @@ -1213,9 +1213,7 @@ and generate_client_actions hash () = #include <stdlib.h> #include <stdint.h> #include <inttypes.h> -#include <sys/types.h> #include <sys/stat.h> -#include

This patch series changes a small part of the library to use __attribute__((cleanup(...))) to automatically free memory when pointers go out of the current scope. In general terms this seems to be a small win although you do have to use it carefully. For functions where you can completely get rid of the "exit code paths", it can simplify things. For a good example, see the

...ng for db4_dump... no checking for db4.8_dump... no checking for db4.7_dump... no checking for db4.6_dump... no checking for db_load... no checking for db5.1_load... no checking for db4_load... no checking for db4.8_load... no checking for db4.7_load... no checking for db4.6_load... no checking for pbmtext... no checking for pnmtopng... no checking for bmptopnm... no checking for pamcut... no checking for wrestool... no checking for xzcat... /usr/bin/xzcat checking for pkg-config... /usr/bin/pkg-config checking pkg-config is at least version 0.9.0... yes checking for LIBLZMA... yes checking for lzma_...

libguestfs has used double and triple underscores in identifiers. These aren't valid for global names in C++. (http://stackoverflow.com/a/228797) These large but completely mechanical patches change the illegal identifiers to legal ones. Rich.

...const char *eregex, int iflag, char **ret) + const char *eregex, int iflag, char **ret) { char **lines; int64_t size; diff --git a/src/inspect-icon.c b/src/inspect-icon.c index fe38266..748680d 100644 --- a/src/inspect-icon.c +++ b/src/inspect-icon.c @@ -32,8 +32,8 @@ #if defined(PBMTEXT) && defined (PNMTOPNG) #define CAN_DO_CIRROS 1 #endif -#if defined(WRESTOOL) && defined(BMPTOPNM) && defined(PNMTOPNG) && \ - defined(PAMCUT) +#if defined(WRESTOOL) && defined(BMPTOPNM) && defined(PNMTOPNG) && \ + defined(PAMCUT) #defin...

Hi Rich Yes Rich I have tried libguesftfs on powerpc and it was working fine.For some reason i had to format my hard disk and now when I'm again compiling it,I'm getting following error.... Below is the status of configure .. This is how we have configured the optional components for you today: Daemon .............................. yes Appliance ........................... yes QEMU

Result of earlier copy and paste. --- align/scan.c | 35 ++++++++++--------- cat/cat.c | 39 +++++++++++---------- cat/filesystems.c | 69 +++++++++++++++++++------------------- cat/log.c | 35 ++++++++++--------- cat/ls.c | 61 +++++++++++++++++---------------- df/main.c | 43 ++++++++++++------------ diff/diff.c | 67